From: "Gustavo A. R. Silva" <gustavoars@kernel.org> To: Kees Cook <keescook@chromium.org> Cc: Miquel Raynal <miquel.raynal@bootlin.com>, Conor Culhane <conor.culhane@silvaco.com>, Alexandre Belloni <alexandre.belloni@bootlin.com>, linux-i3c@lists.infradead.org, Nathan Chancellor <nathan@kernel.org>, Nick Desaulniers <ndesaulniers@google.com>, Tom Rix <trix@redhat.com>, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org Subject: Re: [PATCH] i3c: svc: Annotate struct svc_i3c_xfer with __counted_by Date: Sat, 23 Sep 2023 10:58:55 -0600 [thread overview] Message-ID: <ZQ8ZTwbg56QgmRTd@work> (raw) In-Reply-To: <20230922175023.work.239-kees@kernel.org> On Fri, Sep 22, 2023 at 10:50:23AM -0700, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct svc_i3c_xfer. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Miquel Raynal <miquel.raynal@bootlin.com> > Cc: Conor Culhane <conor.culhane@silvaco.com> > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> > Cc: linux-i3c@lists.infradead.org > Signed-off-by: Kees Cook <keescook@chromium.org> Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org> Thanks -- Gustavo > --- > drivers/i3c/master/svc-i3c-master.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c > index 8f8295acdadb..32eca2d6caf0 100644 > --- a/drivers/i3c/master/svc-i3c-master.c > +++ b/drivers/i3c/master/svc-i3c-master.c > @@ -143,7 +143,7 @@ struct svc_i3c_xfer { > int ret; > unsigned int type; > unsigned int ncmds; > - struct svc_i3c_cmd cmds[]; > + struct svc_i3c_cmd cmds[] __counted_by(ncmds); > }; > > struct svc_i3c_regs_save { > -- > 2.34.1 > >
WARNING: multiple messages have this Message-ID (diff)
From: "Gustavo A. R. Silva" <gustavoars@kernel.org> To: Kees Cook <keescook@chromium.org> Cc: Miquel Raynal <miquel.raynal@bootlin.com>, Conor Culhane <conor.culhane@silvaco.com>, Alexandre Belloni <alexandre.belloni@bootlin.com>, linux-i3c@lists.infradead.org, Nathan Chancellor <nathan@kernel.org>, Nick Desaulniers <ndesaulniers@google.com>, Tom Rix <trix@redhat.com>, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org Subject: Re: [PATCH] i3c: svc: Annotate struct svc_i3c_xfer with __counted_by Date: Sat, 23 Sep 2023 10:58:55 -0600 [thread overview] Message-ID: <ZQ8ZTwbg56QgmRTd@work> (raw) In-Reply-To: <20230922175023.work.239-kees@kernel.org> On Fri, Sep 22, 2023 at 10:50:23AM -0700, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct svc_i3c_xfer. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Miquel Raynal <miquel.raynal@bootlin.com> > Cc: Conor Culhane <conor.culhane@silvaco.com> > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> > Cc: linux-i3c@lists.infradead.org > Signed-off-by: Kees Cook <keescook@chromium.org> Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org> Thanks -- Gustavo > --- > drivers/i3c/master/svc-i3c-master.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c > index 8f8295acdadb..32eca2d6caf0 100644 > --- a/drivers/i3c/master/svc-i3c-master.c > +++ b/drivers/i3c/master/svc-i3c-master.c > @@ -143,7 +143,7 @@ struct svc_i3c_xfer { > int ret; > unsigned int type; > unsigned int ncmds; > - struct svc_i3c_cmd cmds[]; > + struct svc_i3c_cmd cmds[] __counted_by(ncmds); > }; > > struct svc_i3c_regs_save { > -- > 2.34.1 > > -- linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2023-09-23 8:57 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-09-22 17:50 [PATCH] i3c: svc: Annotate struct svc_i3c_xfer with __counted_by Kees Cook 2023-09-22 17:50 ` Kees Cook 2023-09-22 17:55 ` Miquel Raynal 2023-09-22 17:55 ` Miquel Raynal 2023-09-23 16:58 ` Gustavo A. R. Silva [this message] 2023-09-23 16:58 ` Gustavo A. R. Silva 2023-09-25 21:37 ` Alexandre Belloni 2023-09-25 21:37 ` Alexandre Belloni
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZQ8ZTwbg56QgmRTd@work \ --to=gustavoars@kernel.org \ --cc=alexandre.belloni@bootlin.com \ --cc=conor.culhane@silvaco.com \ --cc=keescook@chromium.org \ --cc=linux-hardening@vger.kernel.org \ --cc=linux-i3c@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=llvm@lists.linux.dev \ --cc=miquel.raynal@bootlin.com \ --cc=nathan@kernel.org \ --cc=ndesaulniers@google.com \ --cc=trix@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.