From: "Russell King (Oracle)" <linux@armlinux.org.uk> To: Alexandre Torgue <alexandre.torgue@foss.st.com>, Jose Abreu <joabreu@synopsys.com> Cc: Alexei Starovoitov <ast@kernel.org>, bpf@vger.kernel.org, Daniel Borkmann <daniel@iogearbox.net>, "David S. Miller" <davem@davemloft.net>, Emil Renner Berthing <kernel@esmil.dk>, Eric Dumazet <edumazet@google.com>, Fabio Estevam <festevam@gmail.com>, Jakub Kicinski <kuba@kernel.org>, Jesper Dangaard Brouer <hawk@kernel.org>, John Fastabend <john.fastabend@gmail.com>, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin <mcoquelin.stm32@gmail.com>, netdev@vger.kernel.org, NXP Linux Team <linux-imx@nxp.com>, Paolo Abeni <pabeni@redhat.com>, Pengutronix Kernel Team <kernel@pengutronix.de>, Samin Guo <samin.guo@starfivetech.com>, Sascha Hauer <s.hauer@pengutronix.de>, Shawn Guo <shawnguo@kernel.org> Subject: [PATCH net-next v2 0/6] net: stmmac: add and use library for setting clock Date: Thu, 14 Sep 2023 14:50:23 +0100 [thread overview] Message-ID: <ZQMPnyutz6T23E8T@shell.armlinux.org.uk> (raw) Hi, There is a common theme throughout several "bsps" in the stmmac driver which all code up the same thing: for 10M, 100M and 1G, select the appropriate 2.5MHz, 25MHz, or 125MHz clock. Rather than having every BSP implement the same thing but slightly differently, let's provide a single implementation which is passed the struct clk and the speed, and have that do the speed to clock rate decode. Note: only build tested. v2: - move dwmac_set_tx_clk_gmii() to stmmac_platform, and rename to have stmmac_ prefix. - add comment body to conversion patches - use %u for printing speed .../ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c | 36 ++++--------- drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c | 26 +++------- .../net/ethernet/stmicro/stmmac/dwmac-intel-plat.c | 34 +++--------- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 60 ++++++---------------- .../net/ethernet/stmicro/stmmac/dwmac-starfive.c | 28 +++------- .../net/ethernet/stmicro/stmmac/stmmac_platform.c | 25 +++++++++ .../net/ethernet/stmicro/stmmac/stmmac_platform.h | 1 + 7 files changed, 74 insertions(+), 136 deletions(-) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk> To: Alexandre Torgue <alexandre.torgue@foss.st.com>, Jose Abreu <joabreu@synopsys.com> Cc: Alexei Starovoitov <ast@kernel.org>, bpf@vger.kernel.org, Daniel Borkmann <daniel@iogearbox.net>, "David S. Miller" <davem@davemloft.net>, Emil Renner Berthing <kernel@esmil.dk>, Eric Dumazet <edumazet@google.com>, Fabio Estevam <festevam@gmail.com>, Jakub Kicinski <kuba@kernel.org>, Jesper Dangaard Brouer <hawk@kernel.org>, John Fastabend <john.fastabend@gmail.com>, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin <mcoquelin.stm32@gmail.com>, netdev@vger.kernel.org, NXP Linux Team <linux-imx@nxp.com>, Paolo Abeni <pabeni@redhat.com>, Pengutronix Kernel Team <kernel@pengutronix.de>, Samin Guo <samin.guo@starfivetech.com>, Sascha Hauer <s.hauer@pengutronix.de>, Shawn Guo <shawnguo@kernel.org> Subject: [PATCH net-next v2 0/6] net: stmmac: add and use library for setting clock Date: Thu, 14 Sep 2023 14:50:23 +0100 [thread overview] Message-ID: <ZQMPnyutz6T23E8T@shell.armlinux.org.uk> (raw) Hi, There is a common theme throughout several "bsps" in the stmmac driver which all code up the same thing: for 10M, 100M and 1G, select the appropriate 2.5MHz, 25MHz, or 125MHz clock. Rather than having every BSP implement the same thing but slightly differently, let's provide a single implementation which is passed the struct clk and the speed, and have that do the speed to clock rate decode. Note: only build tested. v2: - move dwmac_set_tx_clk_gmii() to stmmac_platform, and rename to have stmmac_ prefix. - add comment body to conversion patches - use %u for printing speed .../ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c | 36 ++++--------- drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c | 26 +++------- .../net/ethernet/stmicro/stmmac/dwmac-intel-plat.c | 34 +++--------- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 60 ++++++---------------- .../net/ethernet/stmicro/stmmac/dwmac-starfive.c | 28 +++------- .../net/ethernet/stmicro/stmmac/stmmac_platform.c | 25 +++++++++ .../net/ethernet/stmicro/stmmac/stmmac_platform.h | 1 + 7 files changed, 74 insertions(+), 136 deletions(-) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next reply other threads:[~2023-09-14 13:51 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-09-14 13:50 Russell King (Oracle) [this message] 2023-09-14 13:50 ` [PATCH net-next v2 0/6] net: stmmac: add and use library for setting clock Russell King (Oracle) 2023-09-14 13:51 ` [PATCH net-next 1/6] net: stmmac: add stmmac_set_tx_clk_gmii() Russell King (Oracle) 2023-09-14 13:51 ` Russell King (Oracle) 2023-09-14 14:54 ` Serge Semin 2023-09-14 14:54 ` Serge Semin 2023-09-14 15:12 ` Russell King (Oracle) 2023-09-14 15:12 ` Russell King (Oracle) 2023-09-14 16:06 ` Serge Semin 2023-09-14 16:06 ` Serge Semin 2023-09-14 13:51 ` [PATCH net-next 2/6] net: stmmac: imx: use stmmac_set_tx_clk_gmii() Russell King (Oracle) 2023-09-14 13:51 ` Russell King (Oracle) 2023-09-14 14:59 ` Serge Semin 2023-09-14 14:59 ` Serge Semin 2023-09-14 13:51 ` [PATCH net-next 3/6] net: stmmac: intel-plat: " Russell King (Oracle) 2023-09-14 13:51 ` Russell King (Oracle) 2023-09-14 15:00 ` Serge Semin 2023-09-14 15:00 ` Serge Semin 2023-09-14 13:51 ` [PATCH net-next 4/6] net: stmmac: rk: " Russell King (Oracle) 2023-09-14 13:51 ` Russell King (Oracle) 2023-09-14 14:37 ` Serge Semin 2023-09-14 14:37 ` Serge Semin 2023-09-14 15:03 ` Russell King (Oracle) 2023-09-14 15:03 ` Russell King (Oracle) 2023-09-14 15:22 ` Serge Semin 2023-09-14 15:22 ` Serge Semin 2023-09-14 15:27 ` Russell King (Oracle) 2023-09-14 15:27 ` Russell King (Oracle) 2023-09-14 15:30 ` Russell King (Oracle) 2023-09-14 15:30 ` Russell King (Oracle) 2023-09-14 16:01 ` Jose Abreu 2023-09-14 16:01 ` Jose Abreu 2023-09-14 17:05 ` Serge Semin 2023-09-14 17:05 ` Serge Semin 2023-09-15 8:38 ` Jose Abreu 2023-09-15 8:38 ` Jose Abreu 2023-09-16 20:17 ` Serge Semin 2023-09-16 20:17 ` Serge Semin 2023-09-14 13:51 ` [PATCH net-next 5/6] net: stmmac: starfive: " Russell King (Oracle) 2023-09-14 13:51 ` Russell King (Oracle) 2023-09-14 15:04 ` Serge Semin 2023-09-14 15:04 ` Serge Semin 2023-09-14 13:51 ` [PATCH net-next 6/6] net: stmmac: qos-eth: " Russell King (Oracle) 2023-09-14 13:51 ` Russell King (Oracle)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZQMPnyutz6T23E8T@shell.armlinux.org.uk \ --to=linux@armlinux.org.uk \ --cc=alexandre.torgue@foss.st.com \ --cc=ast@kernel.org \ --cc=bpf@vger.kernel.org \ --cc=daniel@iogearbox.net \ --cc=davem@davemloft.net \ --cc=edumazet@google.com \ --cc=festevam@gmail.com \ --cc=hawk@kernel.org \ --cc=joabreu@synopsys.com \ --cc=john.fastabend@gmail.com \ --cc=kernel@esmil.dk \ --cc=kernel@pengutronix.de \ --cc=kuba@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=pabeni@redhat.com \ --cc=s.hauer@pengutronix.de \ --cc=samin.guo@starfivetech.com \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.