From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Rob Herring <robh@kernel.org>,
linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>,
Hanjun Guo <guohanjun@huawei.com>,
Sudeep Holla <sudeep.holla@arm.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Russell King <linux@armlinux.org.uk>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH v1 1/1] amba: bus: balance firmware node reference counting
Date: Tue, 19 Sep 2023 23:01:36 +0300 [thread overview]
Message-ID: <ZQn+IMMuPpwwZGPp@smile.fi.intel.com> (raw)
In-Reply-To: <20230824162654.2890992-1-andriy.shevchenko@linux.intel.com>
On Thu, Aug 24, 2023 at 07:26:54PM +0300, Andy Shevchenko wrote:
> Currently the ACPI code doesn't bump the reference count of
> the firmware node, while OF counter part does. Not that it's
> a problem right now, since ACPI doesn't really use the reference
> counting for firmware nodes, it still makes sense to make code
> robust against any changes done there. For this,
> - switch ACPI case to use device_set_node() to be unified with OF
> - move reference counting to amba_device_add()
> - switch to use firmware nodes instead of OF ones
>
> In the result we will have reference counting done in the same module
> for all callers independently on the nature of firmware node behind.
Any comment on this? I would like to have this applied so I can do something
similar to the platform driver code.
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Rob Herring <robh@kernel.org>,
linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>,
Hanjun Guo <guohanjun@huawei.com>,
Sudeep Holla <sudeep.holla@arm.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Russell King <linux@armlinux.org.uk>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH v1 1/1] amba: bus: balance firmware node reference counting
Date: Tue, 19 Sep 2023 23:01:36 +0300 [thread overview]
Message-ID: <ZQn+IMMuPpwwZGPp@smile.fi.intel.com> (raw)
In-Reply-To: <20230824162654.2890992-1-andriy.shevchenko@linux.intel.com>
On Thu, Aug 24, 2023 at 07:26:54PM +0300, Andy Shevchenko wrote:
> Currently the ACPI code doesn't bump the reference count of
> the firmware node, while OF counter part does. Not that it's
> a problem right now, since ACPI doesn't really use the reference
> counting for firmware nodes, it still makes sense to make code
> robust against any changes done there. For this,
> - switch ACPI case to use device_set_node() to be unified with OF
> - move reference counting to amba_device_add()
> - switch to use firmware nodes instead of OF ones
>
> In the result we will have reference counting done in the same module
> for all callers independently on the nature of firmware node behind.
Any comment on this? I would like to have this applied so I can do something
similar to the platform driver code.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-19 20:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 16:26 [PATCH v1 1/1] amba: bus: balance firmware node reference counting Andy Shevchenko
2023-08-24 16:26 ` Andy Shevchenko
2023-08-24 19:54 ` kernel test robot
2023-08-24 19:54 ` kernel test robot
2023-08-24 20:59 ` kernel test robot
2023-08-24 20:59 ` kernel test robot
2023-09-19 20:01 ` Andy Shevchenko [this message]
2023-09-19 20:01 ` Andy Shevchenko
2023-09-19 20:02 ` Andy Shevchenko
2023-09-19 20:02 ` Andy Shevchenko
2023-09-22 14:18 ` Rob Herring
2023-09-22 14:18 ` Rob Herring
2023-09-22 14:31 ` Andy Shevchenko
2023-09-22 14:31 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQn+IMMuPpwwZGPp@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=guohanjun@huawei.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lpieralisi@kernel.org \
--cc=peng.fan@nxp.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.