From: Frank Li <Frank.li@nxp.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: alexandre.belloni@bootlin.com, conor.culhane@silvaco.com,
joe@perches.com, linux-i3c@lists.infradead.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH 1/5] i3c: master: svc: enable hotjoin default
Date: Tue, 17 Oct 2023 10:51:25 -0400 [thread overview]
Message-ID: <ZS6fbVtbuBH32aRU@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20231017160457.4f0c2490@xps-13>
On Tue, Oct 17, 2023 at 04:04:57PM +0200, Miquel Raynal wrote:
> Hi Frank,
>
> Frank.Li@nxp.com wrote on Mon, 16 Oct 2023 11:46:28 -0400:
>
> > Hotjoin require clock running and enable SLVSTART irq.
> > Add module parameter 'hotjoin' to disable hotjoin and enable runtime_pm to
> > save power.
>
> I am really not a big fan of the use of modules parameters. Maybe it
> makes sense here. Alex, a better idea?
Maybe we can create sys entry to enable/disable hotjoin. I think i3c
should default support hotjoin, but it exist user case that needn't hj and
want more aggressive power saving.
If create /sys/ entry, it need change driver/i3c/master.c.
Frank
>
> Thanks,
> Miquèl
WARNING: multiple messages have this Message-ID (diff)
From: Frank Li <Frank.li@nxp.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: alexandre.belloni@bootlin.com, conor.culhane@silvaco.com,
joe@perches.com, linux-i3c@lists.infradead.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH 1/5] i3c: master: svc: enable hotjoin default
Date: Tue, 17 Oct 2023 10:51:25 -0400 [thread overview]
Message-ID: <ZS6fbVtbuBH32aRU@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20231017160457.4f0c2490@xps-13>
On Tue, Oct 17, 2023 at 04:04:57PM +0200, Miquel Raynal wrote:
> Hi Frank,
>
> Frank.Li@nxp.com wrote on Mon, 16 Oct 2023 11:46:28 -0400:
>
> > Hotjoin require clock running and enable SLVSTART irq.
> > Add module parameter 'hotjoin' to disable hotjoin and enable runtime_pm to
> > save power.
>
> I am really not a big fan of the use of modules parameters. Maybe it
> makes sense here. Alex, a better idea?
Maybe we can create sys entry to enable/disable hotjoin. I think i3c
should default support hotjoin, but it exist user case that needn't hj and
want more aggressive power saving.
If create /sys/ entry, it need change driver/i3c/master.c.
Frank
>
> Thanks,
> Miquèl
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2023-10-17 14:52 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 15:46 [PATCH 0/5] i3c: master: some improvment for i3c master Frank Li
2023-10-16 15:46 ` Frank Li
2023-10-16 15:46 ` [PATCH 1/5] i3c: master: svc: enable hotjoin default Frank Li
2023-10-16 15:46 ` Frank Li
2023-10-17 6:48 ` Joe Perches
2023-10-17 6:48 ` Joe Perches
2023-10-17 14:04 ` Miquel Raynal
2023-10-17 14:04 ` Miquel Raynal
2023-10-17 14:51 ` Frank Li [this message]
2023-10-17 14:51 ` Frank Li
2023-10-17 22:22 ` Alexandre Belloni
2023-10-17 22:22 ` Alexandre Belloni
2023-10-16 15:46 ` [PATCH 2/5] i3c: add actual in i3c_priv_xfer Frank Li
2023-10-16 15:46 ` Frank Li
2023-10-17 6:10 ` Jarkko Nikula
2023-10-17 6:10 ` Jarkko Nikula
2023-10-16 15:46 ` [PATCH 3/5] i3c: svc: rename read_len as actual_len Frank Li
2023-10-16 15:46 ` Frank Li
2023-10-17 14:07 ` Miquel Raynal
2023-10-17 14:07 ` Miquel Raynal
2023-10-17 20:43 ` Frank Li
2023-10-17 20:43 ` Frank Li
2023-10-16 15:46 ` [PATCH 4/5] i3c: master: svc return actual transfer data len Frank Li
2023-10-16 15:46 ` Frank Li
2023-10-17 8:33 ` Jarkko Nikula
2023-10-17 8:33 ` Jarkko Nikula
2023-10-18 20:18 ` Frank Li
2023-10-18 20:18 ` Frank Li
2023-10-17 14:10 ` Miquel Raynal
2023-10-17 14:10 ` Miquel Raynal
2023-10-18 20:26 ` Frank Li
2023-10-18 20:26 ` Frank Li
2023-10-16 15:46 ` [PATCH 5/5] i3c: add API i3c_dev_gettstatus_format1() to get target device status Frank Li
2023-10-16 15:46 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZS6fbVtbuBH32aRU@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor.culhane@silvaco.com \
--cc=imx@lists.linux.dev \
--cc=joe@perches.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.