From: Frank Li <Frank.li@nxp.com> To: Miquel Raynal <miquel.raynal@bootlin.com> Cc: conor.culhane@silvaco.com, alexandre.belloni@bootlin.com, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: Re: [PATCH 1/6] i3c: master: svc: fix race condition in ibi work thread Date: Tue, 17 Oct 2023 11:10:54 -0400 [thread overview] Message-ID: <ZS6j/tpqEppFADk1@lizhi-Precision-Tower-5810> (raw) In-Reply-To: <20231017164946.623abd0d@xps-13> On Tue, Oct 17, 2023 at 04:49:46PM +0200, Miquel Raynal wrote: > Hi Frank, > > Frank.li@nxp.com wrote on Tue, 17 Oct 2023 10:37:57 -0400: > > > On Tue, Oct 17, 2023 at 04:16:58PM +0200, Miquel Raynal wrote: > > > Hi Frank, > > > > > > Frank.Li@nxp.com wrote on Mon, 16 Oct 2023 11:32:27 -0400: > > > > > > > The ibi work thread operates asynchronously with other transfers, such as > > > > svc_i3c_master_priv_xfers(). Introduces mutex protection to ensure the > > > > > > Introduce > > > > > > > completion of the entire i3c/i2c transaction. > > > > > > Did you experience faulty conditions or was it reported thanks to > > > static analysis? > > > > Yes, I met. But it needs my slave part patches, which will be ready sent > > out review soon. > > I believe several of the "fixes" in this series are related to newer > uses (typically your i3c slave support) which were not in the scope of > the original submission. As these new features are not supposed to be > backported in stable kernels and because these are new corner cases,you > may drop the CC:/Fixes tags to avoid useless backports. I don't think so. The issue exists. Just difficult to find it. If there are i3c device that use IBI frequently. The problem should be trigger. My case just make it easy to trigger the problem. In previous existed code, IBI is supported. I think it is typical case, which need CC/Fixes. Frank > > Some of them however are real fixes for situations we may happen with > the current level of support, please keep the tags in these, and move > them all to the beginning of your series. > > Thanks, > Miquèl
WARNING: multiple messages have this Message-ID (diff)
From: Frank Li <Frank.li@nxp.com> To: Miquel Raynal <miquel.raynal@bootlin.com> Cc: conor.culhane@silvaco.com, alexandre.belloni@bootlin.com, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: Re: [PATCH 1/6] i3c: master: svc: fix race condition in ibi work thread Date: Tue, 17 Oct 2023 11:10:54 -0400 [thread overview] Message-ID: <ZS6j/tpqEppFADk1@lizhi-Precision-Tower-5810> (raw) In-Reply-To: <20231017164946.623abd0d@xps-13> On Tue, Oct 17, 2023 at 04:49:46PM +0200, Miquel Raynal wrote: > Hi Frank, > > Frank.li@nxp.com wrote on Tue, 17 Oct 2023 10:37:57 -0400: > > > On Tue, Oct 17, 2023 at 04:16:58PM +0200, Miquel Raynal wrote: > > > Hi Frank, > > > > > > Frank.Li@nxp.com wrote on Mon, 16 Oct 2023 11:32:27 -0400: > > > > > > > The ibi work thread operates asynchronously with other transfers, such as > > > > svc_i3c_master_priv_xfers(). Introduces mutex protection to ensure the > > > > > > Introduce > > > > > > > completion of the entire i3c/i2c transaction. > > > > > > Did you experience faulty conditions or was it reported thanks to > > > static analysis? > > > > Yes, I met. But it needs my slave part patches, which will be ready sent > > out review soon. > > I believe several of the "fixes" in this series are related to newer > uses (typically your i3c slave support) which were not in the scope of > the original submission. As these new features are not supposed to be > backported in stable kernels and because these are new corner cases,you > may drop the CC:/Fixes tags to avoid useless backports. I don't think so. The issue exists. Just difficult to find it. If there are i3c device that use IBI frequently. The problem should be trigger. My case just make it easy to trigger the problem. In previous existed code, IBI is supported. I think it is typical case, which need CC/Fixes. Frank > > Some of them however are real fixes for situations we may happen with > the current level of support, please keep the tags in these, and move > them all to the beginning of your series. > > Thanks, > Miquèl -- linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2023-10-17 15:11 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-10-16 15:32 [PATCH 0/6] i3c: master: svc: collection of bugs fixes Frank Li 2023-10-16 15:32 ` Frank Li 2023-10-16 15:32 ` [PATCH 1/6] i3c: master: svc: fix race condition in ibi work thread Frank Li 2023-10-16 15:32 ` Frank Li 2023-10-17 13:33 ` kernel test robot 2023-10-17 13:33 ` kernel test robot 2023-10-17 14:16 ` Miquel Raynal 2023-10-17 14:16 ` Miquel Raynal 2023-10-17 14:37 ` Frank Li 2023-10-17 14:37 ` Frank Li 2023-10-17 14:49 ` Miquel Raynal 2023-10-17 14:49 ` Miquel Raynal 2023-10-17 15:10 ` Frank Li [this message] 2023-10-17 15:10 ` Frank Li 2023-10-17 15:23 ` Miquel Raynal 2023-10-17 15:23 ` Miquel Raynal 2023-10-16 15:32 ` [PATCH 2/6] i3c: master: svc: fix wrong data return when IBI happen during start frame Frank Li 2023-10-16 15:32 ` Frank Li 2023-10-17 14:21 ` Miquel Raynal 2023-10-17 14:21 ` Miquel Raynal 2023-10-16 15:32 ` [PATCH 3/6] i3c: master: svc: fix ibi may not return mandatory data byte Frank Li 2023-10-16 15:32 ` Frank Li 2023-10-17 14:27 ` Miquel Raynal 2023-10-17 14:27 ` Miquel Raynal 2023-10-17 20:55 ` Frank Li 2023-10-17 20:55 ` Frank Li 2023-10-16 15:32 ` [PATCH 4/6] i3c: master: svc: fix check wrong status register in irq handler Frank Li 2023-10-16 15:32 ` Frank Li 2023-10-17 14:28 ` Miquel Raynal 2023-10-17 14:28 ` Miquel Raynal 2023-10-16 15:32 ` [PATCH 5/6] i3c: master: svc: fix SDA keep low when polling IBIWON timeout happen Frank Li 2023-10-16 15:32 ` Frank Li 2023-10-17 14:29 ` Miquel Raynal 2023-10-17 14:29 ` Miquel Raynal 2023-10-16 15:32 ` [PATCH 6/6] i3c: master: svc: fix random hot join failure since timeout error Frank Li 2023-10-16 15:32 ` Frank Li 2023-10-17 14:33 ` Miquel Raynal 2023-10-17 14:33 ` Miquel Raynal 2023-10-17 14:45 ` Frank Li 2023-10-17 14:45 ` Frank Li 2023-10-17 15:06 ` Miquel Raynal 2023-10-17 15:06 ` Miquel Raynal 2023-10-17 15:25 ` Frank Li 2023-10-17 15:25 ` Frank Li
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZS6j/tpqEppFADk1@lizhi-Precision-Tower-5810 \ --to=frank.li@nxp.com \ --cc=alexandre.belloni@bootlin.com \ --cc=conor.culhane@silvaco.com \ --cc=imx@lists.linux.dev \ --cc=joe@perches.com \ --cc=linux-i3c@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=miquel.raynal@bootlin.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.