From: Sean Young <sean@mess.org>
To: Stefan Wahren <wahrenst@gmx.net>
Cc: linux-media@vger.kernel.org, linux-pwm@vger.kernel.org,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] pwm: bcm2835: allow pwm driver to be used in atomic context
Date: Thu, 19 Oct 2023 12:19:15 +0100 [thread overview]
Message-ID: <ZTEQszOAEybWPrCO@gofer.mess.org> (raw)
In-Reply-To: <53534015-07ab-4d43-8dcb-be3a08ee6339@gmx.net>
On Wed, Oct 18, 2023 at 05:00:23PM +0200, Stefan Wahren wrote:
> Hi Sean,
>
> Am 17.10.23 um 11:17 schrieb Sean Young:
> > clk_get_rate() may do a mutex lock. Since the clock rate cannot change on
> > an rpi, simply fetch it once.
> the driver changes looks good to me, but could you please adapt the
> commit message to your recent changes.
Yes, the commit message needs fixing. Thanks for pointing that out.
Sean
WARNING: multiple messages have this Message-ID (diff)
From: Sean Young <sean@mess.org>
To: Stefan Wahren <wahrenst@gmx.net>
Cc: linux-media@vger.kernel.org, linux-pwm@vger.kernel.org,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] pwm: bcm2835: allow pwm driver to be used in atomic context
Date: Thu, 19 Oct 2023 12:19:15 +0100 [thread overview]
Message-ID: <ZTEQszOAEybWPrCO@gofer.mess.org> (raw)
In-Reply-To: <53534015-07ab-4d43-8dcb-be3a08ee6339@gmx.net>
On Wed, Oct 18, 2023 at 05:00:23PM +0200, Stefan Wahren wrote:
> Hi Sean,
>
> Am 17.10.23 um 11:17 schrieb Sean Young:
> > clk_get_rate() may do a mutex lock. Since the clock rate cannot change on
> > an rpi, simply fetch it once.
> the driver changes looks good to me, but could you please adapt the
> commit message to your recent changes.
Yes, the commit message needs fixing. Thanks for pointing that out.
Sean
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-19 11:19 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 9:17 [PATCH v3 0/3] Improve pwm-ir-tx precision Sean Young
2023-10-17 9:17 ` [PATCH v3 1/3] pwm: make it possible to apply pwm changes in atomic context Sean Young
2023-10-17 9:17 ` [Intel-gfx] " Sean Young
2023-10-17 9:17 ` Sean Young
2023-10-17 9:17 ` Sean Young
2023-10-18 13:57 ` Hans de Goede
2023-10-18 13:57 ` Hans de Goede
2023-10-18 13:57 ` [Intel-gfx] " Hans de Goede
2023-10-18 13:57 ` Hans de Goede
2023-10-19 10:51 ` Uwe Kleine-König
2023-10-19 10:51 ` Uwe Kleine-König
2023-10-19 10:51 ` [Intel-gfx] " Uwe Kleine-König
2023-10-19 10:51 ` Uwe Kleine-König
2023-10-21 9:08 ` Hans de Goede
2023-10-21 9:08 ` [Intel-gfx] " Hans de Goede
2023-10-21 9:08 ` Hans de Goede
2023-10-21 9:08 ` Hans de Goede
2023-10-22 10:46 ` Sean Young
2023-10-22 10:46 ` [Intel-gfx] " Sean Young
2023-10-22 10:46 ` Sean Young
2023-10-22 10:46 ` Sean Young
2023-10-23 13:17 ` Hans de Goede
2023-10-23 13:17 ` [Intel-gfx] " Hans de Goede
2023-10-23 13:17 ` Hans de Goede
2023-10-23 13:17 ` Hans de Goede
2023-10-23 13:34 ` Daniel Thompson
2023-10-23 13:34 ` Daniel Thompson
2023-10-23 13:34 ` [Intel-gfx] " Daniel Thompson
2023-10-23 13:34 ` Daniel Thompson
2023-10-25 9:53 ` Sean Young
2023-10-25 9:53 ` [Intel-gfx] " Sean Young
2023-10-25 9:53 ` Sean Young
2023-10-25 9:53 ` Sean Young
2023-10-25 10:47 ` Uwe Kleine-König
2023-10-25 10:47 ` [Intel-gfx] " Uwe Kleine-König
2023-10-25 10:47 ` Uwe Kleine-König
2023-10-25 10:47 ` Uwe Kleine-König
2023-10-21 23:55 ` kernel test robot
2023-10-23 10:47 ` Jani Nikula
2023-10-23 10:47 ` Jani Nikula
2023-10-23 10:47 ` [Intel-gfx] " Jani Nikula
2023-10-23 10:47 ` Jani Nikula
2023-10-17 9:17 ` [PATCH v3 2/3] pwm: bcm2835: allow pwm driver to be used " Sean Young
2023-10-17 9:17 ` Sean Young
2023-10-18 15:00 ` Stefan Wahren
2023-10-18 15:00 ` Stefan Wahren
2023-10-19 11:19 ` Sean Young [this message]
2023-10-19 11:19 ` Sean Young
2023-10-17 9:17 ` [PATCH v3 3/3] media: pwm-ir-tx: trigger edges from hrtimer interrupt context Sean Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTEQszOAEybWPrCO@gofer.mess.org \
--to=sean@mess.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=florian.fainelli@broadcom.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.