From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Alain Volmat <alain.volmat@foss.st.com>
Cc: Hugues Fruchet <hugues.fruchet@foss.st.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Russell King <linux@armlinux.org.uk>,
Philipp Zabel <p.zabel@pengutronix.de>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Dan Scally <dan.scally@ideasonboard.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 3/5] media: stm32-dcmipp: STM32 DCMIPP camera interface driver
Date: Mon, 27 Nov 2023 10:32:28 +0000 [thread overview]
Message-ID: <ZWRwPJQA_wNEVD8Y@kekkonen.localdomain> (raw)
In-Reply-To: <20231122073927.788810-4-alain.volmat@foss.st.com>
Hi Alain,
On Wed, Nov 22, 2023 at 08:39:17AM +0100, Alain Volmat wrote:
> From: Hugues Fruchet <hugues.fruchet@foss.st.com>
>
> This V4L2 subdev driver enables Digital Camera Memory Interface
> Pixel Processor(DCMIPP) of STMicroelectronics STM32 SoC series.
>
> Signed-off-by: Hugues Fruchet <hugues.fruchet@foss.st.com>
> Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
One more thing. I think you're missing all the link_validate ops, meaning
it's possible to start the hardware with invalid configuration.
Could you add them? It can be a separate patch. I'll postpone these until
that.
--
Regards,
Sakari Ailus
WARNING: multiple messages have this Message-ID (diff)
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Alain Volmat <alain.volmat@foss.st.com>
Cc: Hugues Fruchet <hugues.fruchet@foss.st.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Russell King <linux@armlinux.org.uk>,
Philipp Zabel <p.zabel@pengutronix.de>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Dan Scally <dan.scally@ideasonboard.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 3/5] media: stm32-dcmipp: STM32 DCMIPP camera interface driver
Date: Mon, 27 Nov 2023 10:32:28 +0000 [thread overview]
Message-ID: <ZWRwPJQA_wNEVD8Y@kekkonen.localdomain> (raw)
In-Reply-To: <20231122073927.788810-4-alain.volmat@foss.st.com>
Hi Alain,
On Wed, Nov 22, 2023 at 08:39:17AM +0100, Alain Volmat wrote:
> From: Hugues Fruchet <hugues.fruchet@foss.st.com>
>
> This V4L2 subdev driver enables Digital Camera Memory Interface
> Pixel Processor(DCMIPP) of STMicroelectronics STM32 SoC series.
>
> Signed-off-by: Hugues Fruchet <hugues.fruchet@foss.st.com>
> Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
One more thing. I think you're missing all the link_validate ops, meaning
it's possible to start the hardware with invalid configuration.
Could you add them? It can be a separate patch. I'll postpone these until
that.
--
Regards,
Sakari Ailus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-11-27 10:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 7:39 [PATCH v8 0/5] Add support for DCMIPP camera interface of STMicroelectronics STM32 SoC series Alain Volmat
2023-11-22 7:39 ` Alain Volmat
2023-11-22 7:39 ` [PATCH v8 1/5] dt-bindings: media: add bindings for stm32 dcmipp Alain Volmat
2023-11-22 7:39 ` Alain Volmat
2023-11-22 7:39 ` [PATCH v8 2/5] media: MAINTAINERS: add entry for STM32 DCMIPP driver Alain Volmat
2023-11-22 7:39 ` Alain Volmat
2023-11-22 7:39 ` [PATCH v8 3/5] media: stm32-dcmipp: STM32 DCMIPP camera interface driver Alain Volmat
2023-11-22 7:39 ` Alain Volmat
2023-11-23 1:54 ` kernel test robot
2023-11-23 1:54 ` kernel test robot
2023-11-23 3:16 ` kernel test robot
2023-11-23 3:16 ` kernel test robot
2023-11-27 10:32 ` Sakari Ailus [this message]
2023-11-27 10:32 ` Sakari Ailus
2023-11-27 11:38 ` Philipp Zabel
2023-11-27 11:38 ` Philipp Zabel
2023-11-27 13:55 ` Alain Volmat
2023-11-27 13:55 ` Alain Volmat
2023-11-22 7:39 ` [PATCH v8 4/5] ARM: dts: stm32: add dcmipp support to stm32mp135 Alain Volmat
2023-11-22 7:39 ` Alain Volmat
2023-11-22 7:39 ` [PATCH v8 5/5] ARM: multi_v7_defconfig: enable STM32 DCMIPP media support Alain Volmat
2023-11-22 7:39 ` Alain Volmat
2023-11-27 10:33 ` [PATCH v8 0/5] Add support for DCMIPP camera interface of STMicroelectronics STM32 SoC series Sakari Ailus
2023-11-27 10:33 ` Sakari Ailus
2023-11-27 11:14 ` Alain Volmat
2023-11-27 11:14 ` Alain Volmat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWRwPJQA_wNEVD8Y@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=alain.volmat@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=dan.scally@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=hugues.fruchet@foss.st.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=mchehab@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.