From: Frank Li <Frank.li@nxp.com> To: Miquel Raynal <miquel.raynal@bootlin.com> Cc: alexandre.belloni@bootlin.com, conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, zbigniew.lukwinski@linux.intel.com Subject: Re: [PATCH v4 6/6] i3c: add API i3c_dev_gettstatus_format1() to get target device status Date: Thu, 30 Nov 2023 12:49:36 -0500 [thread overview] Message-ID: <ZWjLMNKJElPI6uSo@lizhi-Precision-Tower-5810> (raw) In-Reply-To: <20231130111959.11afd8a8@xps-13> On Thu, Nov 30, 2023 at 11:19:59AM +0100, Miquel Raynal wrote: > Hi Frank, > > Frank.Li@nxp.com wrote on Wed, 29 Nov 2023 17:12:25 -0500: > > > I3C standard 5.1.9.3.15 Get Device Status (GETSTATUS): > > Get request for one I3C Target Device to return its current status. > > > > Add API to fetch it with format1. > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > drivers/i3c/device.c | 24 ++++++++++++++++++++++++ > > drivers/i3c/internals.h | 1 + > > drivers/i3c/master.c | 26 ++++++++++++++++++++++++++ > > include/linux/i3c/device.h | 1 + > > 4 files changed, 52 insertions(+) > > > > diff --git a/drivers/i3c/device.c b/drivers/i3c/device.c > > index 1a6a8703dbc3a..aa26cf50ab9c6 100644 > > --- a/drivers/i3c/device.c > > +++ b/drivers/i3c/device.c > > @@ -196,6 +196,30 @@ void i3c_device_free_ibi(struct i3c_device *dev) > > } > > EXPORT_SYMBOL_GPL(i3c_device_free_ibi); > > > > +/** > > + * i3c_device_getstatus_format1() - Get device status with format 1. > > + * @dev: device for which you want to get status. > > + * @status: I3C status format 1 > > + * > > + * Return: 0 in case of success, a negative error core otherwise. > > + */ > > +int i3c_device_getstatus_format1(struct i3c_device *dev, u16 *status) > > I'm not a big fan of the opposition between "i3c_device" and "i3c_dev". > Could we clarify the prefixes? look likes: Internal API between device/master/ use i3c_dev External API for I3C target device use i3c_device > > > +{ > > + int ret = -EINVAL; > > Init not useful > > > + > > + if (!status) > > + return -EINVAL; > > + > > + i3c_bus_normaluse_lock(dev->bus); > > + if (dev->desc) > > + ret = i3c_dev_getstatus_format1_locked(dev->desc, status); > > + > > + i3c_bus_normaluse_unlock(dev->bus); > > + > > + return ret; > > +} > > +EXPORT_SYMBOL_GPL(i3c_device_getstatus_format1); > > There is no user yet. Maybe this needs to be done in another series? > Same below. See https://lore.kernel.org/imx/202311070330.5mylauLR-lkp@intel.com/T/#t > > ... > > > +int i3c_dev_getstatus_format1_locked(struct i3c_dev_desc *dev, u16 *status) > > ... > > Thanks, > Miquèl
WARNING: multiple messages have this Message-ID (diff)
From: Frank Li <Frank.li@nxp.com> To: Miquel Raynal <miquel.raynal@bootlin.com> Cc: alexandre.belloni@bootlin.com, conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, zbigniew.lukwinski@linux.intel.com Subject: Re: [PATCH v4 6/6] i3c: add API i3c_dev_gettstatus_format1() to get target device status Date: Thu, 30 Nov 2023 12:49:36 -0500 [thread overview] Message-ID: <ZWjLMNKJElPI6uSo@lizhi-Precision-Tower-5810> (raw) In-Reply-To: <20231130111959.11afd8a8@xps-13> On Thu, Nov 30, 2023 at 11:19:59AM +0100, Miquel Raynal wrote: > Hi Frank, > > Frank.Li@nxp.com wrote on Wed, 29 Nov 2023 17:12:25 -0500: > > > I3C standard 5.1.9.3.15 Get Device Status (GETSTATUS): > > Get request for one I3C Target Device to return its current status. > > > > Add API to fetch it with format1. > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > drivers/i3c/device.c | 24 ++++++++++++++++++++++++ > > drivers/i3c/internals.h | 1 + > > drivers/i3c/master.c | 26 ++++++++++++++++++++++++++ > > include/linux/i3c/device.h | 1 + > > 4 files changed, 52 insertions(+) > > > > diff --git a/drivers/i3c/device.c b/drivers/i3c/device.c > > index 1a6a8703dbc3a..aa26cf50ab9c6 100644 > > --- a/drivers/i3c/device.c > > +++ b/drivers/i3c/device.c > > @@ -196,6 +196,30 @@ void i3c_device_free_ibi(struct i3c_device *dev) > > } > > EXPORT_SYMBOL_GPL(i3c_device_free_ibi); > > > > +/** > > + * i3c_device_getstatus_format1() - Get device status with format 1. > > + * @dev: device for which you want to get status. > > + * @status: I3C status format 1 > > + * > > + * Return: 0 in case of success, a negative error core otherwise. > > + */ > > +int i3c_device_getstatus_format1(struct i3c_device *dev, u16 *status) > > I'm not a big fan of the opposition between "i3c_device" and "i3c_dev". > Could we clarify the prefixes? look likes: Internal API between device/master/ use i3c_dev External API for I3C target device use i3c_device > > > +{ > > + int ret = -EINVAL; > > Init not useful > > > + > > + if (!status) > > + return -EINVAL; > > + > > + i3c_bus_normaluse_lock(dev->bus); > > + if (dev->desc) > > + ret = i3c_dev_getstatus_format1_locked(dev->desc, status); > > + > > + i3c_bus_normaluse_unlock(dev->bus); > > + > > + return ret; > > +} > > +EXPORT_SYMBOL_GPL(i3c_device_getstatus_format1); > > There is no user yet. Maybe this needs to be done in another series? > Same below. See https://lore.kernel.org/imx/202311070330.5mylauLR-lkp@intel.com/T/#t > > ... > > > +int i3c_dev_getstatus_format1_locked(struct i3c_dev_desc *dev, u16 *status) > > ... > > Thanks, > Miquèl -- linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2023-11-30 17:49 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-29 22:12 [PATCH v4 0/6] i3c: master: some improvment for i3c master Frank Li 2023-11-29 22:12 ` Frank Li 2023-11-29 22:12 ` [PATCH v4 1/6] i3c: master: add enable(disable) hot join in sys entry Frank Li 2023-11-29 22:12 ` Frank Li 2023-11-30 10:13 ` Miquel Raynal 2023-11-30 10:13 ` Miquel Raynal 2023-11-29 22:12 ` [PATCH v4 2/6] i3c: master: svc: add hot join support Frank Li 2023-11-29 22:12 ` Frank Li 2023-11-30 10:16 ` Miquel Raynal 2023-11-30 10:16 ` Miquel Raynal 2023-11-29 22:12 ` [PATCH v4 3/6] i3c: add actual_len in i3c_priv_xfer Frank Li 2023-11-29 22:12 ` Frank Li 2023-11-30 10:17 ` Miquel Raynal 2023-11-30 10:17 ` Miquel Raynal 2023-11-29 22:12 ` [PATCH v4 4/6] i3c: svc: rename read_len as actual_len Frank Li 2023-11-29 22:12 ` Frank Li 2023-11-29 22:12 ` [PATCH v4 5/6] i3c: master: svc return actual transfer data len Frank Li 2023-11-29 22:12 ` Frank Li 2023-11-30 10:09 ` Miquel Raynal 2023-11-30 10:09 ` Miquel Raynal 2023-11-29 22:12 ` [PATCH v4 6/6] i3c: add API i3c_dev_gettstatus_format1() to get target device status Frank Li 2023-11-29 22:12 ` Frank Li 2023-11-30 10:19 ` Miquel Raynal 2023-11-30 10:19 ` Miquel Raynal 2023-11-30 17:49 ` Frank Li [this message] 2023-11-30 17:49 ` Frank Li 2023-11-30 19:16 ` Miquel Raynal 2023-11-30 19:16 ` Miquel Raynal 2023-11-30 22:00 ` [PATCH v4 6/6] i3c: add API i3c_dev_gettstatus_format1() to get target device statusy Frank Li 2023-11-30 22:00 ` Frank Li
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZWjLMNKJElPI6uSo@lizhi-Precision-Tower-5810 \ --to=frank.li@nxp.com \ --cc=alexandre.belloni@bootlin.com \ --cc=conor.culhane@silvaco.com \ --cc=imx@lists.linux.dev \ --cc=joe@perches.com \ --cc=linux-i3c@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=miquel.raynal@bootlin.com \ --cc=zbigniew.lukwinski@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.