Re: [PATCH 0/4] drm/i915/dmc: DMC event stuff

From: Imre Deak <imre.deak@intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 0/4] drm/i915/dmc: DMC event stuff
Date: Wed, 13 Dec 2023 09:44:28 +0200	[thread overview]
Message-ID: <ZXlg3JJIXvFMjsIj@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <20231211213750.27109-1-ville.syrjala@linux.intel.com>

On Mon, Dec 11, 2023 at 11:37:46PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Fix the weird flip_done/etc. issues plaguing ADL+ by disabling all dodgy
> DMC events that we definitely don't need. Also improve the debugs to
> make it easier to see what we're doing.

This (at least a rather similar issue) was debugged already on DG2
thanks for going through that and fixing the rest. Since both Windows
and Linux disables now these events, it should be in bspec as well (or
better imo, to release the firmware binaries without these events being
enabled in the first place):
Reviewed-by: Imre Deak <imre.deak@intel.com>

> 
> Ville Syrjälä (4):
>   drm/i915/dmc: Don't enable any pipe DMC events
>   drm/i915/dmc: Also disable the flip queue event on TGL main DMC
>   drm/i915/dmc: Also disable HRR event on TGL main DMC
>   drm/i915/dmc: Print out the DMC mmio register list at fw load time
> 
>  drivers/gpu/drm/i915/display/intel_dmc.c      | 147 ++++++++----------
>  drivers/gpu/drm/i915/display/intel_dmc_regs.h |   1 +
>  2 files changed, 69 insertions(+), 79 deletions(-)
> 
> -- 
> 2.41.0
> 