From: Vinod Koul <vkoul@kernel.org>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Johan Jonker <jbx6244@gmail.com>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Andy Yan <andy.yan@rock-chips.com>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Algea Cao <algea.cao@rock-chips.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-phy@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH v2 2/2] phy: rockchip: Add Samsung HDMI/eDP Combo PHY driver
Date: Wed, 7 Feb 2024 15:06:37 +0100 [thread overview]
Message-ID: <ZcOObdUvxmRzdHnE@matsya> (raw)
In-Reply-To: <374f5069-9f3d-4ad2-a6da-b38a143a0c99@collabora.com>
On 07-02-24, 14:39, Cristian Ciocaltea wrote:
> On 2/7/24 12:16, Vinod Koul wrote:
> > On 05-02-24, 13:24, Cristian Ciocaltea wrote:
> >> +static u8 hdptx_grf_read(struct rockchip_hdptx_phy *hdptx, u32 reg)
> >> +{
> >> + u32 val;
> >> +
> >> + regmap_read(hdptx->grf, reg, &val);
> >> +
> >> + return val;
> >> +}
> >
> > why use wrappers, why not call regmap_ apis directly
>
> Agree, no real benefit, will drop them, except probably
> hdptx_multi_reg_write() for the extra savings.
That one is fine as there is good logic on the helper
> So I'd keep using that one if there's no strong reason against.
ok
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Johan Jonker <jbx6244@gmail.com>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Andy Yan <andy.yan@rock-chips.com>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Algea Cao <algea.cao@rock-chips.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-phy@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH v2 2/2] phy: rockchip: Add Samsung HDMI/eDP Combo PHY driver
Date: Wed, 7 Feb 2024 15:06:37 +0100 [thread overview]
Message-ID: <ZcOObdUvxmRzdHnE@matsya> (raw)
In-Reply-To: <374f5069-9f3d-4ad2-a6da-b38a143a0c99@collabora.com>
On 07-02-24, 14:39, Cristian Ciocaltea wrote:
> On 2/7/24 12:16, Vinod Koul wrote:
> > On 05-02-24, 13:24, Cristian Ciocaltea wrote:
> >> +static u8 hdptx_grf_read(struct rockchip_hdptx_phy *hdptx, u32 reg)
> >> +{
> >> + u32 val;
> >> +
> >> + regmap_read(hdptx->grf, reg, &val);
> >> +
> >> + return val;
> >> +}
> >
> > why use wrappers, why not call regmap_ apis directly
>
> Agree, no real benefit, will drop them, except probably
> hdptx_multi_reg_write() for the extra savings.
That one is fine as there is good logic on the helper
> So I'd keep using that one if there's no strong reason against.
ok
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Johan Jonker <jbx6244@gmail.com>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Andy Yan <andy.yan@rock-chips.com>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Algea Cao <algea.cao@rock-chips.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-phy@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH v2 2/2] phy: rockchip: Add Samsung HDMI/eDP Combo PHY driver
Date: Wed, 7 Feb 2024 15:06:37 +0100 [thread overview]
Message-ID: <ZcOObdUvxmRzdHnE@matsya> (raw)
In-Reply-To: <374f5069-9f3d-4ad2-a6da-b38a143a0c99@collabora.com>
On 07-02-24, 14:39, Cristian Ciocaltea wrote:
> On 2/7/24 12:16, Vinod Koul wrote:
> > On 05-02-24, 13:24, Cristian Ciocaltea wrote:
> >> +static u8 hdptx_grf_read(struct rockchip_hdptx_phy *hdptx, u32 reg)
> >> +{
> >> + u32 val;
> >> +
> >> + regmap_read(hdptx->grf, reg, &val);
> >> +
> >> + return val;
> >> +}
> >
> > why use wrappers, why not call regmap_ apis directly
>
> Agree, no real benefit, will drop them, except probably
> hdptx_multi_reg_write() for the extra savings.
That one is fine as there is good logic on the helper
> So I'd keep using that one if there's no strong reason against.
ok
--
~Vinod
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Johan Jonker <jbx6244@gmail.com>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Andy Yan <andy.yan@rock-chips.com>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Algea Cao <algea.cao@rock-chips.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-phy@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH v2 2/2] phy: rockchip: Add Samsung HDMI/eDP Combo PHY driver
Date: Wed, 7 Feb 2024 15:06:37 +0100 [thread overview]
Message-ID: <ZcOObdUvxmRzdHnE@matsya> (raw)
In-Reply-To: <374f5069-9f3d-4ad2-a6da-b38a143a0c99@collabora.com>
On 07-02-24, 14:39, Cristian Ciocaltea wrote:
> On 2/7/24 12:16, Vinod Koul wrote:
> > On 05-02-24, 13:24, Cristian Ciocaltea wrote:
> >> +static u8 hdptx_grf_read(struct rockchip_hdptx_phy *hdptx, u32 reg)
> >> +{
> >> + u32 val;
> >> +
> >> + regmap_read(hdptx->grf, reg, &val);
> >> +
> >> + return val;
> >> +}
> >
> > why use wrappers, why not call regmap_ apis directly
>
> Agree, no real benefit, will drop them, except probably
> hdptx_multi_reg_write() for the extra savings.
That one is fine as there is good logic on the helper
> So I'd keep using that one if there's no strong reason against.
ok
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-07 14:06 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 11:24 [PATCH v2 0/2] Add support for RK3588 HDMI/eDP Combo PHY Cristian Ciocaltea
2024-02-05 11:24 ` Cristian Ciocaltea
2024-02-05 11:24 ` Cristian Ciocaltea
2024-02-05 11:24 ` Cristian Ciocaltea
2024-02-05 11:24 ` [PATCH v2 1/2] dt-bindings: phy: Add Rockchip HDMI/eDP Combo PHY schema Cristian Ciocaltea
2024-02-05 11:24 ` Cristian Ciocaltea
2024-02-05 11:24 ` Cristian Ciocaltea
2024-02-05 11:24 ` Cristian Ciocaltea
2024-02-06 10:21 ` Heiko Stübner
2024-02-06 10:21 ` Heiko Stübner
2024-02-06 10:21 ` Heiko Stübner
2024-02-06 10:21 ` Heiko Stübner
2024-02-05 11:24 ` [PATCH v2 2/2] phy: rockchip: Add Samsung HDMI/eDP Combo PHY driver Cristian Ciocaltea
2024-02-05 11:24 ` Cristian Ciocaltea
2024-02-05 11:24 ` Cristian Ciocaltea
2024-02-05 11:24 ` Cristian Ciocaltea
2024-02-07 10:16 ` Vinod Koul
2024-02-07 10:16 ` Vinod Koul
2024-02-07 10:16 ` Vinod Koul
2024-02-07 10:16 ` Vinod Koul
2024-02-07 12:39 ` Cristian Ciocaltea
2024-02-07 12:39 ` Cristian Ciocaltea
2024-02-07 12:39 ` Cristian Ciocaltea
2024-02-07 12:39 ` Cristian Ciocaltea
2024-02-07 14:06 ` Vinod Koul [this message]
2024-02-07 14:06 ` Vinod Koul
2024-02-07 14:06 ` Vinod Koul
2024-02-07 14:06 ` Vinod Koul
2024-02-08 8:00 ` Heiko Stübner
2024-02-08 8:00 ` Heiko Stübner
2024-02-08 8:00 ` Heiko Stübner
2024-02-08 8:00 ` Heiko Stübner
2024-02-08 11:56 ` Cristian Ciocaltea
2024-02-08 11:56 ` Cristian Ciocaltea
2024-02-08 11:56 ` Cristian Ciocaltea
2024-02-08 11:56 ` Cristian Ciocaltea
2024-02-12 16:44 ` Luis de Arquer
2024-02-12 16:44 ` Luis de Arquer
2024-02-12 16:44 ` Luis de Arquer
2024-02-12 16:44 ` Luis de Arquer
2024-02-12 18:36 ` Cristian Ciocaltea
2024-02-12 18:36 ` Cristian Ciocaltea
2024-02-12 18:36 ` Cristian Ciocaltea
2024-02-12 18:36 ` Cristian Ciocaltea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcOObdUvxmRzdHnE@matsya \
--to=vkoul@kernel.org \
--cc=algea.cao@rock-chips.com \
--cc=andy.yan@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=cristian.ciocaltea@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=kernel@collabora.com \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.