From: Mark Brown <broonie@kernel.org> To: Will Deacon <will@kernel.org> Cc: Doug Anderson <dianders@chromium.org>, Catalin Marinas <catalin.marinas@arm.com>, Dave Martin <Dave.Martin@arm.com>, Oleg Nesterov <oleg@redhat.com>, Al Viro <viro@zeniv.linux.org.uk>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64/sve: Lower the maximum allocation for the SVE ptrace regset Date: Fri, 9 Feb 2024 17:40:06 +0000 [thread overview] Message-ID: <ZcZjdnchVblj4iP+@finisterre.sirena.org.uk> (raw) In-Reply-To: <20240209171155.GB25069@willie-the-truck> [-- Attachment #1: Type: text/plain, Size: 889 bytes --] On Fri, Feb 09, 2024 at 05:11:55PM +0000, Will Deacon wrote: > I can pick this up as a short-term hack if it solves the problem for you, > but I also saw that you posted: > https://lore.kernel.org/r/20240205092626.v2.1.Id9ad163b60d21c9e56c2d686b0cc9083a8ba7924@changeid > to fallback onto vmalloc() for large allocations. > What's your preference for a fix? We need the change kvzalloc() regardless since the ZA regset is just over 64K which is on the big side, I do think that reducing the reported regset size is useful as a fix independently since even with kvzalloc() it's still pointless and rude to ask for such a big allocation and we might reasonably be generating core files or dumping crashing processes under memory pressure. Dave was looking at sizing the regsets dynamically but there's enough going on there that it's not great if people want to pick it up for stable. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org> To: Will Deacon <will@kernel.org> Cc: Doug Anderson <dianders@chromium.org>, Catalin Marinas <catalin.marinas@arm.com>, Dave Martin <Dave.Martin@arm.com>, Oleg Nesterov <oleg@redhat.com>, Al Viro <viro@zeniv.linux.org.uk>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64/sve: Lower the maximum allocation for the SVE ptrace regset Date: Fri, 9 Feb 2024 17:40:06 +0000 [thread overview] Message-ID: <ZcZjdnchVblj4iP+@finisterre.sirena.org.uk> (raw) In-Reply-To: <20240209171155.GB25069@willie-the-truck> [-- Attachment #1.1: Type: text/plain, Size: 889 bytes --] On Fri, Feb 09, 2024 at 05:11:55PM +0000, Will Deacon wrote: > I can pick this up as a short-term hack if it solves the problem for you, > but I also saw that you posted: > https://lore.kernel.org/r/20240205092626.v2.1.Id9ad163b60d21c9e56c2d686b0cc9083a8ba7924@changeid > to fallback onto vmalloc() for large allocations. > What's your preference for a fix? We need the change kvzalloc() regardless since the ZA regset is just over 64K which is on the big side, I do think that reducing the reported regset size is useful as a fix independently since even with kvzalloc() it's still pointless and rude to ask for such a big allocation and we might reasonably be generating core files or dumping crashing processes under memory pressure. Dave was looking at sizing the regsets dynamically but there's enough going on there that it's not great if people want to pick it up for stable. [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-09 17:40 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-03 12:16 [PATCH] arm64/sve: Lower the maximum allocation for the SVE ptrace regset Mark Brown 2024-02-03 12:16 ` Mark Brown 2024-02-05 17:02 ` Doug Anderson 2024-02-05 17:02 ` Doug Anderson 2024-02-09 17:11 ` Will Deacon 2024-02-09 17:11 ` Will Deacon 2024-02-09 17:40 ` Mark Brown [this message] 2024-02-09 17:40 ` Mark Brown 2024-02-05 17:11 ` Dave Martin 2024-02-05 17:11 ` Dave Martin 2024-02-05 17:41 ` Mark Brown 2024-02-05 17:41 ` Mark Brown 2024-02-07 12:23 ` Dave Martin 2024-02-07 12:23 ` Dave Martin 2024-02-07 13:09 ` Mark Brown 2024-02-07 13:09 ` Mark Brown 2024-02-07 13:51 ` Dave Martin 2024-02-07 13:51 ` Dave Martin 2024-02-07 15:07 ` Mark Brown 2024-02-07 15:07 ` Mark Brown 2024-02-12 16:50 ` Dave Martin 2024-02-12 16:50 ` Dave Martin 2024-02-12 17:09 ` Mark Brown 2024-02-12 17:09 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZcZjdnchVblj4iP+@finisterre.sirena.org.uk \ --to=broonie@kernel.org \ --cc=Dave.Martin@arm.com \ --cc=catalin.marinas@arm.com \ --cc=dianders@chromium.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=oleg@redhat.com \ --cc=viro@zeniv.linux.org.uk \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.