From: Herbert Xu <herbert@gondor.apana.org.au> To: Andrey Skvortsov <andrej.skvortzov@gmail.com> Cc: Corentin Labbe <clabbe.montjoie@gmail.com>, "David S. Miller" <davem@davemloft.net>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, Jonathan Corbet <corbet@lwn.net>, Ovidiu Panait <ovidiu.panait@windriver.com>, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Arnaud Ferraris <arnaud.ferraris@collabora.com> Subject: [PATCH] crypto: rk3288 - Fix use after free in unprepare Date: Wed, 28 Feb 2024 17:13:16 +0800 [thread overview] Message-ID: <Zd75LLhzlJx4nJiP@gondor.apana.org.au> (raw) In-Reply-To: <20240226215358.555234-1-andrej.skvortzov@gmail.com> The unprepare call must be carried out before the finalize call as the latter can free the request. Fixes: c66c17a0f69b ("crypto: rk3288 - Remove prepare/unprepare request") Reported-by: Andrey Skvortsov <andrej.skvortzov@gmail.com> Cc: <stable@vger.kernel.org> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> diff --git a/drivers/crypto/rockchip/rk3288_crypto_ahash.c b/drivers/crypto/rockchip/rk3288_crypto_ahash.c index 1b13b4aa16ec..a235e6c300f1 100644 --- a/drivers/crypto/rockchip/rk3288_crypto_ahash.c +++ b/drivers/crypto/rockchip/rk3288_crypto_ahash.c @@ -332,12 +332,12 @@ static int rk_hash_run(struct crypto_engine *engine, void *breq) theend: pm_runtime_put_autosuspend(rkc->dev); + rk_hash_unprepare(engine, breq); + local_bh_disable(); crypto_finalize_hash_request(engine, breq, err); local_bh_enable(); - rk_hash_unprepare(engine, breq); - return 0; } -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
WARNING: multiple messages have this Message-ID (diff)
From: Herbert Xu <herbert@gondor.apana.org.au> To: Andrey Skvortsov <andrej.skvortzov@gmail.com> Cc: Corentin Labbe <clabbe.montjoie@gmail.com>, "David S. Miller" <davem@davemloft.net>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, Jonathan Corbet <corbet@lwn.net>, Ovidiu Panait <ovidiu.panait@windriver.com>, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Arnaud Ferraris <arnaud.ferraris@collabora.com> Subject: [PATCH] crypto: rk3288 - Fix use after free in unprepare Date: Wed, 28 Feb 2024 17:13:16 +0800 [thread overview] Message-ID: <Zd75LLhzlJx4nJiP@gondor.apana.org.au> (raw) In-Reply-To: <20240226215358.555234-1-andrej.skvortzov@gmail.com> The unprepare call must be carried out before the finalize call as the latter can free the request. Fixes: c66c17a0f69b ("crypto: rk3288 - Remove prepare/unprepare request") Reported-by: Andrey Skvortsov <andrej.skvortzov@gmail.com> Cc: <stable@vger.kernel.org> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> diff --git a/drivers/crypto/rockchip/rk3288_crypto_ahash.c b/drivers/crypto/rockchip/rk3288_crypto_ahash.c index 1b13b4aa16ec..a235e6c300f1 100644 --- a/drivers/crypto/rockchip/rk3288_crypto_ahash.c +++ b/drivers/crypto/rockchip/rk3288_crypto_ahash.c @@ -332,12 +332,12 @@ static int rk_hash_run(struct crypto_engine *engine, void *breq) theend: pm_runtime_put_autosuspend(rkc->dev); + rk_hash_unprepare(engine, breq); + local_bh_disable(); crypto_finalize_hash_request(engine, breq, err); local_bh_enable(); - rk_hash_unprepare(engine, breq); - return 0; } -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-28 9:13 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-26 21:53 [PATCH] crypto: sun8i-ce - Fix use after free in unprepare Andrey Skvortsov 2024-02-26 21:53 ` Andrey Skvortsov 2024-02-26 22:05 ` Andrey Skvortsov 2024-02-26 22:05 ` Andrey Skvortsov 2024-02-28 9:07 ` Herbert Xu 2024-02-28 9:07 ` Herbert Xu 2024-02-28 9:08 ` Herbert Xu 2024-02-28 9:08 ` Herbert Xu 2024-02-28 9:13 ` Herbert Xu [this message] 2024-02-28 9:13 ` [PATCH] crypto: rk3288 " Herbert Xu 2024-02-28 13:35 ` Andrey Skvortsov 2024-02-28 13:35 ` Andrey Skvortsov 2024-02-28 9:18 ` [PATCH] crypto: sun8i-ce " Herbert Xu 2024-02-28 9:18 ` Herbert Xu 2024-02-28 20:46 ` Andrey Skvortsov 2024-02-28 20:46 ` Andrey Skvortsov 2024-02-29 1:40 ` Herbert Xu 2024-02-29 1:40 ` Herbert Xu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Zd75LLhzlJx4nJiP@gondor.apana.org.au \ --to=herbert@gondor.apana.org.au \ --cc=andrej.skvortzov@gmail.com \ --cc=arnaud.ferraris@collabora.com \ --cc=clabbe.montjoie@gmail.com \ --cc=corbet@lwn.net \ --cc=davem@davemloft.net \ --cc=jernej.skrabec@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-crypto@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sunxi@lists.linux.dev \ --cc=ovidiu.panait@windriver.com \ --cc=samuel@sholland.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.