Re: [PATCH v1 1/1] idma64: Don't try to serve interrupts when device is powered off

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Vinod Koul <vkoul@kernel.org>, Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH v1 1/1] idma64: Don't try to serve interrupts when device is powered off
Date: Wed, 20 Mar 2024 18:36:10 +0200	[thread overview]
Message-ID: <ZfsQeo8NxOuHVbfE@smile.fi.intel.com> (raw)
In-Reply-To: <20240320163210.1153679-1-andriy.shevchenko@linux.intel.com>

On Wed, Mar 20, 2024 at 06:32:10PM +0200, Andy Shevchenko wrote:
> When iDMA 64-bit device is powered off, the IRQ status register
> is all 1:s. This is never happen in real case and signalling that
> the device is simply powered off. Don't try to serve interrupts
> that are not ours.

...

>  	dev_vdbg(idma64->dma.dev, "%s: status=%#x\n", __func__, status);

Dunno if I actually also need to move this message to after the checks...

> +	/* Since IRQ may be shared, check if DMA controller is powered on */
> +	if (status == GENMASK(31, 0))
> +		return IRQ_NONE;
> +
>  	/* Check if we have any interrupt from the DMA controller */
>  	if (!status)
>  		return IRQ_NONE;

-- 
With Best Regards,
Andy Shevchenko