Re: [PATCH v1 1/1] idma64: Don't try to serve interrupts when device is powered off

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Vinod Koul" <vkoul@kernel.org>
Subject: Re: [PATCH v1 1/1] idma64: Don't try to serve interrupts when device is powered off
Date: Thu, 21 Mar 2024 14:02:30 +0200	[thread overview]
Message-ID: <Zfwh1kte7kAiHD-f@smile.fi.intel.com> (raw)
In-Reply-To: <5bf33366-c376-4b9e-a280-071b98fbdad5@gmail.com>

On Thu, Mar 21, 2024 at 12:49:20PM +0100, Heiner Kallweit wrote:
> On 20.03.2024 17:32, Andy Shevchenko wrote:

...

> >  	dev_vdbg(idma64->dma.dev, "%s: status=%#x\n", __func__, status);
> >  
> > +	/* Since IRQ may be shared, check if DMA controller is powered on */
> > +	if (status == GENMASK(31, 0))
> > +		return IRQ_NONE;
> > +
> >  	/* Check if we have any interrupt from the DMA controller */
> >  	if (!status)
> >  		return IRQ_NONE;
> > -- 2.43.0.rc1.1.gbec44491f096
> 
> Tested-by: Heiner Kallweit <hkallweit1@gmail.com>

Thank you! I think I'll move the test to be before the debug message as it
makes no sense to print when we have powered off device.
Nevertheless, I'll take your tag if no objections for v2.

-- 
With Best Regards,
Andy Shevchenko