Re: [PATCH V7 0/6] soc: imx8mp: Finish support for HDMI

From: Tommaso Merciai <tomm.merciai@gmail.com>
To: Adam Ford <aford173@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-phy@lists.infradead.org, aford@beaconembedded.com,
	Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Lucas Stach <l.stach@pengutronix.de>,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V7 0/6] soc: imx8mp: Finish support for HDMI
Date: Tue, 26 Mar 2024 10:13:59 +0100	[thread overview]
Message-ID: <ZgKR18zbZKV9p8tP@tom-HP-ZBook-Fury-15-G7-Mobile-Workstation> (raw)
In-Reply-To: <20240227220444.77566-1-aford173@gmail.com>

Hi Adam,

Thanks for your work.
For all the series:

Tested-by: Tommaso Merciai <tomm.merciai@gmail.com>

Regards,
Tommaso

On Tue, Feb 27, 2024 at 04:04:34PM -0600, Adam Ford wrote:
> The i.MX8M Plus has an HDMI controller, which depends on several
> other systems.  The Parallel Video Interface (PVI) and the
> HDMI-TX are already in the Linux-Next staging area 20240209, but
> the HDMI PHY driver and several device trees updates are still needed.
> 
> This series is adapted from multiple series from Lucas Stach with
> edits and suggestions from feedback from various attempts, but it
> since it's difficult to use and test them independently,
> I merged them into on unified series.  The version history is a
> bit ambiguous since different components were submitted at different
> times and had different amount of attempts.
> 
> The previous attempt I did used the wrong starting point for the PHY,
> so this update includes a newer starting point with tags from that version
> and fixes from various people's feedback.  I hope I caught them all, but
> I apologize if I missed something. Any tags from the previous attempt I
> made were intentionally dropped, because of the significant change,
> but I kept tags from the newer version I grabbed from patchwork.
> 
> Because several items from the last attempt were merged, this
> series is only focussed on adding the HDMI PHY driver, and enabling
> the power domain, irqsteer interrupt controller, and HDMI pipeline
> in the device tree. The version numbers are a bit strange since
> these all got pulled from various attempts with different versions,
> but I wanted to push them together as a series to complete the pending
> work.
> 
> This series restarted at V4 based on the version of the PHY driver and
> the other drivers and power-domain changes have been applied already.
> 
> V7:  Patch 5/7 marks the PVI driver disabled by default to prevent
>      EPROBE_DEFER errors.
> 
>      No other changes to other patches in the series
> 
> V6:  Make the PHY driver depend on COMMON_CLK to fix build errors
>      Make LCDIF3 disabled by default since it depends on hardware.
> 
> V5 primarily updates feedback from the PHY driver itself, but a small
>    adjustment was made to the register size in the device tree.
> Adam Ford (1):
>   arm64: defconfig: Enable DRM_IMX8MP_DW_HDMI_BRIDGE as module
> 
> 
> Adam Ford (1):
>   arm64: defconfig: Enable DRM_IMX8MP_DW_HDMI_BRIDGE as module
> 
> Lucas Stach (5):
>   dt-bindings: phy: add binding for the i.MX8MP HDMI PHY
>   phy: freescale: add Samsung HDMI PHY
>   arm64: dts: imx8mp: add HDMI power-domains
>   arm64: dts: imx8mp: add HDMI irqsteer
>   arm64: dts: imx8mp: add HDMI display pipeline
> 
>  .../bindings/phy/fsl,imx8mp-hdmi-phy.yaml     |  62 ++
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi     | 147 ++++
>  arch/arm64/configs/defconfig                  |   1 +
>  drivers/phy/freescale/Kconfig                 |   6 +
>  drivers/phy/freescale/Makefile                |   1 +
>  drivers/phy/freescale/phy-fsl-samsung-hdmi.c  | 720 ++++++++++++++++++
>  6 files changed, 937 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/phy/fsl,imx8mp-hdmi-phy.yaml
>  create mode 100644 drivers/phy/freescale/phy-fsl-samsung-hdmi.c
> 
> -- 
> 2.43.0
> 
> 