From: Florian Fainelli <f.fainelli@gmail.com> To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>, Rob Herring <robh+dt@kernel.org>, Nicolas Saenz Julienne <nsaenz@kernel.org>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, bcm-kernel-feedback-list@broadcom.com, Chris Brandt <chris.brandt@renesas.com>, Wolfram Sang <wsa+renesas@sang-engineering.com> Cc: linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar <prabhakar.csengg@gmail.com> Subject: Re: [PATCH 1/3] i2c: bcm2835: Use platform_get_irq() to get the interrupt Date: Sat, 18 Dec 2021 13:17:13 -0800 [thread overview] Message-ID: <a02d76dc-52cc-3ecc-5ef7-825c3167431a@gmail.com> (raw) In-Reply-To: <20211218165258.16716-2-prabhakar.mahadev-lad.rj@bp.renesas.com> On 12/18/2021 8:52 AM, Lad Prabhakar wrote: > platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static > allocation of IRQ resources in DT core code, this causes an issue > when using hierarchical interrupt domains using "interrupts" property > in the node as this bypasses the hierarchical setup and messes up the > irq chaining. > > In preparation for removal of static setup of IRQ resource from DT core > code use platform_get_irq(). > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Just one nit below: > --- > drivers/i2c/busses/i2c-bcm2835.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c > index 37443edbf754..d63dec5f3cb1 100644 > --- a/drivers/i2c/busses/i2c-bcm2835.c > +++ b/drivers/i2c/busses/i2c-bcm2835.c > @@ -402,7 +402,7 @@ static const struct i2c_adapter_quirks bcm2835_i2c_quirks = { > static int bcm2835_i2c_probe(struct platform_device *pdev) > { > struct bcm2835_i2c_dev *i2c_dev; > - struct resource *mem, *irq; > + struct resource *mem; > int ret; > struct i2c_adapter *adap; > struct clk *mclk; > @@ -452,12 +452,9 @@ static int bcm2835_i2c_probe(struct platform_device *pdev) > return ret; > } > > - irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > - if (!irq) { > - dev_err(&pdev->dev, "No IRQ resource\n"); > - return -ENODEV; > - } > - i2c_dev->irq = irq->start; > + i2c_dev->irq = platform_get_irq(pdev, 0); > + if (i2c_dev->irq <= 0) > + return i2c_dev->irq ? i2c_dev->irq : -ENXIO; Why not just check for a negative return code and propagate it as is? -- Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com> To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>, Rob Herring <robh+dt@kernel.org>, Nicolas Saenz Julienne <nsaenz@kernel.org>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, bcm-kernel-feedback-list@broadcom.com, Chris Brandt <chris.brandt@renesas.com>, Wolfram Sang <wsa+renesas@sang-engineering.com> Cc: linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar <prabhakar.csengg@gmail.com> Subject: Re: [PATCH 1/3] i2c: bcm2835: Use platform_get_irq() to get the interrupt Date: Sat, 18 Dec 2021 13:17:13 -0800 [thread overview] Message-ID: <a02d76dc-52cc-3ecc-5ef7-825c3167431a@gmail.com> (raw) In-Reply-To: <20211218165258.16716-2-prabhakar.mahadev-lad.rj@bp.renesas.com> On 12/18/2021 8:52 AM, Lad Prabhakar wrote: > platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static > allocation of IRQ resources in DT core code, this causes an issue > when using hierarchical interrupt domains using "interrupts" property > in the node as this bypasses the hierarchical setup and messes up the > irq chaining. > > In preparation for removal of static setup of IRQ resource from DT core > code use platform_get_irq(). > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Just one nit below: > --- > drivers/i2c/busses/i2c-bcm2835.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c > index 37443edbf754..d63dec5f3cb1 100644 > --- a/drivers/i2c/busses/i2c-bcm2835.c > +++ b/drivers/i2c/busses/i2c-bcm2835.c > @@ -402,7 +402,7 @@ static const struct i2c_adapter_quirks bcm2835_i2c_quirks = { > static int bcm2835_i2c_probe(struct platform_device *pdev) > { > struct bcm2835_i2c_dev *i2c_dev; > - struct resource *mem, *irq; > + struct resource *mem; > int ret; > struct i2c_adapter *adap; > struct clk *mclk; > @@ -452,12 +452,9 @@ static int bcm2835_i2c_probe(struct platform_device *pdev) > return ret; > } > > - irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > - if (!irq) { > - dev_err(&pdev->dev, "No IRQ resource\n"); > - return -ENODEV; > - } > - i2c_dev->irq = irq->start; > + i2c_dev->irq = platform_get_irq(pdev, 0); > + if (i2c_dev->irq <= 0) > + return i2c_dev->irq ? i2c_dev->irq : -ENXIO; Why not just check for a negative return code and propagate it as is? -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-18 21:17 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-18 16:52 [PATCH 0/3] i2c/busses: Use platform_get_irq/_optional() variants to fetch IRQ's Lad Prabhakar 2021-12-18 16:52 ` Lad Prabhakar 2021-12-18 16:52 ` [PATCH 1/3] i2c: bcm2835: Use platform_get_irq() to get the interrupt Lad Prabhakar 2021-12-18 16:52 ` Lad Prabhakar 2021-12-18 21:17 ` Florian Fainelli [this message] 2021-12-18 21:17 ` Florian Fainelli 2021-12-18 22:44 ` Lad, Prabhakar 2021-12-18 22:44 ` Lad, Prabhakar 2021-12-19 9:52 ` Lad, Prabhakar 2021-12-19 9:52 ` Lad, Prabhakar 2021-12-19 18:21 ` Florian Fainelli 2021-12-19 18:21 ` Florian Fainelli 2021-12-18 16:52 ` [PATCH 2/3] i2c: sh_mobile: Use platform_get_irq_optional() " Lad Prabhakar 2021-12-18 16:52 ` Lad Prabhakar 2021-12-20 10:16 ` Wolfram Sang 2021-12-20 10:16 ` Wolfram Sang 2021-12-20 11:58 ` Lad, Prabhakar 2021-12-20 11:58 ` Lad, Prabhakar 2021-12-20 10:17 ` Geert Uytterhoeven 2021-12-20 10:17 ` Geert Uytterhoeven 2021-12-20 11:53 ` Sergei Shtylyov 2021-12-20 11:53 ` Sergei Shtylyov 2022-02-08 12:31 ` Arnd Bergmann 2022-02-08 12:31 ` Arnd Bergmann 2022-02-09 15:11 ` Sergei Shtylyov 2022-02-09 15:11 ` Sergei Shtylyov 2022-02-09 15:18 ` Arnd Bergmann 2022-02-09 15:18 ` Arnd Bergmann 2022-02-09 15:48 ` Sergei Shtylyov 2022-02-09 15:48 ` Sergei Shtylyov 2022-02-09 16:02 ` Arnd Bergmann 2022-02-09 16:02 ` Arnd Bergmann 2022-02-09 16:08 ` Sergei Shtylyov 2022-02-09 16:08 ` Sergei Shtylyov 2022-02-09 22:56 ` Arnd Bergmann 2022-02-09 22:56 ` Arnd Bergmann 2022-02-10 8:54 ` Geert Uytterhoeven 2022-02-10 8:54 ` Geert Uytterhoeven 2022-02-10 9:32 ` Geert Uytterhoeven 2022-02-10 9:32 ` Geert Uytterhoeven 2022-02-10 9:46 ` Sergei Shtylyov 2022-02-10 9:46 ` Sergei Shtylyov 2021-12-20 11:55 ` Lad, Prabhakar 2021-12-20 11:55 ` Lad, Prabhakar 2021-12-20 12:54 ` Geert Uytterhoeven 2021-12-20 12:54 ` Geert Uytterhoeven 2021-12-20 13:00 ` Lad, Prabhakar 2021-12-20 13:00 ` Lad, Prabhakar 2021-12-18 16:52 ` [PATCH 3/3] i2c: riic: Use platform_get_irq() " Lad Prabhakar 2021-12-18 16:52 ` Lad Prabhakar 2021-12-20 10:16 ` Wolfram Sang 2021-12-20 10:16 ` Wolfram Sang 2021-12-20 10:20 ` Geert Uytterhoeven 2021-12-20 10:20 ` Geert Uytterhoeven
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a02d76dc-52cc-3ecc-5ef7-825c3167431a@gmail.com \ --to=f.fainelli@gmail.com \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=chris.brandt@renesas.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=nsaenz@kernel.org \ --cc=prabhakar.csengg@gmail.com \ --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \ --cc=rjui@broadcom.com \ --cc=robh+dt@kernel.org \ --cc=sbranden@broadcom.com \ --cc=wsa+renesas@sang-engineering.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.