Re: [PATCH v2] clocksource/drivers/sp804: avoid error on multiple instances

From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Andre Przywara <andre.przywara@arm.com>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: Russell King <linux@armlinux.org.uk>,
	Kefeng Wang <wangkefeng.wang@huawei.com>,
	Zhen Lei <thunder.leizhen@huawei.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] clocksource/drivers/sp804: avoid error on multiple instances
Date: Mon, 9 May 2022 13:46:25 +0200	[thread overview]
Message-ID: <a1d44fbb-c2a9-e422-8ce8-2a3982a75bb8@linaro.org> (raw)
In-Reply-To: <20220506162522.3675399-1-andre.przywara@arm.com>

On 06/05/2022 18:25, Andre Przywara wrote:
> When a machine sports more than one SP804 timer instance, we only bring
> up the first one, since multiple timers of the same kind are not useful
> to Linux. As this is intentional behaviour, we should not return an
> error message, as we do today:
> ===============
> [    0.000800] Failed to initialize '/bus@8000000/motherboard-bus@8000000/iofpga-bus@300000000/timer@120000': -22
> ===============
> 
> Replace the -EINVAL return with a debug message and return 0 instead.
> 
> Also we do not reach the init function anymore if the DT node is
> disabled (as this is now handled by OF_DECLARE), so remove the explicit
> check for that case.
> 
> This fixes a long standing bogus error when booting ARM's fastmodels.
> 
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---

Applied, thanks


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog