From: Bob Liu <bob.liu@oracle.com>
To: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Max Gurtovoy <maxg@mellanox.com>,
Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@intel.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 0/5] blk-mq: wait until completed req's complete fn is run
Date: Tue, 23 Jul 2019 07:27:00 +0800 [thread overview]
Message-ID: <a22e7266-98cb-875d-aa89-f37dd6c34ad5@oracle.com> (raw)
In-Reply-To: <20190722053954.25423-1-ming.lei@redhat.com>
On 7/22/19 1:39 PM, Ming Lei wrote:
> Hi,
>
> blk-mq may schedule to call queue's complete function on remote CPU via
> IPI, but never provide any way to synchronize the request's complete
> fn.
>
> In some driver's EH(such as NVMe), hardware queue's resource may be freed &
> re-allocated. If the completed request's complete fn is run finally after the
> hardware queue's resource is released, kernel crash will be triggered.
>
Have you seen the crash? Anyway to emulate/verify this bug..
> Fixes this issue by waitting until completed req's complete fn is run.
>
> Thanks,
> Ming
>
> Ming Lei (5):
> blk-mq: introduce blk_mq_request_completed()
> blk-mq: introduce blk_mq_tagset_wait_completed_request()
> nvme: don't abort completed request in nvme_cancel_request
> nvme: wait until all completed request's complete fn is called
> blk-mq: remove blk_mq_complete_request_sync
>
> block/blk-mq-tag.c | 32 ++++++++++++++++++++++++++++++++
> block/blk-mq.c | 13 ++++++-------
> drivers/nvme/host/core.c | 6 +++++-
> drivers/nvme/host/pci.c | 2 ++
> drivers/nvme/host/rdma.c | 8 ++++++--
> drivers/nvme/host/tcp.c | 8 ++++++--
> drivers/nvme/target/loop.c | 2 ++
> include/linux/blk-mq.h | 3 ++-
> 8 files changed, 61 insertions(+), 13 deletions(-)
>
> Cc: Max Gurtovoy <maxg@mellanox.com>
> Cc: Sagi Grimberg <sagi@grimberg.me>
> Cc: Keith Busch <keith.busch@intel.com>
> Cc: Christoph Hellwig <hch@lst.de>
>
WARNING: multiple messages have this Message-ID (diff)
From: bob.liu@oracle.com (Bob Liu)
Subject: [PATCH 0/5] blk-mq: wait until completed req's complete fn is run
Date: Tue, 23 Jul 2019 07:27:00 +0800 [thread overview]
Message-ID: <a22e7266-98cb-875d-aa89-f37dd6c34ad5@oracle.com> (raw)
In-Reply-To: <20190722053954.25423-1-ming.lei@redhat.com>
On 7/22/19 1:39 PM, Ming Lei wrote:
> Hi,
>
> blk-mq may schedule to call queue's complete function on remote CPU via
> IPI, but never provide any way to synchronize the request's complete
> fn.
>
> In some driver's EH(such as NVMe), hardware queue's resource may be freed &
> re-allocated. If the completed request's complete fn is run finally after the
> hardware queue's resource is released, kernel crash will be triggered.
>
Have you seen the crash? Anyway to emulate/verify this bug..
> Fixes this issue by waitting until completed req's complete fn is run.
>
> Thanks,
> Ming
>
> Ming Lei (5):
> blk-mq: introduce blk_mq_request_completed()
> blk-mq: introduce blk_mq_tagset_wait_completed_request()
> nvme: don't abort completed request in nvme_cancel_request
> nvme: wait until all completed request's complete fn is called
> blk-mq: remove blk_mq_complete_request_sync
>
> block/blk-mq-tag.c | 32 ++++++++++++++++++++++++++++++++
> block/blk-mq.c | 13 ++++++-------
> drivers/nvme/host/core.c | 6 +++++-
> drivers/nvme/host/pci.c | 2 ++
> drivers/nvme/host/rdma.c | 8 ++++++--
> drivers/nvme/host/tcp.c | 8 ++++++--
> drivers/nvme/target/loop.c | 2 ++
> include/linux/blk-mq.h | 3 ++-
> 8 files changed, 61 insertions(+), 13 deletions(-)
>
> Cc: Max Gurtovoy <maxg at mellanox.com>
> Cc: Sagi Grimberg <sagi at grimberg.me>
> Cc: Keith Busch <keith.busch at intel.com>
> Cc: Christoph Hellwig <hch at lst.de>
>
next prev parent reply other threads:[~2019-07-22 23:27 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 5:39 [PATCH 0/5] blk-mq: wait until completed req's complete fn is run Ming Lei
2019-07-22 5:39 ` Ming Lei
2019-07-22 5:39 ` [PATCH 1/5] blk-mq: introduce blk_mq_request_completed() Ming Lei
2019-07-22 5:39 ` Ming Lei
2019-07-23 20:26 ` Sagi Grimberg
2019-07-23 20:26 ` Sagi Grimberg
2019-07-22 5:39 ` [PATCH 2/5] blk-mq: introduce blk_mq_tagset_wait_completed_request() Ming Lei
2019-07-22 5:39 ` Ming Lei
2019-07-22 15:25 ` Bart Van Assche
2019-07-22 15:25 ` Bart Van Assche
2019-07-23 1:06 ` Ming Lei
2019-07-23 1:06 ` Ming Lei
2019-07-23 20:54 ` Bart Van Assche
2019-07-23 20:54 ` Bart Van Assche
2019-07-24 1:34 ` Ming Lei
2019-07-24 1:34 ` Ming Lei
2019-07-23 20:27 ` Sagi Grimberg
2019-07-23 20:27 ` Sagi Grimberg
2019-07-22 5:39 ` [PATCH 3/5] nvme: don't abort completed request in nvme_cancel_request Ming Lei
2019-07-22 5:39 ` Ming Lei
2019-07-22 15:27 ` Bart Van Assche
2019-07-22 15:27 ` Bart Van Assche
2019-07-22 23:22 ` Keith Busch
2019-07-22 23:22 ` Keith Busch
2019-07-23 0:07 ` Sagi Grimberg
2019-07-23 0:07 ` Sagi Grimberg
2019-07-23 1:08 ` Ming Lei
2019-07-23 1:08 ` Ming Lei
2019-07-23 19:22 ` Bart Van Assche
2019-07-23 19:22 ` Bart Van Assche
2019-07-23 20:27 ` Sagi Grimberg
2019-07-23 20:27 ` Sagi Grimberg
2019-07-22 5:39 ` [PATCH 4/5] nvme: wait until all completed request's complete fn is called Ming Lei
2019-07-22 5:39 ` Ming Lei
2019-07-23 16:14 ` Dongli Zhang
2019-07-23 16:14 ` Dongli Zhang
2019-07-24 2:05 ` Ming Lei
2019-07-24 2:05 ` Ming Lei
2019-07-23 20:29 ` Sagi Grimberg
2019-07-23 20:29 ` Sagi Grimberg
2019-07-24 1:43 ` Ming Lei
2019-07-24 1:43 ` Ming Lei
2019-07-22 5:39 ` [PATCH 5/5] blk-mq: remove blk_mq_complete_request_sync Ming Lei
2019-07-22 5:39 ` Ming Lei
2019-07-23 20:30 ` Sagi Grimberg
2019-07-23 20:30 ` Sagi Grimberg
2019-07-22 23:27 ` Bob Liu [this message]
2019-07-22 23:27 ` [PATCH 0/5] blk-mq: wait until completed req's complete fn is run Bob Liu
2019-07-23 1:10 ` Ming Lei
2019-07-23 1:10 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a22e7266-98cb-875d-aa89-f37dd6c34ad5@oracle.com \
--to=bob.liu@oracle.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=maxg@mellanox.com \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.