From: David Ahern <dsahern@kernel.org>
To: Ido Schimmel <idosch@idosch.org>,
Sriram Yagnaraman <sriram.yagnaraman@est.tech>,
kuba@kernel.org, pabeni@redhat.com
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Ido Schimmel <idosch@nvidia.com>, Shuah Khan <shuah@kernel.org>,
Petr Machata <petrm@nvidia.com>
Subject: Re: [PATCH net v3 3/3] selftests: fib_tests: Add multipath list receive tests
Date: Mon, 28 Aug 2023 12:57:20 -0600 [thread overview]
Message-ID: <a2d78f3e-b1a4-1309-c7a4-7198fc26f9cc@kernel.org> (raw)
In-Reply-To: <ZOy8JOjw9W4g8fYa@shredder>
On 8/28/23 9:24 AM, Ido Schimmel wrote:
> On Mon, Aug 28, 2023 at 01:32:21PM +0200, Sriram Yagnaraman wrote:
>> The test uses perf stat to count the number of fib:fib_table_lookup
>> tracepoint hits for IPv4 and the number of fib6:fib6_table_lookup for
>> IPv6. The measured count is checked to be within 5% of the total number
>> of packets sent via veth1.
>>
>> Signed-off-by: Sriram Yagnaraman <sriram.yagnaraman@est.tech>
>
> I just tested this with a debug config and noticed that the single path
> test is not very stable. It's not really related to the bug fix, so I
> think you can simply remove it.
>
> Jakub / Paolo, this change conflicts with changes in net-next and I
> assume that the next PR that you are going to send is from net-next.
> What is your preference in this case? Wait for the PR to be accepted and
> for master to be merged into net?
>
> Thanks
Ido, thanks for staying on top of this change and the details with the
test cases.
next prev parent reply other threads:[~2023-08-28 18:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 11:32 [PATCH net v3 0/3] Avoid TCP resets when using ECMP for load-balancing between multiple servers Sriram Yagnaraman
2023-08-28 11:32 ` Sriram Yagnaraman
2023-08-28 11:32 ` [PATCH net v3 1/3] ipv4: ignore dst hint for multipath routes Sriram Yagnaraman
2023-08-28 11:32 ` Sriram Yagnaraman
2023-08-28 15:15 ` Ido Schimmel
2023-08-28 18:55 ` David Ahern
2023-08-28 11:32 ` [PATCH net v3 2/3] ipv6: " Sriram Yagnaraman
2023-08-28 11:32 ` Sriram Yagnaraman
2023-08-28 15:16 ` Ido Schimmel
2023-08-28 18:56 ` David Ahern
2023-08-28 11:32 ` [PATCH net v3 3/3] selftests: fib_tests: Add multipath list receive tests Sriram Yagnaraman
2023-08-28 11:32 ` Sriram Yagnaraman
2023-08-28 15:24 ` Ido Schimmel
2023-08-28 18:57 ` David Ahern [this message]
2023-08-28 19:14 ` Jakub Kicinski
2023-08-30 9:17 ` Sriram Yagnaraman
2023-08-30 15:42 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2d78f3e-b1a4-1309-c7a4-7198fc26f9cc@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@idosch.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shuah@kernel.org \
--cc=sriram.yagnaraman@est.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.