From: Sriram Yagnaraman <sriram.yagnaraman@est.tech> Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, "David S . Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, David Ahern <dsahern@kernel.org>, Ido Schimmel <idosch@nvidia.com>, Shuah Khan <shuah@kernel.org>, Petr Machata <petrm@nvidia.com>, Sriram Yagnaraman <sriram.yagnaraman@est.tech> Subject: [PATCH net v3 0/3] Avoid TCP resets when using ECMP for load-balancing between multiple servers. Date: Mon, 28 Aug 2023 13:32:18 +0200 [thread overview] Message-ID: <20230828113221.20123-1-sriram.yagnaraman@est.tech> (raw) All packets in the same flow (L3/L4 depending on multipath hash policy) should be directed to the same target, but after [0]/[1] we see stray packets directed towards other targets. This, for instance, causes RST to be sent on TCP connections. The first two patches solve the problem by ignoring route hints for destinations that are part of multipath group, by using new SKB flags for IPv4 and IPv6. The third patch is a selftest that tests the scenario. Thanks to Ido, for reviewing and suggesting a way forward in [2] and also suggesting how to write a selftest for this. v2->v3: - Add NULL check for skb in fib6_select_path (Ido Schimmel) - Use fib_tests.sh for selftest instead of the forwarding suite (Ido Schimmel) v1->v2: - Update to commit messages describing the solution (Ido Schimmel) - Use perf stat to count fib table lookups in selftest (Ido Schimmel) Sriram Yagnaraman (3): ipv4: ignore dst hint for multipath routes ipv6: ignore dst hint for multipath routes selftests: fib_tests: Add multipath list receive tests include/linux/ipv6.h | 1 + include/net/ip.h | 1 + net/ipv4/ip_input.c | 3 +- net/ipv4/route.c | 1 + net/ipv6/ip6_input.c | 3 +- net/ipv6/route.c | 3 + tools/testing/selftests/net/fib_tests.sh | 150 ++++++++++++++++++++++- 7 files changed, 159 insertions(+), 3 deletions(-) -- 2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Sriram Yagnaraman <sriram.yagnaraman@est.tech> To: unlisted-recipients:; (no To-header on input) Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, "David S . Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, David Ahern <dsahern@kernel.org>, Ido Schimmel <idosch@nvidia.com>, Shuah Khan <shuah@kernel.org>, Petr Machata <petrm@nvidia.com>, Sriram Yagnaraman <sriram.yagnaraman@est.tech> Subject: [PATCH net v3 0/3] Avoid TCP resets when using ECMP for load-balancing between multiple servers. Date: Mon, 28 Aug 2023 13:32:18 +0200 [thread overview] Message-ID: <20230828113221.20123-1-sriram.yagnaraman@est.tech> (raw) All packets in the same flow (L3/L4 depending on multipath hash policy) should be directed to the same target, but after [0]/[1] we see stray packets directed towards other targets. This, for instance, causes RST to be sent on TCP connections. The first two patches solve the problem by ignoring route hints for destinations that are part of multipath group, by using new SKB flags for IPv4 and IPv6. The third patch is a selftest that tests the scenario. Thanks to Ido, for reviewing and suggesting a way forward in [2] and also suggesting how to write a selftest for this. v2->v3: - Add NULL check for skb in fib6_select_path (Ido Schimmel) - Use fib_tests.sh for selftest instead of the forwarding suite (Ido Schimmel) v1->v2: - Update to commit messages describing the solution (Ido Schimmel) - Use perf stat to count fib table lookups in selftest (Ido Schimmel) Sriram Yagnaraman (3): ipv4: ignore dst hint for multipath routes ipv6: ignore dst hint for multipath routes selftests: fib_tests: Add multipath list receive tests include/linux/ipv6.h | 1 + include/net/ip.h | 1 + net/ipv4/ip_input.c | 3 +- net/ipv4/route.c | 1 + net/ipv6/ip6_input.c | 3 +- net/ipv6/route.c | 3 + tools/testing/selftests/net/fib_tests.sh | 150 ++++++++++++++++++++++- 7 files changed, 159 insertions(+), 3 deletions(-) -- 2.34.1
next reply other threads:[~2023-08-28 12:28 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-08-28 11:32 Sriram Yagnaraman [this message] 2023-08-28 11:32 ` [PATCH net v3 0/3] Avoid TCP resets when using ECMP for load-balancing between multiple servers Sriram Yagnaraman 2023-08-28 11:32 ` [PATCH net v3 1/3] ipv4: ignore dst hint for multipath routes Sriram Yagnaraman 2023-08-28 11:32 ` Sriram Yagnaraman 2023-08-28 15:15 ` Ido Schimmel 2023-08-28 18:55 ` David Ahern 2023-08-28 11:32 ` [PATCH net v3 2/3] ipv6: " Sriram Yagnaraman 2023-08-28 11:32 ` Sriram Yagnaraman 2023-08-28 15:16 ` Ido Schimmel 2023-08-28 18:56 ` David Ahern 2023-08-28 11:32 ` [PATCH net v3 3/3] selftests: fib_tests: Add multipath list receive tests Sriram Yagnaraman 2023-08-28 11:32 ` Sriram Yagnaraman 2023-08-28 15:24 ` Ido Schimmel 2023-08-28 18:57 ` David Ahern 2023-08-28 19:14 ` Jakub Kicinski 2023-08-30 9:17 ` Sriram Yagnaraman 2023-08-30 15:42 ` Ido Schimmel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230828113221.20123-1-sriram.yagnaraman@est.tech \ --to=sriram.yagnaraman@est.tech \ --cc=davem@davemloft.net \ --cc=dsahern@kernel.org \ --cc=edumazet@google.com \ --cc=idosch@nvidia.com \ --cc=kuba@kernel.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=pabeni@redhat.com \ --cc=petrm@nvidia.com \ --cc=shuah@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.