From: Sai Prakash Ranjan <quic_saipraka@quicinc.com> To: Catalin Marinas <catalin.marinas@arm.com> Cc: Will Deacon <will@kernel.org>, Arnd Bergmann <arnd@arndb.de>, Marc Zyngier <maz@kernel.org>, Steven Rostedt <rostedt@goodmis.org>, gregkh <gregkh@linuxfoundation.org>, <quic_psodagud@quicinc.com>, Trilok Soni <quic_tsoni@quicinc.com>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-arm-msm@vger.kernel.org> Subject: Re: [PATCHv9 1/5] arm64: io: Use asm-generic high level MMIO accessors Date: Thu, 10 Feb 2022 13:06:41 +0530 [thread overview] Message-ID: <a64cefd2-7dfa-c86c-f1aa-461699253b62@quicinc.com> (raw) In-Reply-To: <YgQNiXsh4hC+5+O5@arm.com> On 2/10/2022 12:22 AM, Catalin Marinas wrote: > On Mon, Jan 24, 2022 at 12:03:30PM +0530, Sai Prakash Ranjan wrote: >> Remove custom arm64 MMIO accessors read{b,w,l,q} and their relaxed >> versions in support to use asm-generic defined accessors. Also define >> one set of IO barriers (ar/bw version) used by asm-generic code to >> override the arm64 specific variants. >> >> Suggested-by: Arnd Bergmann <arnd@arndb.de> >> Signed-off-by: Sai Prakash Ranjan <quic_saipraka@quicinc.com> > I'm fine with this patch: > > Acked-by: Catalin Marinas <catalin.marinas@arm.com> Thanks! >> diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h >> index 7fd836bea7eb..1b436810d779 100644 >> --- a/arch/arm64/include/asm/io.h >> +++ b/arch/arm64/include/asm/io.h > [...] >> +/* arm64-specific, don't use in portable drivers */ >> +#define __iormb(v) __io_ar(v) >> +#define __iowmb() __io_bw() >> +#define __iomb() dma_mb() > However, I'd like to see a few subsequent patches that get rid of the > __io*mb() uses in drivers/ (there don't seem to be that many). > Sure, I will do these in next version of this series. Hoping to get reviews on other patches as well so I can include all the changes in the next version. Thanks, Sai
WARNING: multiple messages have this Message-ID (diff)
From: Sai Prakash Ranjan <quic_saipraka@quicinc.com> To: Catalin Marinas <catalin.marinas@arm.com> Cc: Will Deacon <will@kernel.org>, Arnd Bergmann <arnd@arndb.de>, Marc Zyngier <maz@kernel.org>, Steven Rostedt <rostedt@goodmis.org>, gregkh <gregkh@linuxfoundation.org>, <quic_psodagud@quicinc.com>, Trilok Soni <quic_tsoni@quicinc.com>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-arm-msm@vger.kernel.org> Subject: Re: [PATCHv9 1/5] arm64: io: Use asm-generic high level MMIO accessors Date: Thu, 10 Feb 2022 13:06:41 +0530 [thread overview] Message-ID: <a64cefd2-7dfa-c86c-f1aa-461699253b62@quicinc.com> (raw) In-Reply-To: <YgQNiXsh4hC+5+O5@arm.com> On 2/10/2022 12:22 AM, Catalin Marinas wrote: > On Mon, Jan 24, 2022 at 12:03:30PM +0530, Sai Prakash Ranjan wrote: >> Remove custom arm64 MMIO accessors read{b,w,l,q} and their relaxed >> versions in support to use asm-generic defined accessors. Also define >> one set of IO barriers (ar/bw version) used by asm-generic code to >> override the arm64 specific variants. >> >> Suggested-by: Arnd Bergmann <arnd@arndb.de> >> Signed-off-by: Sai Prakash Ranjan <quic_saipraka@quicinc.com> > I'm fine with this patch: > > Acked-by: Catalin Marinas <catalin.marinas@arm.com> Thanks! >> diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h >> index 7fd836bea7eb..1b436810d779 100644 >> --- a/arch/arm64/include/asm/io.h >> +++ b/arch/arm64/include/asm/io.h > [...] >> +/* arm64-specific, don't use in portable drivers */ >> +#define __iormb(v) __io_ar(v) >> +#define __iowmb() __io_bw() >> +#define __iomb() dma_mb() > However, I'd like to see a few subsequent patches that get rid of the > __io*mb() uses in drivers/ (there don't seem to be that many). > Sure, I will do these in next version of this series. Hoping to get reviews on other patches as well so I can include all the changes in the next version. Thanks, Sai _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-10 7:36 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-24 6:33 [PATCHv9 0/5] lib/rwmmio/arm64: Add support to trace register reads/writes Sai Prakash Ranjan 2022-01-24 6:33 ` Sai Prakash Ranjan 2022-01-24 6:33 ` [PATCHv9 1/5] arm64: io: Use asm-generic high level MMIO accessors Sai Prakash Ranjan 2022-01-24 6:33 ` Sai Prakash Ranjan 2022-02-09 18:52 ` Catalin Marinas 2022-02-09 18:52 ` Catalin Marinas 2022-02-10 7:36 ` Sai Prakash Ranjan [this message] 2022-02-10 7:36 ` Sai Prakash Ranjan 2022-01-24 6:33 ` [PATCHv9 2/5] irqchip/tegra: Fix overflow implicit truncation warnings Sai Prakash Ranjan 2022-01-24 6:33 ` Sai Prakash Ranjan 2022-01-25 9:30 ` Marc Zyngier 2022-01-25 13:35 ` Sai Prakash Ranjan 2022-01-25 13:35 ` Sai Prakash Ranjan 2022-01-24 6:33 ` [PATCHv9 3/5] drm/meson: " Sai Prakash Ranjan 2022-01-24 6:33 ` Sai Prakash Ranjan 2022-01-24 6:33 ` [PATCHv9 4/5] lib: Add register read/write tracing support Sai Prakash Ranjan 2022-01-24 6:33 ` Sai Prakash Ranjan 2022-02-14 3:37 ` Sai Prakash Ranjan 2022-02-14 3:37 ` Sai Prakash Ranjan 2022-01-24 6:33 ` [PATCHv9 5/5] asm-generic/io: Add logging support for MMIO accessors Sai Prakash Ranjan 2022-01-24 6:33 ` Sai Prakash Ranjan 2022-02-14 3:40 ` Sai Prakash Ranjan 2022-02-14 3:40 ` Sai Prakash Ranjan 2022-01-31 18:56 ` [PATCHv9 0/5] lib/rwmmio/arm64: Add support to trace register reads/writes Sai Prakash Ranjan 2022-01-31 18:56 ` Sai Prakash Ranjan 2022-02-08 9:31 ` Sai Prakash Ranjan 2022-02-08 9:31 ` Sai Prakash Ranjan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a64cefd2-7dfa-c86c-f1aa-461699253b62@quicinc.com \ --to=quic_saipraka@quicinc.com \ --cc=arnd@arndb.de \ --cc=catalin.marinas@arm.com \ --cc=gregkh@linuxfoundation.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=maz@kernel.org \ --cc=quic_psodagud@quicinc.com \ --cc=quic_tsoni@quicinc.com \ --cc=rostedt@goodmis.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.