From: Leonard Crestez <leonard.crestez@nxp.com> To: Shawn Guo <shawnguo@kernel.org>, Dong Aisheng <aisheng.dong@nxp.com> Cc: Fabio Estevam <fabio.estevam@nxp.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Stefan Agner <stefan@agner.ch>, Linus Walleij <linus.walleij@linaro.org>, Alessandro Zummo <a.zummo@towertech.it>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Anson Huang <anson.huang@nxp.com>, Abel Vesa <abel.vesa@nxp.com>, Franck LENORMAND <franck.lenormand@nxp.com>, kernel@pengutronix.de, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Subject: [PATCH v2 5/8] firmware: imx: Align imx_sc_msg_req_cpu_start to 4 Date: Thu, 20 Feb 2020 18:29:36 +0200 [thread overview] Message-ID: <a74fdf9dd976a6b3198844880ec2f4c6f1c70dca.1582216144.git.leonard.crestez@nxp.com> (raw) In-Reply-To: <cover.1582216144.git.leonard.crestez@nxp.com> In-Reply-To: <cover.1582216144.git.leonard.crestez@nxp.com> The imx SC api strongly assumes that messages are composed out of 4-bytes words but some of our message structs have odd sizeofs. This produces many oopses with CONFIG_KASAN=y. Fix by marking with __aligned(4). Fixes: d90bf296ae18 ("firmware: imx: Add support to start/stop a CPU") Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com> --- drivers/firmware/imx/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/imx/misc.c b/drivers/firmware/imx/misc.c index 6a21ff942f82..d073cb3ce699 100644 --- a/drivers/firmware/imx/misc.c +++ b/drivers/firmware/imx/misc.c @@ -22,11 +22,11 @@ struct imx_sc_msg_req_cpu_start { struct imx_sc_rpc_msg hdr; u32 address_hi; u32 address_lo; u16 resource; u8 enable; -} __packed; +} __packed __aligned(4); struct imx_sc_msg_req_misc_get_ctrl { struct imx_sc_rpc_msg hdr; u32 ctrl; u16 resource; -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Leonard Crestez <leonard.crestez@nxp.com> To: Shawn Guo <shawnguo@kernel.org>, Dong Aisheng <aisheng.dong@nxp.com> Cc: linux-rtc@vger.kernel.org, Alessandro Zummo <a.zummo@towertech.it>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Abel Vesa <abel.vesa@nxp.com>, Anson Huang <anson.huang@nxp.com>, Stephen Boyd <sboyd@kernel.org>, Michael Turquette <mturquette@baylibre.com>, Stefan Agner <stefan@agner.ch>, linux-clk@vger.kernel.org, Franck LENORMAND <franck.lenormand@nxp.com>, linux-gpio@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, Fabio Estevam <fabio.estevam@nxp.com>, Linus Walleij <linus.walleij@linaro.org>, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 5/8] firmware: imx: Align imx_sc_msg_req_cpu_start to 4 Date: Thu, 20 Feb 2020 18:29:36 +0200 [thread overview] Message-ID: <a74fdf9dd976a6b3198844880ec2f4c6f1c70dca.1582216144.git.leonard.crestez@nxp.com> (raw) In-Reply-To: <cover.1582216144.git.leonard.crestez@nxp.com> In-Reply-To: <cover.1582216144.git.leonard.crestez@nxp.com> The imx SC api strongly assumes that messages are composed out of 4-bytes words but some of our message structs have odd sizeofs. This produces many oopses with CONFIG_KASAN=y. Fix by marking with __aligned(4). Fixes: d90bf296ae18 ("firmware: imx: Add support to start/stop a CPU") Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com> --- drivers/firmware/imx/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/imx/misc.c b/drivers/firmware/imx/misc.c index 6a21ff942f82..d073cb3ce699 100644 --- a/drivers/firmware/imx/misc.c +++ b/drivers/firmware/imx/misc.c @@ -22,11 +22,11 @@ struct imx_sc_msg_req_cpu_start { struct imx_sc_rpc_msg hdr; u32 address_hi; u32 address_lo; u16 resource; u8 enable; -} __packed; +} __packed __aligned(4); struct imx_sc_msg_req_misc_get_ctrl { struct imx_sc_rpc_msg hdr; u32 ctrl; u16 resource; -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-20 16:29 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-20 16:29 [PATCH v2 0/8] firmware: imx: Align imx SC msg structs to 4 Leonard Crestez 2020-02-20 16:29 ` Leonard Crestez 2020-02-20 16:29 ` [PATCH v2 1/8] clk: imx: Align imx sc clock " Leonard Crestez 2020-02-20 16:29 ` Leonard Crestez 2020-02-24 7:22 ` Shawn Guo 2020-02-24 7:22 ` Shawn Guo 2020-03-16 0:25 ` Shawn Guo 2020-03-16 0:25 ` Shawn Guo 2020-02-25 16:51 ` Stephen Boyd 2020-02-25 16:51 ` Stephen Boyd 2020-02-25 19:52 ` Leonard Crestez 2020-02-25 19:52 ` Leonard Crestez [not found] ` <158276809953.177367.6095692240077023796@swboyd.mtv.corp.google.com> 2020-03-17 19:25 ` Leonard Crestez 2020-03-17 19:25 ` Leonard Crestez 2020-03-17 19:54 ` Dmitry Vyukov 2020-03-17 19:54 ` Dmitry Vyukov 2020-03-16 8:52 ` Aisheng Dong 2020-03-16 8:52 ` Aisheng Dong 2020-02-20 16:29 ` [PATCH v2 2/8] clk: imx: Align imx sc clock parent " Leonard Crestez 2020-02-20 16:29 ` Leonard Crestez 2020-02-24 7:23 ` Shawn Guo 2020-02-24 7:23 ` Shawn Guo 2020-02-20 16:29 ` [PATCH v2 3/8] firmware: imx: misc: Align imx sc " Leonard Crestez 2020-02-20 16:29 ` Leonard Crestez 2020-02-24 7:28 ` Shawn Guo 2020-02-24 7:28 ` Shawn Guo 2020-02-20 16:29 ` [PATCH v2 4/8] firmware: imx: scu-pd: " Leonard Crestez 2020-02-20 16:29 ` Leonard Crestez 2020-02-24 7:28 ` Shawn Guo 2020-02-24 7:28 ` Shawn Guo 2020-02-20 16:29 ` Leonard Crestez [this message] 2020-02-20 16:29 ` [PATCH v2 5/8] firmware: imx: Align imx_sc_msg_req_cpu_start " Leonard Crestez 2020-02-24 7:28 ` Shawn Guo 2020-02-24 7:28 ` Shawn Guo 2020-02-20 16:29 ` [PATCH v2 6/8] pinctrl: imx: scu: Align imx sc msg structs " Leonard Crestez 2020-02-20 16:29 ` Leonard Crestez 2020-02-21 15:34 ` Linus Walleij 2020-02-21 15:34 ` Linus Walleij 2020-02-20 16:29 ` [PATCH v2 7/8] rtc: imx-sc: " Leonard Crestez 2020-02-20 16:29 ` Leonard Crestez 2020-03-03 11:02 ` Alexandre Belloni 2020-03-03 11:02 ` Alexandre Belloni 2020-02-20 16:29 ` [PATCH v2 8/8] soc: imx-scu: " Leonard Crestez 2020-02-20 16:29 ` Leonard Crestez 2020-02-24 7:30 ` Shawn Guo 2020-02-24 7:30 ` Shawn Guo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a74fdf9dd976a6b3198844880ec2f4c6f1c70dca.1582216144.git.leonard.crestez@nxp.com \ --to=leonard.crestez@nxp.com \ --cc=a.zummo@towertech.it \ --cc=abel.vesa@nxp.com \ --cc=aisheng.dong@nxp.com \ --cc=alexandre.belloni@bootlin.com \ --cc=anson.huang@nxp.com \ --cc=fabio.estevam@nxp.com \ --cc=franck.lenormand@nxp.com \ --cc=kernel@pengutronix.de \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-imx@nxp.com \ --cc=linux-rtc@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=sboyd@kernel.org \ --cc=shawnguo@kernel.org \ --cc=stefan@agner.ch \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.