From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org, linux-pwm@vger.kernel.org,
thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 09/14] pwm: meson: move pwm_set_chip_data() to meson_pwm_request()
Date: Mon, 27 May 2019 14:30:37 +0200 [thread overview]
Message-ID: <aa6e6832-6bbc-87d7-9937-b18aec83a2ff@baylibre.com> (raw)
In-Reply-To: <20190525181133.4875-10-martin.blumenstingl@googlemail.com>
On 25/05/2019 20:11, Martin Blumenstingl wrote:
> All existing PWM drivers (except pwm-meson and two other ones) call
> pwm_set_chip_data() from their pwm_ops.request() callback. Now that we
> can access the struct meson_pwm_channel from struct meson_pwm we can do
> the same.
>
> Move the call to pwm_set_chip_data() to meson_pwm_request() and drop the
> custom meson_pwm_add_channels(). This makes the implementation
> consistent with other drivers and makes it slightly more obvious
> thatpwm_get_chip_data() cannot be used from pwm_ops.get_state() (because
> that's called by the PWM core before pwm_ops.request()).
>
> No functional changes intended.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> drivers/pwm/pwm-meson.c | 22 ++++++++--------------
> 1 file changed, 8 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c
> index ac7e188155fd..27915d6475e3 100644
> --- a/drivers/pwm/pwm-meson.c
> +++ b/drivers/pwm/pwm-meson.c
> @@ -98,12 +98,16 @@ static inline struct meson_pwm *to_meson_pwm(struct pwm_chip *chip)
>
> static int meson_pwm_request(struct pwm_chip *chip, struct pwm_device *pwm)
> {
> - struct meson_pwm_channel *channel = pwm_get_chip_data(pwm);
> + struct meson_pwm *meson = to_meson_pwm(chip);
> + struct meson_pwm_channel *channel;
> struct device *dev = chip->dev;
> int err;
>
> - if (!channel)
> - return -ENODEV;
> + channel = pwm_get_chip_data(pwm);
> + if (channel)
> + return 0;
> +
> + channel = &meson->channels[pwm->hwpwm];
>
> if (channel->clk_parent) {
> err = clk_set_parent(channel->clk, channel->clk_parent);
> @@ -124,7 +128,7 @@ static int meson_pwm_request(struct pwm_chip *chip, struct pwm_device *pwm)
>
> chip->ops->get_state(chip, pwm, &channel->state);
>
> - return 0;
> + return pwm_set_chip_data(pwm, channel);
> }
>
> static void meson_pwm_free(struct pwm_chip *chip, struct pwm_device *pwm)
> @@ -460,14 +464,6 @@ static int meson_pwm_init_channels(struct meson_pwm *meson)
> return 0;
> }
>
> -static void meson_pwm_add_channels(struct meson_pwm *meson)
> -{
> - unsigned int i;
> -
> - for (i = 0; i < meson->chip.npwm; i++)
> - pwm_set_chip_data(&meson->chip.pwms[i], &meson->channels[i]);
> -}
> -
> static int meson_pwm_probe(struct platform_device *pdev)
> {
> struct meson_pwm *meson;
> @@ -503,8 +499,6 @@ static int meson_pwm_probe(struct platform_device *pdev)
> return err;
> }
>
> - meson_pwm_add_channels(meson);
> -
> platform_set_drvdata(pdev, meson);
>
> return 0;
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org, linux-pwm@vger.kernel.org,
thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 09/14] pwm: meson: move pwm_set_chip_data() to meson_pwm_request()
Date: Mon, 27 May 2019 14:30:37 +0200 [thread overview]
Message-ID: <aa6e6832-6bbc-87d7-9937-b18aec83a2ff@baylibre.com> (raw)
In-Reply-To: <20190525181133.4875-10-martin.blumenstingl@googlemail.com>
On 25/05/2019 20:11, Martin Blumenstingl wrote:
> All existing PWM drivers (except pwm-meson and two other ones) call
> pwm_set_chip_data() from their pwm_ops.request() callback. Now that we
> can access the struct meson_pwm_channel from struct meson_pwm we can do
> the same.
>
> Move the call to pwm_set_chip_data() to meson_pwm_request() and drop the
> custom meson_pwm_add_channels(). This makes the implementation
> consistent with other drivers and makes it slightly more obvious
> thatpwm_get_chip_data() cannot be used from pwm_ops.get_state() (because
> that's called by the PWM core before pwm_ops.request()).
>
> No functional changes intended.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> drivers/pwm/pwm-meson.c | 22 ++++++++--------------
> 1 file changed, 8 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c
> index ac7e188155fd..27915d6475e3 100644
> --- a/drivers/pwm/pwm-meson.c
> +++ b/drivers/pwm/pwm-meson.c
> @@ -98,12 +98,16 @@ static inline struct meson_pwm *to_meson_pwm(struct pwm_chip *chip)
>
> static int meson_pwm_request(struct pwm_chip *chip, struct pwm_device *pwm)
> {
> - struct meson_pwm_channel *channel = pwm_get_chip_data(pwm);
> + struct meson_pwm *meson = to_meson_pwm(chip);
> + struct meson_pwm_channel *channel;
> struct device *dev = chip->dev;
> int err;
>
> - if (!channel)
> - return -ENODEV;
> + channel = pwm_get_chip_data(pwm);
> + if (channel)
> + return 0;
> +
> + channel = &meson->channels[pwm->hwpwm];
>
> if (channel->clk_parent) {
> err = clk_set_parent(channel->clk, channel->clk_parent);
> @@ -124,7 +128,7 @@ static int meson_pwm_request(struct pwm_chip *chip, struct pwm_device *pwm)
>
> chip->ops->get_state(chip, pwm, &channel->state);
>
> - return 0;
> + return pwm_set_chip_data(pwm, channel);
> }
>
> static void meson_pwm_free(struct pwm_chip *chip, struct pwm_device *pwm)
> @@ -460,14 +464,6 @@ static int meson_pwm_init_channels(struct meson_pwm *meson)
> return 0;
> }
>
> -static void meson_pwm_add_channels(struct meson_pwm *meson)
> -{
> - unsigned int i;
> -
> - for (i = 0; i < meson->chip.npwm; i++)
> - pwm_set_chip_data(&meson->chip.pwms[i], &meson->channels[i]);
> -}
> -
> static int meson_pwm_probe(struct platform_device *pdev)
> {
> struct meson_pwm *meson;
> @@ -503,8 +499,6 @@ static int meson_pwm_probe(struct platform_device *pdev)
> return err;
> }
>
> - meson_pwm_add_channels(meson);
> -
> platform_set_drvdata(pdev, meson);
>
> return 0;
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org, linux-pwm@vger.kernel.org,
thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 09/14] pwm: meson: move pwm_set_chip_data() to meson_pwm_request()
Date: Mon, 27 May 2019 14:30:37 +0200 [thread overview]
Message-ID: <aa6e6832-6bbc-87d7-9937-b18aec83a2ff@baylibre.com> (raw)
In-Reply-To: <20190525181133.4875-10-martin.blumenstingl@googlemail.com>
On 25/05/2019 20:11, Martin Blumenstingl wrote:
> All existing PWM drivers (except pwm-meson and two other ones) call
> pwm_set_chip_data() from their pwm_ops.request() callback. Now that we
> can access the struct meson_pwm_channel from struct meson_pwm we can do
> the same.
>
> Move the call to pwm_set_chip_data() to meson_pwm_request() and drop the
> custom meson_pwm_add_channels(). This makes the implementation
> consistent with other drivers and makes it slightly more obvious
> thatpwm_get_chip_data() cannot be used from pwm_ops.get_state() (because
> that's called by the PWM core before pwm_ops.request()).
>
> No functional changes intended.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> drivers/pwm/pwm-meson.c | 22 ++++++++--------------
> 1 file changed, 8 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c
> index ac7e188155fd..27915d6475e3 100644
> --- a/drivers/pwm/pwm-meson.c
> +++ b/drivers/pwm/pwm-meson.c
> @@ -98,12 +98,16 @@ static inline struct meson_pwm *to_meson_pwm(struct pwm_chip *chip)
>
> static int meson_pwm_request(struct pwm_chip *chip, struct pwm_device *pwm)
> {
> - struct meson_pwm_channel *channel = pwm_get_chip_data(pwm);
> + struct meson_pwm *meson = to_meson_pwm(chip);
> + struct meson_pwm_channel *channel;
> struct device *dev = chip->dev;
> int err;
>
> - if (!channel)
> - return -ENODEV;
> + channel = pwm_get_chip_data(pwm);
> + if (channel)
> + return 0;
> +
> + channel = &meson->channels[pwm->hwpwm];
>
> if (channel->clk_parent) {
> err = clk_set_parent(channel->clk, channel->clk_parent);
> @@ -124,7 +128,7 @@ static int meson_pwm_request(struct pwm_chip *chip, struct pwm_device *pwm)
>
> chip->ops->get_state(chip, pwm, &channel->state);
>
> - return 0;
> + return pwm_set_chip_data(pwm, channel);
> }
>
> static void meson_pwm_free(struct pwm_chip *chip, struct pwm_device *pwm)
> @@ -460,14 +464,6 @@ static int meson_pwm_init_channels(struct meson_pwm *meson)
> return 0;
> }
>
> -static void meson_pwm_add_channels(struct meson_pwm *meson)
> -{
> - unsigned int i;
> -
> - for (i = 0; i < meson->chip.npwm; i++)
> - pwm_set_chip_data(&meson->chip.pwms[i], &meson->channels[i]);
> -}
> -
> static int meson_pwm_probe(struct platform_device *pdev)
> {
> struct meson_pwm *meson;
> @@ -503,8 +499,6 @@ static int meson_pwm_probe(struct platform_device *pdev)
> return err;
> }
>
> - meson_pwm_add_channels(meson);
> -
> platform_set_drvdata(pdev, meson);
>
> return 0;
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-05-27 12:30 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-25 18:11 [PATCH 00/14] pwm-meson: cleanups and improvements Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-25 18:11 ` [PATCH 01/14] pwm: meson: unify the parameter list of meson_pwm_{enable,disable} Martin Blumenstingl
2019-05-25 18:11 ` [PATCH 01/14] pwm: meson: unify the parameter list of meson_pwm_{enable, disable} Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-27 12:25 ` Neil Armstrong
2019-05-27 12:25 ` Neil Armstrong
2019-05-27 12:25 ` Neil Armstrong
2019-05-25 18:11 ` [PATCH 02/14] pwm: meson: use devm_clk_get_optional() to get the input clock Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-27 12:25 ` Neil Armstrong
2019-05-27 12:25 ` Neil Armstrong
2019-05-27 12:25 ` Neil Armstrong
2019-05-25 18:11 ` [PATCH 03/14] pwm: meson: use GENMASK and FIELD_PREP for the lo and hi values Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-27 12:25 ` Neil Armstrong
2019-05-27 12:25 ` Neil Armstrong
2019-05-27 12:25 ` Neil Armstrong
2019-05-25 18:11 ` [PATCH 04/14] pwm: meson: change MISC_CLK_SEL_WIDTH to MISC_CLK_SEL_MASK Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-27 12:26 ` Neil Armstrong
2019-05-27 12:26 ` Neil Armstrong
2019-05-27 12:26 ` Neil Armstrong
2019-05-27 17:46 ` Martin Blumenstingl
2019-05-27 17:46 ` Martin Blumenstingl
2019-05-27 17:46 ` Martin Blumenstingl
2019-05-27 18:00 ` Uwe Kleine-König
2019-05-27 18:00 ` Uwe Kleine-König
2019-05-27 18:00 ` Uwe Kleine-König
2019-05-28 18:04 ` Martin Blumenstingl
2019-05-28 18:04 ` Martin Blumenstingl
2019-05-28 18:04 ` Martin Blumenstingl
2019-05-25 18:11 ` [PATCH 05/14] pwm: meson: don't duplicate the polarity internally Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-27 12:26 ` Neil Armstrong
2019-05-27 12:26 ` Neil Armstrong
2019-05-27 12:26 ` Neil Armstrong
2019-05-25 18:11 ` [PATCH 06/14] pwm: meson: pass struct pwm_device to meson_pwm_calc() Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-27 12:27 ` Neil Armstrong
2019-05-27 12:27 ` Neil Armstrong
2019-05-27 12:27 ` Neil Armstrong
2019-05-25 18:11 ` [PATCH 07/14] pwm: meson: add the meson_pwm_channel data to struct meson_pwm Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-27 12:27 ` Neil Armstrong
2019-05-27 12:27 ` Neil Armstrong
2019-05-27 12:27 ` Neil Armstrong
2019-05-27 17:52 ` Martin Blumenstingl
2019-05-27 17:52 ` Martin Blumenstingl
2019-05-27 17:52 ` Martin Blumenstingl
2019-05-25 18:11 ` [PATCH 08/14] pwm: meson: add the per-channel register offsets and bits in a struct Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-27 12:28 ` Neil Armstrong
2019-05-27 12:28 ` Neil Armstrong
2019-05-27 12:28 ` Neil Armstrong
2019-05-27 17:57 ` Martin Blumenstingl
2019-05-27 17:57 ` Martin Blumenstingl
2019-05-27 17:57 ` Martin Blumenstingl
2019-05-28 8:11 ` Neil Armstrong
2019-05-28 8:11 ` Neil Armstrong
2019-05-28 8:11 ` Neil Armstrong
2019-05-25 18:11 ` [PATCH 09/14] pwm: meson: move pwm_set_chip_data() to meson_pwm_request() Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-27 12:30 ` Neil Armstrong [this message]
2019-05-27 12:30 ` Neil Armstrong
2019-05-27 12:30 ` Neil Armstrong
2019-05-25 18:11 ` [PATCH 10/14] pwm: meson: simplify the calculation of the pre-divider and count Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-26 19:41 ` Uwe Kleine-König
2019-05-26 19:41 ` Uwe Kleine-König
2019-05-26 19:41 ` Uwe Kleine-König
2019-05-26 19:41 ` Uwe Kleine-König
2019-05-27 12:37 ` Neil Armstrong
2019-05-27 12:37 ` Neil Armstrong
2019-05-27 12:37 ` Neil Armstrong
2019-05-25 18:11 ` [PATCH 11/14] pwm: meson: read the full hardware state in meson_pwm_get_state() Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-27 12:31 ` Neil Armstrong
2019-05-27 12:31 ` Neil Armstrong
2019-05-27 12:31 ` Neil Armstrong
2019-05-25 18:11 ` [PATCH 12/14] pwm: meson: don't cache struct pwm_state internally Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-27 12:31 ` Neil Armstrong
2019-05-27 12:31 ` Neil Armstrong
2019-05-27 12:31 ` Neil Armstrong
2019-05-25 18:11 ` [PATCH 13/14] pwm: meson: add support PWM_POLARITY_INVERSED when disabling Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-27 12:33 ` Neil Armstrong
2019-05-27 12:33 ` Neil Armstrong
2019-05-27 12:33 ` Neil Armstrong
2019-05-27 17:50 ` Martin Blumenstingl
2019-05-27 17:50 ` Martin Blumenstingl
2019-05-27 17:50 ` Martin Blumenstingl
2019-05-25 18:11 ` [PATCH 14/14] pwm: meson: add documentation to the driver Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-25 18:11 ` Martin Blumenstingl
2019-05-27 12:33 ` Neil Armstrong
2019-05-27 12:33 ` Neil Armstrong
2019-05-27 12:33 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa6e6832-6bbc-87d7-9937-b18aec83a2ff@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.