From: Jens Axboe <axboe@kernel.dk>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: linux-block@vger.kernel.org, Zdenek Kabelac <zkabelac@redhat.com>,
Mike Snitzer <msnitzer@redhat.com>,
dm-devel@redhat.com
Subject: Re: [PATCH] block: fix infinite loop if the device loses discard capability
Date: Fri, 6 Jul 2018 07:50:56 -0600 [thread overview]
Message-ID: <aaa019b2-1994-789c-3faa-c38a5b4c86d4@kernel.dk> (raw)
In-Reply-To: <alpine.LRH.2.02.1807031332250.22443@file01.intranet.prod.int.rdu2.redhat.com>
On 7/3/18 11:34 AM, Mikulas Patocka wrote:
> If __blkdev_issue_discard is in progress and a device mapper device is
> reloaded with a table that doesn't support discard,
> q->limits.max_discard_sectors is set to zero. This results in infinite
> loop in __blkdev_issue_discard.
>
> This patch checks if max_discard_sectors is zero and aborts with
> -EOPNOTSUPP.
Applied, thanks.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: linux-block@vger.kernel.org, Mike Snitzer <msnitzer@redhat.com>,
dm-devel@redhat.com, Zdenek Kabelac <zkabelac@redhat.com>
Subject: Re: [PATCH] block: fix infinite loop if the device loses discard capability
Date: Fri, 6 Jul 2018 07:50:56 -0600 [thread overview]
Message-ID: <aaa019b2-1994-789c-3faa-c38a5b4c86d4@kernel.dk> (raw)
In-Reply-To: <alpine.LRH.2.02.1807031332250.22443@file01.intranet.prod.int.rdu2.redhat.com>
On 7/3/18 11:34 AM, Mikulas Patocka wrote:
> If __blkdev_issue_discard is in progress and a device mapper device is
> reloaded with a table that doesn't support discard,
> q->limits.max_discard_sectors is set to zero. This results in infinite
> loop in __blkdev_issue_discard.
>
> This patch checks if max_discard_sectors is zero and aborts with
> -EOPNOTSUPP.
Applied, thanks.
--
Jens Axboe
next prev parent reply other threads:[~2018-07-06 13:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 17:34 [PATCH] block: fix infinite loop if the device loses discard capability Mikulas Patocka
2018-07-03 17:34 ` Mikulas Patocka
2018-07-06 13:50 ` Jens Axboe [this message]
2018-07-06 13:50 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaa019b2-1994-789c-3faa-c38a5b4c86d4@kernel.dk \
--to=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=msnitzer@redhat.com \
--cc=zkabelac@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.