From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Mike Christie <michael.christie@oracle.com>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"hch@lst.de" <hch@lst.de>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"james.bottomley@hansenpartnership.com"
<james.bottomley@hansenpartnership.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
"snitzer@kernel.org" <snitzer@kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>
Subject: Re: [PATCH v4 01/18] block: Add PR callouts for read keys and reservation
Date: Mon, 6 Mar 2023 05:03:29 +0000 [thread overview]
Message-ID: <ab2910d4-ce73-340a-458d-1c9644d1c292@nvidia.com> (raw)
In-Reply-To: <20230224174502.321490-2-michael.christie@oracle.com>
On 2/24/2023 9:44 AM, Mike Christie wrote:
> Add callouts for reading keys and reservations. This allows LIO to support
> the READ_KEYS and READ_RESERVATION commands and will allow dm-multipath
> to optimize it's error handling so it can check if it's getting an error
> because there's an existing reservation or if we need to retry different
> paths.
>
> Note: This only initially adds the struct definitions in the kernel as I'm
> not sure if we wanted to export the interface to userspace yet. read_keys
> and read_reservation are exactly what dm-multipath and LIO need, but for a
> userspace interface we may want something like SCSI's READ_FULL_STATUS and
> NVMe's report reservation commands. Those are overkill for dm/LIO and
> READ_FULL_STATUS is sometimes broken for SCSI devices.
>
> Signed-off-by: Mike Christie <michael.christie@oracle.com>
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
WARNING: multiple messages have this Message-ID (diff)
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Mike Christie <michael.christie@oracle.com>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"hch@lst.de" <hch@lst.de>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"james.bottomley@hansenpartnership.com"
<james.bottomley@hansenpartnership.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
"snitzer@kernel.org" <snitzer@kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>
Subject: Re: [dm-devel] [PATCH v4 01/18] block: Add PR callouts for read keys and reservation
Date: Mon, 6 Mar 2023 05:03:29 +0000 [thread overview]
Message-ID: <ab2910d4-ce73-340a-458d-1c9644d1c292@nvidia.com> (raw)
In-Reply-To: <20230224174502.321490-2-michael.christie@oracle.com>
On 2/24/2023 9:44 AM, Mike Christie wrote:
> Add callouts for reading keys and reservations. This allows LIO to support
> the READ_KEYS and READ_RESERVATION commands and will allow dm-multipath
> to optimize it's error handling so it can check if it's getting an error
> because there's an existing reservation or if we need to retry different
> paths.
>
> Note: This only initially adds the struct definitions in the kernel as I'm
> not sure if we wanted to export the interface to userspace yet. read_keys
> and read_reservation are exactly what dm-multipath and LIO need, but for a
> userspace interface we may want something like SCSI's READ_FULL_STATUS and
> NVMe's report reservation commands. Those are overkill for dm/LIO and
> READ_FULL_STATUS is sometimes broken for SCSI devices.
>
> Signed-off-by: Mike Christie <michael.christie@oracle.com>
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2023-03-06 5:03 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 17:44 [PATCH v4 01/18] Use block pr_ops in LIO Mike Christie
2023-02-24 17:44 ` [dm-devel] " Mike Christie
2023-02-24 17:44 ` [PATCH v4 01/18] block: Add PR callouts for read keys and reservation Mike Christie
2023-02-24 17:44 ` [dm-devel] " Mike Christie
2023-03-06 5:03 ` Chaitanya Kulkarni [this message]
2023-03-06 5:03 ` Chaitanya Kulkarni
2023-03-14 17:10 ` Christoph Hellwig
2023-03-14 17:10 ` [dm-devel] " Christoph Hellwig
2023-02-24 17:44 ` [PATCH v4 02/18] block: Rename BLK_STS_NEXUS to BLK_STS_RESV_CONFLICT Mike Christie
2023-02-24 17:44 ` [dm-devel] " Mike Christie
2023-03-14 17:11 ` Christoph Hellwig
2023-03-14 17:11 ` [dm-devel] " Christoph Hellwig
2023-03-15 10:04 ` Stefan Haberland
2023-03-15 10:04 ` [dm-devel] " Stefan Haberland
2023-03-15 13:30 ` Christoph Hellwig
2023-03-15 13:30 ` [dm-devel] " Christoph Hellwig
2023-03-16 10:17 ` Stefan Haberland
2023-03-16 10:17 ` [dm-devel] " Stefan Haberland
2023-03-16 16:36 ` Mike Christie
2023-03-16 16:36 ` [dm-devel] " Mike Christie
2023-03-20 13:06 ` Christoph Hellwig
2023-03-20 13:06 ` [dm-devel] " Christoph Hellwig
2023-03-20 16:39 ` Mike Christie
2023-03-20 16:39 ` [dm-devel] " Mike Christie
2023-02-24 17:44 ` [PATCH v4 03/18] scsi: Rename sd_pr_command Mike Christie
2023-02-24 17:44 ` [dm-devel] " Mike Christie
2023-02-24 17:44 ` [PATCH v4 04/18] scsi: Move sd_pr_type to header to share Mike Christie
2023-02-24 17:44 ` [dm-devel] " Mike Christie
2023-03-06 5:06 ` Chaitanya Kulkarni
2023-03-06 5:06 ` [dm-devel] " Chaitanya Kulkarni
2023-02-24 17:44 ` [PATCH v4 05/18] scsi: Add support for block PR read keys/reservation Mike Christie
2023-02-24 17:44 ` [dm-devel] " Mike Christie
2023-03-06 5:08 ` Chaitanya Kulkarni
2023-03-06 5:08 ` [dm-devel] " Chaitanya Kulkarni
2023-03-14 17:11 ` Christoph Hellwig
2023-03-14 17:11 ` [dm-devel] " Christoph Hellwig
2023-02-24 17:44 ` [PATCH v4 06/18] dm: " Mike Christie
2023-02-24 17:44 ` [dm-devel] " Mike Christie
2023-02-24 17:44 ` [PATCH v4 07/18] nvme: Fix reservation status related structs Mike Christie
2023-02-24 17:44 ` [dm-devel] " Mike Christie
2023-03-05 21:26 ` Chaitanya Kulkarni
2023-03-05 21:26 ` [dm-devel] " Chaitanya Kulkarni
2023-03-14 17:12 ` Christoph Hellwig
2023-03-14 17:12 ` [dm-devel] " Christoph Hellwig
2023-03-14 17:15 ` Christoph Hellwig
2023-03-14 17:15 ` [dm-devel] " Christoph Hellwig
2023-03-14 22:23 ` Mike Christie
2023-03-14 22:23 ` [dm-devel] " Mike Christie
2023-03-15 5:40 ` Christoph Hellwig
2023-03-15 5:40 ` [dm-devel] " Christoph Hellwig
2023-03-20 17:08 ` Mike Christie
2023-03-20 17:08 ` [dm-devel] " Mike Christie
2023-02-24 17:44 ` [PATCH v4 08/18] nvme: Don't hardcode the data len for pr commands Mike Christie
2023-02-24 17:44 ` [dm-devel] " Mike Christie
2023-02-24 17:44 ` [PATCH v4 09/18] nvme: Move pr code to it's own file Mike Christie
2023-02-24 17:44 ` [dm-devel] " Mike Christie
2023-03-14 17:13 ` Christoph Hellwig
2023-03-14 17:13 ` [dm-devel] " Christoph Hellwig
2023-03-14 17:30 ` Keith Busch
2023-03-14 17:30 ` [dm-devel] " Keith Busch
2023-02-24 17:44 ` [PATCH v4 10/18] nvme: Add helper to send pr command Mike Christie
2023-02-24 17:44 ` [dm-devel] " Mike Christie
2023-03-05 21:28 ` Chaitanya Kulkarni
2023-03-05 21:28 ` [dm-devel] " Chaitanya Kulkarni
2023-03-06 17:25 ` Mike Christie
2023-03-06 17:25 ` [dm-devel] " Mike Christie
2023-03-14 17:13 ` Christoph Hellwig
2023-03-14 17:13 ` [dm-devel] " Christoph Hellwig
2023-02-24 17:44 ` [PATCH v4 11/18] nvme: Add pr_ops read_keys support Mike Christie
2023-02-24 17:44 ` [dm-devel] " Mike Christie
2023-03-14 17:16 ` Christoph Hellwig
2023-03-14 17:16 ` [dm-devel] " Christoph Hellwig
2023-02-24 17:44 ` [PATCH v4 12/18] nvme: Add a nvme_pr_type enum Mike Christie
2023-02-24 17:44 ` [dm-devel] " Mike Christie
2023-03-05 21:30 ` Chaitanya Kulkarni
2023-03-05 21:30 ` [dm-devel] " Chaitanya Kulkarni
2023-03-14 17:17 ` Christoph Hellwig
2023-03-14 17:17 ` [dm-devel] " Christoph Hellwig
2023-02-24 17:44 ` [PATCH v4 13/18] nvme: Add pr_ops read_reservation support Mike Christie
2023-02-24 17:44 ` [dm-devel] " Mike Christie
2023-02-24 21:04 ` kernel test robot
2023-02-24 21:04 ` [dm-devel] " kernel test robot
2023-03-06 17:25 ` Mike Christie
2023-03-06 17:25 ` [dm-devel] " Mike Christie
2023-03-05 21:32 ` Chaitanya Kulkarni
2023-03-05 21:32 ` [dm-devel] " Chaitanya Kulkarni
2023-03-14 17:21 ` Christoph Hellwig
2023-03-14 17:21 ` [dm-devel] " Christoph Hellwig
2023-02-24 17:44 ` [PATCH v4 14/18] scsi: target: Rename sbc_ops to exec_cmd_ops Mike Christie
2023-02-24 17:44 ` [dm-devel] " Mike Christie
2023-02-24 17:44 ` [PATCH v4 15/18] scsi: target: Allow backends to hook into PR handling Mike Christie
2023-02-24 17:44 ` [dm-devel] " Mike Christie
2023-02-24 17:45 ` [PATCH v4 16/18] scsi: target: Pass struct target_opcode_descriptor to enabled Mike Christie
2023-02-24 17:45 ` [dm-devel] " Mike Christie
2023-02-24 17:45 ` [PATCH v4 17/18] scsi: target: Report and detect unsupported PR commands Mike Christie
2023-02-24 17:45 ` [dm-devel] " Mike Christie
2023-02-24 17:45 ` [PATCH v4 18/18] scsi: target: Add block PR support to iblock Mike Christie
2023-02-24 17:45 ` [dm-devel] " Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab2910d4-ce73-340a-458d-1c9644d1c292@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=snitzer@kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.