From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-integrity@vger.kernel.org
Cc: Mimi Zohar <zohar@linux.ibm.com>,
David Woodhouse <dwmw2@infradead.org>,
keyrings@vger.kernel.org
Subject: Re: [PATCH v4 4/9] security: keys: trusted: use ASN.1 tpm2 key format for the blobs
Date: Mon, 06 Jan 2020 21:53:23 +0000 [thread overview]
Message-ID: <abc1b20bf3170eeed11922f5678608a6357160f1.camel@linux.intel.com> (raw)
In-Reply-To: <20191230173802.8731-5-James.Bottomley@HansenPartnership.com>
On Mon, 2019-12-30 at 09:37 -0800, James Bottomley wrote:
Again bad formatting in the short summary.
> Modify the tpm2 key format blob output to export and import in the
> ASN.1 form for tpm2 sealed object keys. For compatibility with prior
> trusted keys, the importer will also accept two tpm2b quantities
> representing the public and private parts of the key. However, the
> export via keyctl pipe will only output the ASN.1 format.
I think this is fair enough when it comes to backwards compatibility.
What you should do with the earlier patch is to document in the commit
message this framework for backwards compatibility. It is redundancy
but makes the commit log easier to follow. E.g. tell in that commit
message that ASN.1 loader will handle loading old blobs.
> The benefit of the ASN.1 format is that it's a standard and thus the
> exported key can be used by userspace tools. The format includes
> policy specifications, thus it gets us out of having to construct
> policy handles in userspace and the format includes the parent meaning
> you don't have to keep passing it in each time.
Please be explicit with the tools you are referring. Point out what
you are using if there is variable number of choices.
In high-level the code change itself looks good.
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-integrity@vger.kernel.org
Cc: Mimi Zohar <zohar@linux.ibm.com>,
David Woodhouse <dwmw2@infradead.org>,
keyrings@vger.kernel.org
Subject: Re: [PATCH v4 4/9] security: keys: trusted: use ASN.1 tpm2 key format for the blobs
Date: Mon, 06 Jan 2020 23:53:23 +0200 [thread overview]
Message-ID: <abc1b20bf3170eeed11922f5678608a6357160f1.camel@linux.intel.com> (raw)
In-Reply-To: <20191230173802.8731-5-James.Bottomley@HansenPartnership.com>
On Mon, 2019-12-30 at 09:37 -0800, James Bottomley wrote:
Again bad formatting in the short summary.
> Modify the tpm2 key format blob output to export and import in the
> ASN.1 form for tpm2 sealed object keys. For compatibility with prior
> trusted keys, the importer will also accept two tpm2b quantities
> representing the public and private parts of the key. However, the
> export via keyctl pipe will only output the ASN.1 format.
I think this is fair enough when it comes to backwards compatibility.
What you should do with the earlier patch is to document in the commit
message this framework for backwards compatibility. It is redundancy
but makes the commit log easier to follow. E.g. tell in that commit
message that ASN.1 loader will handle loading old blobs.
> The benefit of the ASN.1 format is that it's a standard and thus the
> exported key can be used by userspace tools. The format includes
> policy specifications, thus it gets us out of having to construct
> policy handles in userspace and the format includes the parent meaning
> you don't have to keep passing it in each time.
Please be explicit with the tools you are referring. Point out what
you are using if there is variable number of choices.
In high-level the code change itself looks good.
/Jarkko
next prev parent reply other threads:[~2020-01-06 21:53 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 17:37 [PATCH v4 0/9] TPM 2.0 trusted keys with attached policy James Bottomley
2019-12-30 17:37 ` James Bottomley
2019-12-30 17:37 ` [PATCH v4 1/9] lib: add asn.1 encoder James Bottomley
2019-12-30 17:37 ` James Bottomley
2020-01-06 18:09 ` Jarkko Sakkinen
2020-01-06 18:09 ` Jarkko Sakkinen
2020-01-07 0:17 ` James Bottomley
2020-01-07 0:17 ` James Bottomley
2019-12-30 17:37 ` [PATCH v4 2/9] oid_registry: Add TCG defined OIDS for TPM keys James Bottomley
2019-12-30 17:37 ` James Bottomley
2019-12-30 17:37 ` [PATCH v4 3/9] security: keys: trusted fix tpm2 authorizations James Bottomley
2019-12-30 17:37 ` James Bottomley
2020-01-06 21:45 ` Jarkko Sakkinen
2020-01-06 21:45 ` Jarkko Sakkinen
2020-01-06 21:48 ` Jarkko Sakkinen
2020-01-06 21:48 ` Jarkko Sakkinen
2020-01-07 1:08 ` James Bottomley
2020-01-07 1:08 ` James Bottomley
2020-01-08 16:19 ` Jarkko Sakkinen
2020-01-08 16:19 ` Jarkko Sakkinen
2019-12-30 17:37 ` [PATCH v4 4/9] security: keys: trusted: use ASN.1 tpm2 key format for the blobs James Bottomley
2019-12-30 17:37 ` James Bottomley
2020-01-06 21:53 ` Jarkko Sakkinen [this message]
2020-01-06 21:53 ` Jarkko Sakkinen
2019-12-30 17:37 ` [PATCH v4 5/9] security: keys: trusted: Make sealed key properly interoperable James Bottomley
2019-12-30 17:37 ` James Bottomley
2020-01-06 21:58 ` Jarkko Sakkinen
2020-01-06 21:58 ` Jarkko Sakkinen
2019-12-30 17:37 ` [PATCH v4 6/9] security: keys: trusted: add PCR policy to TPM2 keys James Bottomley
2019-12-30 17:37 ` James Bottomley
2019-12-30 17:38 ` [PATCH v4 7/9] security: keys: trusted: add ability to specify arbitrary policy James Bottomley
2019-12-30 17:38 ` James Bottomley
2019-12-30 17:38 ` [PATCH v4 8/9] security: keys: trusted: implement counter/timer policy James Bottomley
2019-12-30 17:38 ` James Bottomley
2019-12-30 17:38 ` [PATCH v4 9/9] security: keys: trusted: add password based authorizations to policy keys James Bottomley
2019-12-30 17:38 ` James Bottomley
2019-12-31 16:05 ` [PATCH v4 0/9] TPM 2.0 trusted keys with attached policy Jarkko Sakkinen
2019-12-31 16:05 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abc1b20bf3170eeed11922f5678608a6357160f1.camel@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dwmw2@infradead.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.