From: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> To: Andrea Righi <righi.andrea-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, "Nicholas A. Bellinger" <nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org> Cc: Robert LeBlanc <robert-4JaGZRWAfWbajFs6igw21g@public.gmane.org>, Sean Jenkins <sean-v0B6Y9onFlloq1w47eu9iAC/G2K4zDHf@public.gmane.org>, Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, target-devel <target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, lkml <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> Subject: Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done() Date: Thu, 29 Jun 2017 08:36:51 +0300 [thread overview] Message-ID: <ac404f71-3f34-af4c-b7b2-2b19ae768f47@grimberg.me> (raw) In-Reply-To: <20170628175354.GB1769@Dell> > Just tested this patch, I wasn't able to reproduce the NULL pointer > dereference or any other bugs, so this fix seems safe enough to me. > > Tested-by: Andrea Righi <righi.andrea-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Can you test just the one liner fix below? >> @@ -1452,7 +1452,7 @@ >> isert_login_recv_done(struct ib_cq *cq, struct ib_wc *wc) >> { >> struct isert_conn *isert_conn = wc->qp->qp_context; >> - struct ib_device *ib_dev = isert_conn->cm_id->device; >> + struct ib_device *ib_dev = isert_conn->device->ib_device; >> >> if (unlikely(wc->status != IB_WC_SUCCESS)) { >> isert_print_wc(wc, "login recv"); -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Sagi Grimberg <sagi@grimberg.me> To: Andrea Righi <righi.andrea@gmail.com>, "Nicholas A. Bellinger" <nab@linux-iscsi.org> Cc: Robert LeBlanc <robert@leblancnet.us>, Sean Jenkins <sean@betterservers.com>, Doug Ledford <dledford@redhat.com>, Sean Hefty <sean.hefty@intel.com>, Hal Rosenstock <hal.rosenstock@gmail.com>, linux-rdma <linux-rdma@vger.kernel.org>, target-devel <target-devel@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>, Christoph Hellwig <hch@lst.de> Subject: Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done() Date: Thu, 29 Jun 2017 08:36:51 +0300 [thread overview] Message-ID: <ac404f71-3f34-af4c-b7b2-2b19ae768f47@grimberg.me> (raw) In-Reply-To: <20170628175354.GB1769@Dell> > Just tested this patch, I wasn't able to reproduce the NULL pointer > dereference or any other bugs, so this fix seems safe enough to me. > > Tested-by: Andrea Righi <righi.andrea@gmail.com> Can you test just the one liner fix below? >> @@ -1452,7 +1452,7 @@ >> isert_login_recv_done(struct ib_cq *cq, struct ib_wc *wc) >> { >> struct isert_conn *isert_conn = wc->qp->qp_context; >> - struct ib_device *ib_dev = isert_conn->cm_id->device; >> + struct ib_device *ib_dev = isert_conn->device->ib_device; >> >> if (unlikely(wc->status != IB_WC_SUCCESS)) { >> isert_print_wc(wc, "login recv");
next prev parent reply other threads:[~2017-06-29 5:36 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-20 18:54 NULL pointer dereference in isert_login_recv_done in 4.9.32 Robert LeBlanc 2017-06-21 15:17 ` Robert LeBlanc [not found] ` <CAANLjFp6Y8wvLvmWrk1ECjm-OoyEppxD1svNYKpg+HDEZevJig-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-06-21 16:33 ` Robert LeBlanc [not found] ` <CAANLjFoQcmfkjq9N1fehTC9Zi6aOC7ArOEPXz-he3EnOvWeEDw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-06-21 22:48 ` Robert LeBlanc 2017-06-22 22:37 ` [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done() (was: Re: NULL pointer dereference in isert_login_recv_done in 4.9.32) Andrea Righi 2017-06-25 23:58 ` Nicholas A. Bellinger 2017-06-27 7:03 ` [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done() Sagi Grimberg 2017-06-28 17:53 ` [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done() (was: Re: NULL pointer dereference in isert_login_recv_done in 4.9.32) Andrea Righi 2017-06-29 5:36 ` Sagi Grimberg [this message] 2017-06-29 5:36 ` [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done() Sagi Grimberg 2017-06-29 8:20 ` Andrea Righi 2017-06-29 8:28 ` Sagi Grimberg 2017-06-29 8:28 ` Sagi Grimberg [not found] ` <7f1b1f07-0670-10ee-620d-0ab3b1a6c2bf-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> 2017-06-30 5:53 ` Nicholas A. Bellinger 2017-06-30 5:53 ` Nicholas A. Bellinger 2017-06-26 8:53 ` [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done() (was: Re: NULL pointer dereference in isert_login_recv_done in 4.9.32) Leon Romanovsky 2017-06-26 8:53 ` Leon Romanovsky
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ac404f71-3f34-af4c-b7b2-2b19ae768f47@grimberg.me \ --to=sagi-nqwnxtmzq1alnmji0ikvqw@public.gmane.org \ --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \ --cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=hch-jcswGhMUV9g@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org \ --cc=righi.andrea-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=robert-4JaGZRWAfWbajFs6igw21g@public.gmane.org \ --cc=sean-v0B6Y9onFlloq1w47eu9iAC/G2K4zDHf@public.gmane.org \ --cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \ --cc=target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.