From: Keerthy <j-keerthy@ti.com> To: Tony Lindgren <tony@atomide.com> Cc: <alexandre.belloni@bootlin.com>, <a.zummo@towertech.it>, <t-kristo@ti.com>, <ssantosh@kernel.org>, <d-gerlach@ti.com>, <linux-omap@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-rtc@vger.kernel.org> Subject: Re: [PATCH v3 0/4] AM437x: Add rtc-only + DDR mode support Date: Tue, 9 Apr 2019 10:51:36 +0530 [thread overview] Message-ID: <accde963-4cb0-2db3-d482-f6ca1a386398@ti.com> (raw) In-Reply-To: <643643f2-c855-5cb6-79b5-96a4f9752955@ti.com> On 09/04/19 9:29 AM, Keerthy wrote: > > > On 08/04/19 11:13 PM, Tony Lindgren wrote: >> * Tony Lindgren <tony@atomide.com> [190408 10:26]: >>> * Keerthy <j-keerthy@ti.com> [190402 21:57]: >>>> Changes in v3: >>>> >>>> * Exported out omap_rtc_poweroff_program function & removed >>>> the patch to add a generic rtc interface as it is specific >>>> to am43 at the moment. >>> >>> Thanks I'll be applying this series into omap-for-v5.2/am4-pm >>> today. >> >> Sorry correction for the branch named above. I noticed a build >> warning and folded in the following fix. We need to return >> -EINVAL if tm2bcd() fails like we do elsewhere in the driver. >> >> So I just pushed out a new branch omap-for-v5.2/am4-pm-v2. >> Please just ignore the earlier branch omap-for-v5.2/am4-pm. > > Thanks Tony! Tony, Seems like your for-next is a little behind. Hence you noticed the compilation error which i did not notice. The rtc driver patch i formatted from your for-next branch does not apply cleanly on linux-next as there are more patches already applied by Alexandre on next. So the patch you made to return -EINVAL is no longer needed on latest next. Thanks, Keerthy > >> >> Regards, >> >> Tony >> >> 8< -------------------- >> diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c >> --- a/drivers/rtc/rtc-omap.c >> +++ b/drivers/rtc/rtc-omap.c >> @@ -447,7 +447,7 @@ int omap_rtc_power_off_program(struct device *dev) >> if (tm2bcd(&tm) < 0) { >> dev_err(&rtc->rtc->dev, "power off failed\n"); >> rtc->type->lock(rtc); >> - return; >> + return -EINVAL; >> } >> rtc_wait_not_busy(rtc); >>
WARNING: multiple messages have this Message-ID (diff)
From: Keerthy <j-keerthy@ti.com> To: Tony Lindgren <tony@atomide.com> Cc: linux-rtc@vger.kernel.org, a.zummo@towertech.it, alexandre.belloni@bootlin.com, d-gerlach@ti.com, t-kristo@ti.com, ssantosh@kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 0/4] AM437x: Add rtc-only + DDR mode support Date: Tue, 9 Apr 2019 10:51:36 +0530 [thread overview] Message-ID: <accde963-4cb0-2db3-d482-f6ca1a386398@ti.com> (raw) In-Reply-To: <643643f2-c855-5cb6-79b5-96a4f9752955@ti.com> On 09/04/19 9:29 AM, Keerthy wrote: > > > On 08/04/19 11:13 PM, Tony Lindgren wrote: >> * Tony Lindgren <tony@atomide.com> [190408 10:26]: >>> * Keerthy <j-keerthy@ti.com> [190402 21:57]: >>>> Changes in v3: >>>> >>>> * Exported out omap_rtc_poweroff_program function & removed >>>> the patch to add a generic rtc interface as it is specific >>>> to am43 at the moment. >>> >>> Thanks I'll be applying this series into omap-for-v5.2/am4-pm >>> today. >> >> Sorry correction for the branch named above. I noticed a build >> warning and folded in the following fix. We need to return >> -EINVAL if tm2bcd() fails like we do elsewhere in the driver. >> >> So I just pushed out a new branch omap-for-v5.2/am4-pm-v2. >> Please just ignore the earlier branch omap-for-v5.2/am4-pm. > > Thanks Tony! Tony, Seems like your for-next is a little behind. Hence you noticed the compilation error which i did not notice. The rtc driver patch i formatted from your for-next branch does not apply cleanly on linux-next as there are more patches already applied by Alexandre on next. So the patch you made to return -EINVAL is no longer needed on latest next. Thanks, Keerthy > >> >> Regards, >> >> Tony >> >> 8< -------------------- >> diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c >> --- a/drivers/rtc/rtc-omap.c >> +++ b/drivers/rtc/rtc-omap.c >> @@ -447,7 +447,7 @@ int omap_rtc_power_off_program(struct device *dev) >> if (tm2bcd(&tm) < 0) { >> dev_err(&rtc->rtc->dev, "power off failed\n"); >> rtc->type->lock(rtc); >> - return; >> + return -EINVAL; >> } >> rtc_wait_not_busy(rtc); >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-09 5:21 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-03 4:57 [PATCH v3 0/4] AM437x: Add rtc-only + DDR mode support Keerthy 2019-04-03 4:57 ` Keerthy 2019-04-03 4:57 ` Keerthy 2019-04-03 4:57 ` [PATCH v3 1/4] rtc: OMAP: Add support for rtc-only mode Keerthy 2019-04-03 4:57 ` Keerthy 2019-04-03 4:57 ` Keerthy 2019-04-03 14:49 ` Alexandre Belloni 2019-04-03 14:49 ` Alexandre Belloni 2019-04-03 14:49 ` Alexandre Belloni 2019-04-03 4:57 ` [PATCH v3 2/4] arm: mach-omap2: pm33xx: Add support for rtc+ddr in self refresh mode Keerthy 2019-04-03 4:57 ` Keerthy 2019-04-03 4:57 ` Keerthy 2019-04-03 4:57 ` [PATCH v3 3/4] soc: ti: pm33xx: Move the am33xx_push_sram_idle to the top Keerthy 2019-04-03 4:57 ` Keerthy 2019-04-03 4:57 ` Keerthy 2019-04-03 4:57 ` [PATCH v3 4/4] soc: ti: pm33xx: AM437X: Add rtc_only with ddr in self-refresh support Keerthy 2019-04-03 4:57 ` Keerthy 2019-04-03 4:57 ` Keerthy 2019-04-08 17:26 ` [PATCH v3 0/4] AM437x: Add rtc-only + DDR mode support Tony Lindgren 2019-04-08 17:26 ` Tony Lindgren 2019-04-08 17:26 ` Tony Lindgren 2019-04-08 17:43 ` Tony Lindgren 2019-04-08 17:43 ` Tony Lindgren 2019-04-08 17:43 ` Tony Lindgren 2019-04-09 3:59 ` Keerthy 2019-04-09 3:59 ` Keerthy 2019-04-09 3:59 ` Keerthy 2019-04-09 5:21 ` Keerthy [this message] 2019-04-09 5:21 ` Keerthy 2019-04-09 14:20 ` Tony Lindgren 2019-04-09 14:20 ` Tony Lindgren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=accde963-4cb0-2db3-d482-f6ca1a386398@ti.com \ --to=j-keerthy@ti.com \ --cc=a.zummo@towertech.it \ --cc=alexandre.belloni@bootlin.com \ --cc=d-gerlach@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-rtc@vger.kernel.org \ --cc=ssantosh@kernel.org \ --cc=t-kristo@ti.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.