From: SF Markus Elfring <elfring@users.sourceforge.net> To: linux-rdma@vger.kernel.org, target-devel@vger.kernel.org, David Ahern <dsa@cumulusnetworks.com>, Doug Ledford <dledford@redhat.com>, Erez Shitrit <erezsh@mellanox.com>, Feras Daoud <ferasda@mellanox.com>, Hal Rosenstock <hal.rosenstock@gmail.com>, Leon Romanovsky <leon@kernel.org>, Mark Bloch <markb@mellanox.com>, Or Gerlitz <ogerlitz@mellanox.com>, Paolo Abeni <pabeni@redhat.com>, Roi Dayan <roid@mellanox.com>, Sagi Grimberg <sagi@grimberg.me>, Sean Hefty <sean.hefty@intel.com>, Yuval Shaia <yuval.shaia@oracle.com>, Zhu Yanjun <yanjun.zhu@oracle.com> Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org Subject: [PATCH 3/9] IB/IPoIB: Enclose six expressions for the sizeof operator by parentheses Date: Fri, 7 Apr 2017 23:01:57 +0200 [thread overview] Message-ID: <acd5a60c-cf71-e802-94c7-8b85ebe020ef@users.sourceforge.net> (raw) In-Reply-To: <ce4249f2-c7e7-0282-2cff-3f9c3991efa3@users.sourceforge.net> From: Markus Elfring <elfring@users.sourceforge.net> Date: Fri, 7 Apr 2017 19:54:15 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script "checkpatch.pl" pointed information out like the following. WARNING: sizeof *… should be sizeof(*…) Thus fix the affected source code places. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/infiniband/ulp/ipoib/ipoib_main.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c index c5024c6d38e7..446af4ec3d86 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c @@ -581,7 +581,7 @@ struct ipoib_path_iter *ipoib_path_iter_init(struct net_device *dev) { struct ipoib_path_iter *iter; - iter = kmalloc(sizeof *iter, GFP_KERNEL); + iter = kmalloc(sizeof(*iter), GFP_KERNEL); if (!iter) return NULL; @@ -864,7 +864,7 @@ static struct ipoib_path *path_rec_create(struct net_device *dev, void *gid) if (!priv->broadcast) return NULL; - path = kzalloc(sizeof *path, GFP_ATOMIC); + path = kzalloc(sizeof(*path), GFP_ATOMIC); if (!path) return NULL; @@ -1161,7 +1161,7 @@ static int ipoib_hard_header(struct sk_buff *skb, { struct ipoib_header *header; - header = (struct ipoib_header *) skb_push(skb, sizeof *header); + header = (struct ipoib_header *)skb_push(skb, sizeof(*header)); header->proto = htons(type); header->reserved = 0; @@ -1329,7 +1329,7 @@ static struct ipoib_neigh *ipoib_neigh_ctor(u8 *daddr, { struct ipoib_neigh *neigh; - neigh = kzalloc(sizeof *neigh, GFP_ATOMIC); + neigh = kzalloc(sizeof(*neigh), GFP_ATOMIC); if (!neigh) return NULL; @@ -1633,7 +1633,7 @@ int ipoib_dev_init(struct net_device *dev, struct ib_device *ca, int port) if (!priv->rx_ring) goto out; - priv->tx_ring = vzalloc(ipoib_sendq_size * sizeof *priv->tx_ring); + priv->tx_ring = vzalloc(ipoib_sendq_size * sizeof(*priv->tx_ring)); if (!priv->tx_ring) goto out_rx_ring_cleanup; @@ -2132,7 +2132,7 @@ static void ipoib_add_one(struct ib_device *device) int p; int count = 0; - dev_list = kmalloc(sizeof *dev_list, GFP_KERNEL); + dev_list = kmalloc(sizeof(*dev_list), GFP_KERNEL); if (!dev_list) return; -- 2.12.2
WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net> To: linux-rdma@vger.kernel.org, target-devel@vger.kernel.org, David Ahern <dsa@cumulusnetworks.com>, Doug Ledford <dledford@redhat.com>, Erez Shitrit <erezsh@mellanox.com>, Feras Daoud <ferasda@mellanox.com>, Hal Rosenstock <hal.rosenstock@gmail.com>, Leon Romanovsky <leon@kernel.org>, Mark Bloch <markb@mellanox.com>, Or Gerlitz <ogerlitz@mellanox.com>, Paolo Abeni <pabeni@redhat.com>, Roi Dayan <roid@mellanox.com>, Sagi Grimberg <sagi@grimberg.me>, Sean Hefty <sean.hefty@intel.com>, Yuval Shaia <yuval.shaia@oracle.com>, Zhu Yanjun <yanjun.zhu@oracle.com> Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org Subject: [PATCH 3/9] IB/IPoIB: Enclose six expressions for the sizeof operator by parentheses Date: Fri, 07 Apr 2017 21:01:57 +0000 [thread overview] Message-ID: <acd5a60c-cf71-e802-94c7-8b85ebe020ef@users.sourceforge.net> (raw) In-Reply-To: <ce4249f2-c7e7-0282-2cff-3f9c3991efa3@users.sourceforge.net> From: Markus Elfring <elfring@users.sourceforge.net> Date: Fri, 7 Apr 2017 19:54:15 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script "checkpatch.pl" pointed information out like the following. WARNING: sizeof *… should be sizeof(*…) Thus fix the affected source code places. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/infiniband/ulp/ipoib/ipoib_main.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c index c5024c6d38e7..446af4ec3d86 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c @@ -581,7 +581,7 @@ struct ipoib_path_iter *ipoib_path_iter_init(struct net_device *dev) { struct ipoib_path_iter *iter; - iter = kmalloc(sizeof *iter, GFP_KERNEL); + iter = kmalloc(sizeof(*iter), GFP_KERNEL); if (!iter) return NULL; @@ -864,7 +864,7 @@ static struct ipoib_path *path_rec_create(struct net_device *dev, void *gid) if (!priv->broadcast) return NULL; - path = kzalloc(sizeof *path, GFP_ATOMIC); + path = kzalloc(sizeof(*path), GFP_ATOMIC); if (!path) return NULL; @@ -1161,7 +1161,7 @@ static int ipoib_hard_header(struct sk_buff *skb, { struct ipoib_header *header; - header = (struct ipoib_header *) skb_push(skb, sizeof *header); + header = (struct ipoib_header *)skb_push(skb, sizeof(*header)); header->proto = htons(type); header->reserved = 0; @@ -1329,7 +1329,7 @@ static struct ipoib_neigh *ipoib_neigh_ctor(u8 *daddr, { struct ipoib_neigh *neigh; - neigh = kzalloc(sizeof *neigh, GFP_ATOMIC); + neigh = kzalloc(sizeof(*neigh), GFP_ATOMIC); if (!neigh) return NULL; @@ -1633,7 +1633,7 @@ int ipoib_dev_init(struct net_device *dev, struct ib_device *ca, int port) if (!priv->rx_ring) goto out; - priv->tx_ring = vzalloc(ipoib_sendq_size * sizeof *priv->tx_ring); + priv->tx_ring = vzalloc(ipoib_sendq_size * sizeof(*priv->tx_ring)); if (!priv->tx_ring) goto out_rx_ring_cleanup; @@ -2132,7 +2132,7 @@ static void ipoib_add_one(struct ib_device *device) int p; int count = 0; - dev_list = kmalloc(sizeof *dev_list, GFP_KERNEL); + dev_list = kmalloc(sizeof(*dev_list), GFP_KERNEL); if (!dev_list) return; -- 2.12.2
next prev parent reply other threads:[~2017-04-07 21:01 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-07 20:54 [PATCH 0/9] InfiniBand-ULP: Fine-tuning for several function implementations SF Markus Elfring 2017-04-07 20:54 ` SF Markus Elfring 2017-04-07 20:54 ` SF Markus Elfring 2017-04-07 20:57 ` [PATCH 1/9] IB/IPoIB: Use kcalloc() in two functions SF Markus Elfring 2017-04-07 20:57 ` SF Markus Elfring 2017-04-09 12:26 ` Sagi Grimberg 2017-04-09 12:26 ` Sagi Grimberg [not found] ` <ce4249f2-c7e7-0282-2cff-3f9c3991efa3-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> 2017-04-07 21:00 ` [PATCH 2/9] IB/IPoIB: Delete an error message for a failed memory allocation SF Markus Elfring 2017-04-07 21:00 ` SF Markus Elfring 2017-04-07 21:00 ` SF Markus Elfring 2017-04-09 12:26 ` Sagi Grimberg 2017-04-09 12:26 ` Sagi Grimberg 2017-04-07 21:03 ` [PATCH 4/9] IB/IPoIB: Delete unwanted spaces behind usages of the sizeof operator SF Markus Elfring 2017-04-07 21:03 ` SF Markus Elfring 2017-04-07 21:03 ` SF Markus Elfring 2017-04-09 12:26 ` Sagi Grimberg 2017-04-09 12:26 ` Sagi Grimberg 2017-04-07 21:06 ` [PATCH 6/9] IB/iser: Use kmalloc_array() in iser_alloc_rx_descriptors() SF Markus Elfring 2017-04-07 21:06 ` SF Markus Elfring 2017-04-07 21:06 ` SF Markus Elfring [not found] ` <75e5726b-d75f-1b79-1242-08f6440e1691-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> 2017-04-09 9:01 ` Sagi Grimberg 2017-04-09 9:01 ` Sagi Grimberg 2017-04-09 9:01 ` Sagi Grimberg 2017-04-07 21:08 ` [PATCH 8/9] IB/isert: Use kcalloc() in isert_alloc_rx_descriptors() SF Markus Elfring 2017-04-07 21:08 ` SF Markus Elfring 2017-04-07 21:08 ` SF Markus Elfring 2017-04-09 9:02 ` Sagi Grimberg 2017-04-09 9:02 ` Sagi Grimberg 2017-04-07 21:01 ` SF Markus Elfring [this message] 2017-04-07 21:01 ` [PATCH 3/9] IB/IPoIB: Enclose six expressions for the sizeof operator by parentheses SF Markus Elfring 2017-04-09 12:26 ` Sagi Grimberg 2017-04-09 12:26 ` Sagi Grimberg 2017-04-07 21:05 ` [PATCH 5/9] IB/IPoIB: Combine substrings for three messages SF Markus Elfring 2017-04-07 21:05 ` SF Markus Elfring 2017-04-18 11:33 ` Yuval Shaia 2017-04-18 11:33 ` Yuval Shaia 2017-04-07 21:07 ` [PATCH 7/9] IB/iser: Add spaces for better code readability SF Markus Elfring 2017-04-07 21:07 ` SF Markus Elfring 2017-04-09 9:02 ` Sagi Grimberg 2017-04-09 9:02 ` Sagi Grimberg 2017-04-07 21:09 ` [PATCH 9/9] IB/isert: Improve size determinations in three functions SF Markus Elfring 2017-04-07 21:09 ` SF Markus Elfring 2017-04-09 9:02 ` Sagi Grimberg 2017-04-09 9:02 ` Sagi Grimberg
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=acd5a60c-cf71-e802-94c7-8b85ebe020ef@users.sourceforge.net \ --to=elfring@users.sourceforge.net \ --cc=dledford@redhat.com \ --cc=dsa@cumulusnetworks.com \ --cc=erezsh@mellanox.com \ --cc=ferasda@mellanox.com \ --cc=hal.rosenstock@gmail.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=leon@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rdma@vger.kernel.org \ --cc=markb@mellanox.com \ --cc=ogerlitz@mellanox.com \ --cc=pabeni@redhat.com \ --cc=roid@mellanox.com \ --cc=sagi@grimberg.me \ --cc=sean.hefty@intel.com \ --cc=target-devel@vger.kernel.org \ --cc=yanjun.zhu@oracle.com \ --cc=yuval.shaia@oracle.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.