All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/5] rockchip: rk322x: update dram bank size
Date: Wed, 6 Sep 2017 17:39:00 +0800	[thread overview]
Message-ID: <acd6c251-3748-429e-860c-2b125a61e8c0@rock-chips.com> (raw)
In-Reply-To: <1502954257-7256-2-git-send-email-kever.yang@rock-chips.com>

Hi Philipp,

     This patch is a bug fix for rk3229 ram size, and not relate to the 
dram driver,

could you share why you still not take this patch?


Thanks,
- Kever
On 08/17/2017 03:17 PM, Kever Yang wrote:
> The DRAM start address is not 0, so need to update the last bank size
> as:
> DRAM start addr + DRAM_SIZE - last bank start addr
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v2: None
>
>   arch/arm/mach-rockchip/rk322x-board.c | 10 ++++++----
>   1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-rockchip/rk322x-board.c b/arch/arm/mach-rockchip/rk322x-board.c
> index b6543a5..f93bd33 100644
> --- a/arch/arm/mach-rockchip/rk322x-board.c
> +++ b/arch/arm/mach-rockchip/rk322x-board.c
> @@ -72,11 +72,13 @@ int board_init(void)
>   
>   int dram_init_banksize(void)
>   {
> -	/* Reserve 0x200000 for OPTEE */
> -	gd->bd->bi_dram[0].start = 0x60000000;
> +	gd->bd->bi_dram[0].start = CONFIG_SYS_SDRAM_BASE;
>   	gd->bd->bi_dram[0].size = 0x8400000;
> -	gd->bd->bi_dram[1].start = 0x6a400000;
> -	gd->bd->bi_dram[1].size = gd->ram_size - gd->bd->bi_dram[1].start;
> +	/* Reserve 14M for OPTEE and TA */
> +	gd->bd->bi_dram[1].start = CONFIG_SYS_SDRAM_BASE
> +				+ gd->bd->bi_dram[0].size + 0xe00000;
> +	gd->bd->bi_dram[1].size = gd->bd->bi_dram[0].start
> +				+ gd->ram_size - gd->bd->bi_dram[1].start;
>   
>   	return 0;
>   }

  reply	other threads:[~2017-09-06  9:39 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-17  7:17 [PATCH v2 0/5] rockchip: rk3229: add sdram and sd support Kever Yang
2017-08-17  7:17 ` [U-Boot] " Kever Yang
2017-08-17  7:17 ` [PATCH v2 1/5] rockchip: rk322x: update dram bank size Kever Yang
2017-08-17  7:17   ` [U-Boot] " Kever Yang
2017-09-06  9:39   ` Kever Yang [this message]
2017-09-06 10:24     ` Dr. Philipp Tomsich
2017-08-17  7:17 ` [PATCH v2 2/5] rockchip: rk322x: add sdram driver Kever Yang
2017-08-17  7:17   ` [U-Boot] " Kever Yang
2017-09-05  9:51   ` [U-Boot,v2,2/5] " Philipp Tomsich
2017-09-05  9:51     ` [U-Boot] " Philipp Tomsich
     [not found]     ` <alpine.OSX.2.21.1709051140140.20553-P6fm21zUGUcV4DTK6cx7e366tl449arB@public.gmane.org>
2017-09-09  4:54       ` Simon Glass
2017-09-09  4:54         ` [U-Boot] " Simon Glass
2017-08-17  7:17 ` [PATCH v2 4/5] rockchip: rk322x: pinctrl: fix IO MASK error on sdcard pin Kever Yang
2017-08-17  7:17   ` [U-Boot] " Kever Yang
2017-08-18 16:04   ` [U-Boot, v2, " Philipp Tomsich
2017-08-18 16:04     ` [U-Boot] " Philipp Tomsich
     [not found]   ` <1502954257-7256-5-git-send-email-kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-18 13:01     ` Philipp Tomsich
2017-08-18 13:01       ` [U-Boot] " Philipp Tomsich
2017-08-18 17:06     ` Philipp Tomsich
2017-08-18 17:06       ` [U-Boot] " Philipp Tomsich
     [not found] ` <1502954257-7256-1-git-send-email-kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-17  7:17   ` [PATCH v2 3/5] rockchip: rk322x: pinctrl: using compatible name same with dts Kever Yang
2017-08-17  7:17     ` [U-Boot] " Kever Yang
     [not found]     ` <1502954257-7256-4-git-send-email-kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-18 13:01       ` [U-Boot, v2, " Philipp Tomsich
2017-08-18 13:01         ` [U-Boot] " Philipp Tomsich
2017-08-18 17:06       ` Philipp Tomsich
2017-08-18 17:06         ` [U-Boot] " Philipp Tomsich
2017-08-18 16:04     ` Philipp Tomsich
2017-08-18 16:04       ` [U-Boot] " Philipp Tomsich
2017-08-17  7:17   ` [PATCH v2 5/5] rockchip: dts: rk3229: remove dram channel info Kever Yang
2017-08-17  7:17     ` [U-Boot] " Kever Yang
2017-08-17  8:34 ` [PATCH v2 0/5] rockchip: rk3229: add sdram and sd support Dr. Philipp Tomsich
2017-08-17  8:34   ` [U-Boot] " Dr. Philipp Tomsich
2017-08-18  6:26   ` Kever Yang
2017-08-18  6:26     ` [U-Boot] " Kever Yang
2017-08-18  7:36     ` Dr. Philipp Tomsich
2017-08-18  7:36       ` [U-Boot] " Dr. Philipp Tomsich
2017-08-18 11:24       ` Kever Yang
2017-08-18 11:24         ` [U-Boot] " Kever Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acd6c251-3748-429e-860c-2b125a61e8c0@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.