From: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
To: Philipp Tomsich
<philipp.tomsich-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org>
Cc: "U-Boot Mailing List"
<u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org>,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
"Kever Yang" <kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
"Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Subject: Re: [U-Boot,v2,2/5] rockchip: rk322x: add sdram driver
Date: Fri, 8 Sep 2017 22:54:54 -0600 [thread overview]
Message-ID: <CAPnjgZ09V5ZRi9wR2xWDRaLZAJx8=u-qzVTjrosOCBC3+oQmRw@mail.gmail.com> (raw)
In-Reply-To: <alpine.OSX.2.21.1709051140140.20553-P6fm21zUGUcV4DTK6cx7e366tl449arB@public.gmane.org>
Hi Philipp,
On 5 September 2017 at 03:51, Philipp Tomsich
<philipp.tomsich-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org> wrote:
> + Simon
>
> Kever,
>
> thanks for moving this to the new location, but it doesn't address my
> concerns that we are duplicating large amounts of code from other SDRAM
> drivers (and that there's large amounts of #define statements where we
> usually use enum definitions for Rockchip).
>
> You may be able to convince me to apply this to the 'next' branch as-is, if
> we get a plan in place to clean up the DRAM controller code over during the
> two merge windows remaining in this year.
>
> @Simon: I know the amount of code-duplication across the DRAM controller
> drivers is a touchy subject for you too --- any additional comments or
> guidance?
Well I haven't changed my mind. I think it would be good to make a
start before any more drivers go in.
But I should leave the specifics to you.
Regards,
Simon
WARNING: multiple messages have this Message-ID (diff)
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot,v2,2/5] rockchip: rk322x: add sdram driver
Date: Fri, 8 Sep 2017 22:54:54 -0600 [thread overview]
Message-ID: <CAPnjgZ09V5ZRi9wR2xWDRaLZAJx8=u-qzVTjrosOCBC3+oQmRw@mail.gmail.com> (raw)
In-Reply-To: <alpine.OSX.2.21.1709051140140.20553@vpn-10-11-0-14.lan>
Hi Philipp,
On 5 September 2017 at 03:51, Philipp Tomsich
<philipp.tomsich@theobroma-systems.com> wrote:
> + Simon
>
> Kever,
>
> thanks for moving this to the new location, but it doesn't address my
> concerns that we are duplicating large amounts of code from other SDRAM
> drivers (and that there's large amounts of #define statements where we
> usually use enum definitions for Rockchip).
>
> You may be able to convince me to apply this to the 'next' branch as-is, if
> we get a plan in place to clean up the DRAM controller code over during the
> two merge windows remaining in this year.
>
> @Simon: I know the amount of code-duplication across the DRAM controller
> drivers is a touchy subject for you too --- any additional comments or
> guidance?
Well I haven't changed my mind. I think it would be good to make a
start before any more drivers go in.
But I should leave the specifics to you.
Regards,
Simon
next prev parent reply other threads:[~2017-09-09 4:54 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 7:17 [PATCH v2 0/5] rockchip: rk3229: add sdram and sd support Kever Yang
2017-08-17 7:17 ` [U-Boot] " Kever Yang
2017-08-17 7:17 ` [PATCH v2 1/5] rockchip: rk322x: update dram bank size Kever Yang
2017-08-17 7:17 ` [U-Boot] " Kever Yang
2017-09-06 9:39 ` Kever Yang
2017-09-06 10:24 ` Dr. Philipp Tomsich
2017-08-17 7:17 ` [PATCH v2 2/5] rockchip: rk322x: add sdram driver Kever Yang
2017-08-17 7:17 ` [U-Boot] " Kever Yang
2017-09-05 9:51 ` [U-Boot,v2,2/5] " Philipp Tomsich
2017-09-05 9:51 ` [U-Boot] " Philipp Tomsich
[not found] ` <alpine.OSX.2.21.1709051140140.20553-P6fm21zUGUcV4DTK6cx7e366tl449arB@public.gmane.org>
2017-09-09 4:54 ` Simon Glass [this message]
2017-09-09 4:54 ` Simon Glass
2017-08-17 7:17 ` [PATCH v2 4/5] rockchip: rk322x: pinctrl: fix IO MASK error on sdcard pin Kever Yang
2017-08-17 7:17 ` [U-Boot] " Kever Yang
2017-08-18 16:04 ` [U-Boot, v2, " Philipp Tomsich
2017-08-18 16:04 ` [U-Boot] " Philipp Tomsich
[not found] ` <1502954257-7256-5-git-send-email-kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-18 13:01 ` Philipp Tomsich
2017-08-18 13:01 ` [U-Boot] " Philipp Tomsich
2017-08-18 17:06 ` Philipp Tomsich
2017-08-18 17:06 ` [U-Boot] " Philipp Tomsich
[not found] ` <1502954257-7256-1-git-send-email-kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-17 7:17 ` [PATCH v2 3/5] rockchip: rk322x: pinctrl: using compatible name same with dts Kever Yang
2017-08-17 7:17 ` [U-Boot] " Kever Yang
[not found] ` <1502954257-7256-4-git-send-email-kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-18 13:01 ` [U-Boot, v2, " Philipp Tomsich
2017-08-18 13:01 ` [U-Boot] " Philipp Tomsich
2017-08-18 17:06 ` Philipp Tomsich
2017-08-18 17:06 ` [U-Boot] " Philipp Tomsich
2017-08-18 16:04 ` Philipp Tomsich
2017-08-18 16:04 ` [U-Boot] " Philipp Tomsich
2017-08-17 7:17 ` [PATCH v2 5/5] rockchip: dts: rk3229: remove dram channel info Kever Yang
2017-08-17 7:17 ` [U-Boot] " Kever Yang
2017-08-17 8:34 ` [PATCH v2 0/5] rockchip: rk3229: add sdram and sd support Dr. Philipp Tomsich
2017-08-17 8:34 ` [U-Boot] " Dr. Philipp Tomsich
2017-08-18 6:26 ` Kever Yang
2017-08-18 6:26 ` [U-Boot] " Kever Yang
2017-08-18 7:36 ` Dr. Philipp Tomsich
2017-08-18 7:36 ` [U-Boot] " Dr. Philipp Tomsich
2017-08-18 11:24 ` Kever Yang
2017-08-18 11:24 ` [U-Boot] " Kever Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPnjgZ09V5ZRi9wR2xWDRaLZAJx8=u-qzVTjrosOCBC3+oQmRw@mail.gmail.com' \
--to=sjg-f7+t8e8rja9g9huczpvpmw@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=philipp.tomsich-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org \
--cc=u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.