All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	linux-clk@vger.kernel.org
Cc: mturquette@baylibre.com, sboyd@kernel.org, cw00.choi@samsung.com,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, m.szyprowski@samsung.com
Subject: Re: [PATCH] clk: samsung: Remove meaningless __init and extern from header files
Date: Fri, 15 Oct 2021 19:04:47 +0200	[thread overview]
Message-ID: <ad2346d9-16b8-9d09-05e6-be4f62363e04@samsung.com> (raw)
In-Reply-To: <531f5bd4-efa2-1583-4bbf-38f57e0b641c@canonical.com>

On 15.10.2021 17:16, Krzysztof Kozlowski wrote:
> On 15/10/2021 17:14, Sylwester Nawrocki wrote:
>> Remove useless __init atrribute and unneeded extern qualifier in function
>> declarations in header files.
>>
>> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>> ---
>>  drivers/clk/samsung/clk-cpu.h |  2 +-
>>  drivers/clk/samsung/clk.h     | 34 +++++++++++++++++-----------------
[..]
>> -extern void __init samsung_clk_register_pll(struct samsung_clk_provider *ctx,
>> +void samsung_clk_register_pll(struct samsung_clk_provider *ctx,
>>  			const struct samsung_pll_clock *pll_list,
>>  			unsigned int nr_clk, void __iomem *base);
>> -extern void samsung_clk_register_cpu(struct samsung_clk_provider *ctx,
>> +void samsung_clk_register_cpu(struct samsung_clk_provider *ctx,
>>  		const struct samsung_cpu_clock *list, unsigned int nr_clk);
[...]
> In such case, let's also drop the extern from Will's patch?

Yeah, I have already applied Will's patches and that patch also removes
the one newly introduced extern.
-- 
Regards,
Sylwester

WARNING: multiple messages have this Message-ID (diff)
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	linux-clk@vger.kernel.org
Cc: mturquette@baylibre.com, sboyd@kernel.org, cw00.choi@samsung.com,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, m.szyprowski@samsung.com
Subject: Re: [PATCH] clk: samsung: Remove meaningless __init and extern from header files
Date: Fri, 15 Oct 2021 19:04:47 +0200	[thread overview]
Message-ID: <ad2346d9-16b8-9d09-05e6-be4f62363e04@samsung.com> (raw)
In-Reply-To: <531f5bd4-efa2-1583-4bbf-38f57e0b641c@canonical.com>

On 15.10.2021 17:16, Krzysztof Kozlowski wrote:
> On 15/10/2021 17:14, Sylwester Nawrocki wrote:
>> Remove useless __init atrribute and unneeded extern qualifier in function
>> declarations in header files.
>>
>> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>> ---
>>  drivers/clk/samsung/clk-cpu.h |  2 +-
>>  drivers/clk/samsung/clk.h     | 34 +++++++++++++++++-----------------
[..]
>> -extern void __init samsung_clk_register_pll(struct samsung_clk_provider *ctx,
>> +void samsung_clk_register_pll(struct samsung_clk_provider *ctx,
>>  			const struct samsung_pll_clock *pll_list,
>>  			unsigned int nr_clk, void __iomem *base);
>> -extern void samsung_clk_register_cpu(struct samsung_clk_provider *ctx,
>> +void samsung_clk_register_cpu(struct samsung_clk_provider *ctx,
>>  		const struct samsung_cpu_clock *list, unsigned int nr_clk);
[...]
> In such case, let's also drop the extern from Will's patch?

Yeah, I have already applied Will's patches and that patch also removes
the one newly introduced extern.
-- 
Regards,
Sylwester

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-10-15 17:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20211015151438eucas1p1a784b8fb6bc20b01d4b1ec3634359df5@eucas1p1.samsung.com>
2021-10-15 15:14 ` [PATCH] clk: samsung: Remove meaningless __init and extern from header files Sylwester Nawrocki
2021-10-15 15:14   ` Sylwester Nawrocki
2021-10-15 15:16   ` Krzysztof Kozlowski
2021-10-15 15:16     ` Krzysztof Kozlowski
2021-10-15 17:04     ` Sylwester Nawrocki [this message]
2021-10-15 17:04       ` Sylwester Nawrocki
2021-10-15 21:00   ` Stephen Boyd
2021-10-15 21:00     ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad2346d9-16b8-9d09-05e6-be4f62363e04@samsung.com \
    --to=s.nawrocki@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.