From: Jeff Layton <jlayton-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: "Damien Le Moal"
<dlemoal-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Jeremy Kerr" <jk-mnsaURCQ41sdnm+yROfE0A@public.gmane.org>,
"Arnd Bergmann" <arnd-r2nGTMty4D4@public.gmane.org>,
"Michael Ellerman" <mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>,
"Nicholas Piggin"
<npiggin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Christophe Leroy"
<christophe.leroy-2tlSp11Fh4xulxpn9UvDqw@public.gmane.org>,
"Heiko Carstens" <hca-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>,
"Vasily Gorbik" <gor-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>,
"Alexander Gordeev"
<agordeev-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>,
"Christian Borntraeger"
<borntraeger-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>,
"Sven Schnelle" <svens-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>,
"Greg Kroah-Hartman"
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
"Arve Hjønnevåg" <arve-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
"Todd Kjos" <tkjos-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
"Martijn Coenen" <maco-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
"Joel Fernandes"
<joel-QYYGw3jwrUn5owFQY34kdNi2O/JbrIOy@public.gmane.org>,
"Christian Brauner"
<brauner-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Carlos Llamas"
<cmllamas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
"Suren Baghdasaryan"
<surenb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 01/79] fs: add ctime accessors infrastructure
Date: Thu, 22 Jun 2023 06:14:30 -0400 [thread overview]
Message-ID: <ad4bfb630128709588164db6f1fd2ef39c31d2a5.camel__9120.83277232654$1687428912$gmane$org@kernel.org> (raw)
In-Reply-To: <99b3c749-23d9-6f09-fb75-6a84f3d1b066-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
On Thu, 2023-06-22 at 09:46 +0900, Damien Le Moal wrote:
> On 6/21/23 23:45, Jeff Layton wrote:
> > struct timespec64 has unused bits in the tv_nsec field that can be used
> > for other purposes. In future patches, we're going to change how the
> > inode->i_ctime is accessed in certain inodes in order to make use of
> > them. In order to do that safely though, we'll need to eradicate raw
> > accesses of the inode->i_ctime field from the kernel.
> >
> > Add new accessor functions for the ctime that we can use to replace them.
> >
> > Signed-off-by: Jeff Layton <jlayton-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>
> [...]
>
> > +/**
> > + * inode_ctime_peek - fetch the current ctime from the inode
> > + * @inode: inode from which to fetch ctime
> > + *
> > + * Grab the current ctime from the inode and return it.
> > + */
> > +static inline struct timespec64 inode_ctime_peek(const struct inode *inode)
>
> To be consistent with inode_ctime_set(), why not call this one inode_ctime_get()
In later patches fetching the ctime for presentation may have side
effects on certain filesystems. Using "peek" here is a hint that we want
to avoid those side effects in these calls.
> ? Also, inode_set_ctime() & inode_get_ctime() may be a little more natural. But
> no strong opinion about that though.
>
I like the consistency of the inode_ctime_* prefix. It makes it simpler
to find these calls when grepping, etc.
That said, my opinions on naming are pretty loosely-held, so if the
consensus is that the names should as you suggest, I'll go along with
it.
--
Jeff Layton <jlayton-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
next prev parent reply other threads:[~2023-06-22 10:14 UTC|newest]
Thread overview: 229+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 14:45 [PATCH 00/79] fs: new accessors for inode->i_ctime Jeff Layton
2023-06-21 14:45 ` [Cluster-devel] " Jeff Layton
2023-06-21 14:45 ` [Ocfs2-devel] " Jeff Layton via Ocfs2-devel
2023-06-21 14:45 ` [f2fs-dev] " Jeff Layton
2023-06-21 14:45 ` [PATCH 01/79] fs: add ctime accessors infrastructure Jeff Layton
2023-06-21 14:45 ` [Cluster-devel] " Jeff Layton
2023-06-21 14:45 ` [Ocfs2-devel] " Jeff Layton via Ocfs2-devel
2023-06-21 14:45 ` [f2fs-dev] " Jeff Layton
2023-06-21 16:34 ` Jan Kara
2023-06-21 16:34 ` Jan Kara
2023-06-21 16:34 ` [Cluster-devel] " Jan Kara
2023-06-21 16:34 ` Jan Kara
2023-06-21 16:34 ` Jan Kara
2023-06-21 16:34 ` [Ocfs2-devel] " Jan Kara via Ocfs2-devel
2023-06-21 16:34 ` [f2fs-dev] " Jan Kara
2023-06-21 17:29 ` Tom Talpey
2023-06-21 17:29 ` [Cluster-devel] " Tom Talpey
2023-06-21 17:29 ` [f2fs-dev] " Tom Talpey
2023-06-21 17:29 ` [Ocfs2-devel] " Tom Talpey via Ocfs2-devel
2023-06-21 18:01 ` Jeff Layton
2023-06-21 18:01 ` [Cluster-devel] " Jeff Layton
2023-06-21 18:01 ` [Ocfs2-devel] " Jeff Layton via Ocfs2-devel
2023-06-21 18:01 ` [f2fs-dev] " Jeff Layton
2023-06-21 18:19 ` Tom Talpey
2023-06-21 18:19 ` [Cluster-devel] " Tom Talpey
2023-06-21 18:19 ` [Ocfs2-devel] " Tom Talpey via Ocfs2-devel
2023-06-21 18:19 ` [f2fs-dev] " Tom Talpey
2023-06-21 18:48 ` Jeff Layton
2023-06-21 18:48 ` [Cluster-devel] " Jeff Layton
2023-06-21 18:48 ` [Ocfs2-devel] " Jeff Layton via Ocfs2-devel
2023-06-21 18:48 ` [f2fs-dev] " Jeff Layton
2023-06-22 0:46 ` Damien Le Moal
2023-06-22 0:46 ` [Cluster-devel] " Damien Le Moal
2023-06-22 0:46 ` [Ocfs2-devel] " Damien Le Moal via Ocfs2-devel
2023-06-22 0:46 ` [f2fs-dev] " Damien Le Moal
2023-06-22 10:14 ` Jeff Layton
2023-06-22 10:14 ` [Cluster-devel] " Jeff Layton
2023-06-22 10:14 ` [Ocfs2-devel] " Jeff Layton via Ocfs2-devel
2023-06-22 10:14 ` [f2fs-dev] " Jeff Layton
[not found] ` <99b3c749-23d9-6f09-fb75-6a84f3d1b066-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2023-06-22 10:14 ` Jeff Layton [this message]
2023-06-22 10:14 ` Jeff Layton
2023-06-30 22:12 ` Luis Chamberlain
2023-06-30 22:12 ` Luis Chamberlain
2023-06-30 22:12 ` [Cluster-devel] " Luis Chamberlain
2023-06-30 22:12 ` Luis Chamberlain
2023-06-30 22:12 ` Luis Chamberlain
2023-06-30 22:12 ` [f2fs-dev] " Luis Chamberlain
[not found] ` <20230621144507.55591-2-jlayton-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2023-07-12 15:31 ` Randy Dunlap
2023-07-12 15:31 ` Randy Dunlap
2023-07-12 15:31 ` [Cluster-devel] " Randy Dunlap
2023-07-12 15:31 ` Randy Dunlap
2023-07-12 15:31 ` Randy Dunlap
2023-07-12 15:34 ` Christian Brauner
2023-07-12 15:34 ` Christian Brauner
2023-07-12 15:31 ` Randy Dunlap
2023-06-21 14:45 ` [PATCH 02/79] spufs: switch to new ctime accessors Jeff Layton
2023-06-21 14:45 ` Jeff Layton
2023-06-21 14:45 ` [PATCH 03/79] s390: " Jeff Layton
2023-06-21 16:34 ` Jan Kara
2023-06-22 17:35 ` Alexander Gordeev
2023-06-22 17:51 ` Jeff Layton
2023-06-22 18:22 ` Alexander Gordeev
2023-06-22 18:46 ` Jeff Layton
2023-06-21 14:45 ` [PATCH 04/79] binderfs: " Jeff Layton
2023-06-21 15:29 ` Greg Kroah-Hartman
2023-06-21 16:35 ` Jan Kara
2023-06-21 14:45 ` [PATCH 05/79] qib_fs: " Jeff Layton
2023-06-21 16:35 ` Jan Kara
2023-06-21 19:37 ` Dennis Dalessandro
2023-06-21 14:45 ` [PATCH 06/79] ibm: " Jeff Layton
2023-06-21 15:29 ` Greg Kroah-Hartman
2023-06-21 16:35 ` Jan Kara
2023-06-21 14:45 ` [PATCH 07/79] usb: " Jeff Layton
2023-06-21 15:29 ` Greg Kroah-Hartman
2023-06-21 16:36 ` Jan Kara
2023-06-21 14:45 ` [PATCH 08/79] 9p: " Jeff Layton
2023-06-21 16:37 ` Jan Kara
2023-06-21 14:45 ` [PATCH 09/79] adfs: " Jeff Layton
2023-06-21 16:38 ` Jan Kara
2023-06-21 14:45 ` [PATCH 10/79] affs: " Jeff Layton
2023-06-21 16:39 ` Jan Kara
2023-06-22 11:37 ` David Sterba
2023-06-21 14:45 ` [PATCH 11/79] afs: " Jeff Layton
2023-06-21 16:43 ` Jan Kara
2023-06-21 14:45 ` [PATCH 12/79] fs: " Jeff Layton
2023-06-21 16:42 ` Jan Kara
2023-06-21 14:45 ` [PATCH 13/79] autofs: " Jeff Layton
2023-06-21 16:43 ` Jan Kara
2023-06-27 1:48 ` Ian Kent
2023-06-21 14:45 ` [PATCH 14/79] befs: " Jeff Layton
2023-06-21 16:44 ` Jan Kara
2023-06-21 14:45 ` [PATCH 15/79] bfs: " Jeff Layton
2023-06-21 16:48 ` Jan Kara
2023-06-21 16:57 ` Jeff Layton
2023-06-22 12:30 ` Jan Kara
2023-06-22 12:51 ` Jeff Layton
2023-06-22 14:57 ` Jan Kara
2023-06-23 12:33 ` Christian Brauner
2023-07-03 10:12 ` Christian Brauner
2023-07-03 10:46 ` Jeff Layton
2023-07-03 10:57 ` Christian Brauner
2023-06-21 14:45 ` [PATCH 16/79] btrfs: " Jeff Layton
2023-06-22 11:42 ` David Sterba
2023-06-21 14:45 ` [PATCH 17/79] ceph: " Jeff Layton
2023-06-26 0:56 ` Xiubo Li
2023-06-21 14:45 ` [PATCH 18/79] coda: " Jeff Layton
2023-06-21 14:45 ` [PATCH 19/79] configfs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 20/79] cramfs: " Jeff Layton
2023-06-21 15:29 ` Nicolas Pitre
2023-06-21 14:45 ` [PATCH 21/79] debugfs: " Jeff Layton
2023-06-21 15:29 ` Greg Kroah-Hartman
2023-06-21 14:45 ` [PATCH 22/79] devpts: " Jeff Layton
2023-06-21 14:45 ` [PATCH 23/79] ecryptfs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 24/79] efivarfs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 25/79] efs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 26/79] erofs: " Jeff Layton
2023-06-21 14:45 ` Jeff Layton
2023-06-22 4:01 ` Gao Xiang
2023-06-22 4:01 ` Gao Xiang
2023-06-21 14:45 ` [PATCH 27/79] exfat: " Jeff Layton
2023-06-21 14:45 ` [PATCH 28/79] ext2: " Jeff Layton
2023-06-21 14:45 ` [PATCH 29/79] ext4: " Jeff Layton
2023-06-21 14:45 ` [f2fs-dev] [PATCH 30/79] f2fs: " Jeff Layton
2023-06-21 14:45 ` Jeff Layton
2023-06-21 14:45 ` [PATCH 31/79] fat: " Jeff Layton
2023-06-21 14:45 ` [PATCH 32/79] freevxfs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 33/79] fuse: " Jeff Layton
2023-06-21 14:45 ` [PATCH 34/79] gfs2: " Jeff Layton
2023-06-21 14:45 ` [Cluster-devel] " Jeff Layton
2023-06-21 14:45 ` [PATCH 35/79] hfs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 36/79] hfsplus: " Jeff Layton
2023-06-21 14:45 ` [PATCH 37/79] hostfs: " Jeff Layton
2023-06-21 14:45 ` Jeff Layton
2023-06-21 14:45 ` [PATCH 38/79] hpfs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 39/79] hugetlbfs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 40/79] isofs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 41/79] jffs2: " Jeff Layton
2023-06-21 14:45 ` Jeff Layton
2023-06-21 14:45 ` [PATCH 42/79] jfs: " Jeff Layton
2023-06-21 17:47 ` Dave Kleikamp
2023-06-21 14:45 ` [PATCH 43/79] kernfs: " Jeff Layton
2023-06-21 15:30 ` Greg Kroah-Hartman
2023-06-21 14:45 ` [PATCH 44/79] minix: " Jeff Layton
2023-06-21 14:45 ` [PATCH 45/79] nfs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 46/79] nfsd: " Jeff Layton
2023-06-21 17:36 ` Chuck Lever
2023-06-21 14:46 ` [PATCH 47/79] nilfs2: " Jeff Layton
2023-06-21 14:46 ` Jeff Layton
2023-06-26 15:26 ` Ryusuke Konishi
2023-06-26 15:26 ` Ryusuke Konishi
2023-06-21 14:46 ` [PATCH 48/79] ntfs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 49/79] ntfs3: " Jeff Layton
2023-06-21 14:46 ` [Ocfs2-devel] [PATCH 50/79] ocfs2: " Jeff Layton via Ocfs2-devel
2023-06-21 14:46 ` Jeff Layton
2023-06-21 14:46 ` [PATCH 51/79] omfs: " Jeff Layton
2023-06-23 12:12 ` Bob Copeland
2023-06-21 14:46 ` [PATCH 52/79] openpromfs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 53/79] orangefs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 54/79] overlayfs: " Jeff Layton
2023-06-22 6:44 ` Amir Goldstein
2023-06-21 14:46 ` [PATCH 55/79] proc: " Jeff Layton
2023-06-30 22:13 ` Luis Chamberlain
2023-06-21 14:46 ` [PATCH 56/79] pstore: " Jeff Layton
2023-06-21 17:50 ` Kees Cook
2023-06-21 14:46 ` [PATCH 57/79] qnx4: " Jeff Layton
2023-06-23 14:26 ` Anders Larsen
2023-06-21 14:46 ` [PATCH 58/79] qnx6: " Jeff Layton
2023-06-21 14:46 ` [PATCH 59/79] ramfs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 60/79] reiserfs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 61/79] romfs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 62/79] smb: " Jeff Layton
2023-06-21 17:45 ` Tom Talpey
2023-06-23 5:03 ` Sergey Senozhatsky
2023-06-21 14:46 ` [PATCH 63/79] squashfs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 64/79] sysv: " Jeff Layton
2023-06-21 14:46 ` [PATCH 65/79] tracefs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 66/79] ubifs: " Jeff Layton
2023-06-21 14:46 ` Jeff Layton
2023-06-21 14:46 ` [PATCH 67/79] udf: " Jeff Layton
2023-06-21 14:46 ` [PATCH 68/79] ufs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 69/79] vboxsf: " Jeff Layton
2023-06-21 14:46 ` [PATCH 70/79] xfs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 71/79] zonefs: " Jeff Layton
2023-06-22 0:48 ` Damien Le Moal
2023-06-21 14:46 ` [PATCH 72/79] mqueue: " Jeff Layton
2023-06-21 14:46 ` [PATCH 73/79] bpf: " Jeff Layton
2023-06-21 14:46 ` [PATCH 74/79] shmem: " Jeff Layton
2023-06-21 14:46 ` [PATCH 75/79] rpc_pipefs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 76/79] apparmor: " Jeff Layton
2023-06-22 9:04 ` John Johansen
2023-06-21 14:46 ` [PATCH 77/79] security: " Jeff Layton
2023-06-23 14:15 ` Paul Moore
2023-06-21 14:46 ` [PATCH 78/79] selinux: " Jeff Layton
2023-06-23 14:17 ` Paul Moore
2023-06-21 16:34 ` [PATCH 02/79] spufs: " Jan Kara
2023-06-21 16:34 ` Jan Kara
2023-06-22 0:19 ` Jeremy Kerr
2023-06-22 0:19 ` Jeremy Kerr
2023-06-21 14:49 ` [PATCH 79/79] fs: rename i_ctime field to __i_ctime Jeff Layton
2023-06-21 14:49 ` [Cluster-devel] " Jeff Layton
2023-06-21 14:49 ` [Ocfs2-devel] " Jeff Layton via Ocfs2-devel
2023-06-21 14:49 ` [f2fs-dev] " Jeff Layton
2023-06-21 19:21 ` [PATCH 00/79] fs: new accessors for inode->i_ctime Steven Rostedt
2023-06-21 19:21 ` Steven Rostedt
2023-06-21 19:21 ` [Cluster-devel] " Steven Rostedt
2023-06-21 19:21 ` Steven Rostedt
2023-06-21 19:21 ` Steven Rostedt
2023-06-21 19:21 ` [Ocfs2-devel] " Steven Rostedt via Ocfs2-devel
2023-06-21 19:21 ` [f2fs-dev] " Steven Rostedt
2023-06-21 19:52 ` Jeff Layton
2023-06-21 19:52 ` Jeff Layton
2023-06-21 19:52 ` [Cluster-devel] " Jeff Layton
2023-06-21 19:52 ` [Ocfs2-devel] " Jeff Layton via Ocfs2-devel
2023-06-21 19:52 ` Jeff Layton
2023-06-21 19:52 ` Jeff Layton
2023-06-21 19:52 ` [f2fs-dev] " Jeff Layton
2023-06-23 12:41 ` Christian Brauner
2023-06-23 12:41 ` Christian Brauner
2023-06-23 12:41 ` [Cluster-devel] " Christian Brauner
2023-06-23 12:41 ` Christian Brauner
2023-06-23 12:41 ` Christian Brauner
2023-06-23 12:41 ` [Ocfs2-devel] " Christian Brauner via Ocfs2-devel
2023-06-23 12:41 ` [f2fs-dev] " Christian Brauner
2023-06-30 22:11 ` Luis Chamberlain
2023-06-30 22:11 ` Luis Chamberlain
2023-06-30 22:11 ` [Cluster-devel] " Luis Chamberlain
2023-06-30 22:11 ` Luis Chamberlain
2023-06-30 22:11 ` Luis Chamberlain
2023-06-30 22:11 ` [f2fs-dev] " Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='ad4bfb630128709588164db6f1fd2ef39c31d2a5.camel__9120.83277232654$1687428912$gmane$org@kernel.org' \
--to=jlayton-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=agordeev-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=arve-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
--cc=borntraeger-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org \
--cc=brauner-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=christophe.leroy-2tlSp11Fh4xulxpn9UvDqw@public.gmane.org \
--cc=cmllamas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=dlemoal-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=gor-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=hca-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org \
--cc=jk-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
--cc=joel-QYYGw3jwrUn5owFQY34kdNi2O/JbrIOy@public.gmane.org \
--cc=maco-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
--cc=mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org \
--cc=npiggin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=surenb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=svens-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org \
--cc=tkjos-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.