From: Jan Kara <jack@suse.cz> To: Jeff Layton <jlayton@kernel.org> Cc: Christian Brauner <brauner@kernel.org>, Jeremy Kerr <jk@ozlabs.org>, Arnd Bergmann <arnd@arndb.de>, Michael Ellerman <mpe@ellerman.id.au>, Nicholas Piggin <npiggin@gmail.com>, Christophe Leroy <christophe.leroy@csgroup.eu>, Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/79] spufs: switch to new ctime accessors Date: Wed, 21 Jun 2023 18:34:19 +0200 [thread overview] Message-ID: <20230621163419.adjsdbqoyebvymqc@quack3> (raw) In-Reply-To: <20230621144735.55953-1-jlayton@kernel.org> On Wed 21-06-23 10:45:15, Jeff Layton wrote: > In later patches, we're going to change how the ctime.tv_nsec field is > utilized. Switch to using accessor functions instead of raw accesses of > inode->i_ctime. > > Signed-off-by: Jeff Layton <jlayton@kernel.org> Looks good to me. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > arch/powerpc/platforms/cell/spufs/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/cell/spufs/inode.c b/arch/powerpc/platforms/cell/spufs/inode.c > index ea807aa0c31a..55418395bd9a 100644 > --- a/arch/powerpc/platforms/cell/spufs/inode.c > +++ b/arch/powerpc/platforms/cell/spufs/inode.c > @@ -86,7 +86,7 @@ spufs_new_inode(struct super_block *sb, umode_t mode) > inode->i_mode = mode; > inode->i_uid = current_fsuid(); > inode->i_gid = current_fsgid(); > - inode->i_atime = inode->i_mtime = inode->i_ctime = current_time(inode); > + inode->i_atime = inode->i_mtime = inode_ctime_set_current(inode); > out: > return inode; > } > -- > 2.41.0 > -- Jan Kara <jack@suse.com> SUSE Labs, CR
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz> To: Jeff Layton <jlayton@kernel.org> Cc: Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>, Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>, Nicholas Piggin <npiggin@gmail.com>, linuxppc-dev@lists.ozlabs.org, Jeremy Kerr <jk@ozlabs.org> Subject: Re: [PATCH 02/79] spufs: switch to new ctime accessors Date: Wed, 21 Jun 2023 18:34:19 +0200 [thread overview] Message-ID: <20230621163419.adjsdbqoyebvymqc@quack3> (raw) In-Reply-To: <20230621144735.55953-1-jlayton@kernel.org> On Wed 21-06-23 10:45:15, Jeff Layton wrote: > In later patches, we're going to change how the ctime.tv_nsec field is > utilized. Switch to using accessor functions instead of raw accesses of > inode->i_ctime. > > Signed-off-by: Jeff Layton <jlayton@kernel.org> Looks good to me. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > arch/powerpc/platforms/cell/spufs/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/cell/spufs/inode.c b/arch/powerpc/platforms/cell/spufs/inode.c > index ea807aa0c31a..55418395bd9a 100644 > --- a/arch/powerpc/platforms/cell/spufs/inode.c > +++ b/arch/powerpc/platforms/cell/spufs/inode.c > @@ -86,7 +86,7 @@ spufs_new_inode(struct super_block *sb, umode_t mode) > inode->i_mode = mode; > inode->i_uid = current_fsuid(); > inode->i_gid = current_fsgid(); > - inode->i_atime = inode->i_mtime = inode->i_ctime = current_time(inode); > + inode->i_atime = inode->i_mtime = inode_ctime_set_current(inode); > out: > return inode; > } > -- > 2.41.0 > -- Jan Kara <jack@suse.com> SUSE Labs, CR
next prev parent reply other threads:[~2023-06-21 16:35 UTC|newest] Thread overview: 229+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-06-21 14:45 [PATCH 00/79] fs: new accessors for inode->i_ctime Jeff Layton 2023-06-21 14:45 ` [Cluster-devel] " Jeff Layton 2023-06-21 14:45 ` [Ocfs2-devel] " Jeff Layton via Ocfs2-devel 2023-06-21 14:45 ` [f2fs-dev] " Jeff Layton 2023-06-21 14:45 ` [PATCH 01/79] fs: add ctime accessors infrastructure Jeff Layton 2023-06-21 14:45 ` [Cluster-devel] " Jeff Layton 2023-06-21 14:45 ` [Ocfs2-devel] " Jeff Layton via Ocfs2-devel 2023-06-21 14:45 ` [f2fs-dev] " Jeff Layton 2023-06-21 16:34 ` Jan Kara 2023-06-21 16:34 ` Jan Kara 2023-06-21 16:34 ` [Cluster-devel] " Jan Kara 2023-06-21 16:34 ` Jan Kara 2023-06-21 16:34 ` Jan Kara 2023-06-21 16:34 ` [Ocfs2-devel] " Jan Kara via Ocfs2-devel 2023-06-21 16:34 ` [f2fs-dev] " Jan Kara 2023-06-21 17:29 ` Tom Talpey 2023-06-21 17:29 ` [Cluster-devel] " Tom Talpey 2023-06-21 17:29 ` [f2fs-dev] " Tom Talpey 2023-06-21 17:29 ` [Ocfs2-devel] " Tom Talpey via Ocfs2-devel 2023-06-21 18:01 ` Jeff Layton 2023-06-21 18:01 ` [Cluster-devel] " Jeff Layton 2023-06-21 18:01 ` [Ocfs2-devel] " Jeff Layton via Ocfs2-devel 2023-06-21 18:01 ` [f2fs-dev] " Jeff Layton 2023-06-21 18:19 ` Tom Talpey 2023-06-21 18:19 ` [Cluster-devel] " Tom Talpey 2023-06-21 18:19 ` [Ocfs2-devel] " Tom Talpey via Ocfs2-devel 2023-06-21 18:19 ` [f2fs-dev] " Tom Talpey 2023-06-21 18:48 ` Jeff Layton 2023-06-21 18:48 ` [Cluster-devel] " Jeff Layton 2023-06-21 18:48 ` [Ocfs2-devel] " Jeff Layton via Ocfs2-devel 2023-06-21 18:48 ` [f2fs-dev] " Jeff Layton 2023-06-22 0:46 ` Damien Le Moal 2023-06-22 0:46 ` [Cluster-devel] " Damien Le Moal 2023-06-22 0:46 ` [Ocfs2-devel] " Damien Le Moal via Ocfs2-devel 2023-06-22 0:46 ` [f2fs-dev] " Damien Le Moal 2023-06-22 10:14 ` Jeff Layton 2023-06-22 10:14 ` [Cluster-devel] " Jeff Layton 2023-06-22 10:14 ` [Ocfs2-devel] " Jeff Layton via Ocfs2-devel 2023-06-22 10:14 ` [f2fs-dev] " Jeff Layton [not found] ` <99b3c749-23d9-6f09-fb75-6a84f3d1b066-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2023-06-22 10:14 ` Jeff Layton 2023-06-22 10:14 ` Jeff Layton 2023-06-30 22:12 ` Luis Chamberlain 2023-06-30 22:12 ` Luis Chamberlain 2023-06-30 22:12 ` [Cluster-devel] " Luis Chamberlain 2023-06-30 22:12 ` Luis Chamberlain 2023-06-30 22:12 ` Luis Chamberlain 2023-06-30 22:12 ` [f2fs-dev] " Luis Chamberlain [not found] ` <20230621144507.55591-2-jlayton-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2023-07-12 15:31 ` Randy Dunlap 2023-07-12 15:31 ` Randy Dunlap 2023-07-12 15:31 ` [Cluster-devel] " Randy Dunlap 2023-07-12 15:31 ` Randy Dunlap 2023-07-12 15:31 ` Randy Dunlap 2023-07-12 15:34 ` Christian Brauner 2023-07-12 15:34 ` Christian Brauner 2023-07-12 15:31 ` Randy Dunlap 2023-06-21 14:45 ` [PATCH 02/79] spufs: switch to new ctime accessors Jeff Layton 2023-06-21 14:45 ` Jeff Layton 2023-06-21 14:45 ` [PATCH 03/79] s390: " Jeff Layton 2023-06-21 16:34 ` Jan Kara 2023-06-22 17:35 ` Alexander Gordeev 2023-06-22 17:51 ` Jeff Layton 2023-06-22 18:22 ` Alexander Gordeev 2023-06-22 18:46 ` Jeff Layton 2023-06-21 14:45 ` [PATCH 04/79] binderfs: " Jeff Layton 2023-06-21 15:29 ` Greg Kroah-Hartman 2023-06-21 16:35 ` Jan Kara 2023-06-21 14:45 ` [PATCH 05/79] qib_fs: " Jeff Layton 2023-06-21 16:35 ` Jan Kara 2023-06-21 19:37 ` Dennis Dalessandro 2023-06-21 14:45 ` [PATCH 06/79] ibm: " Jeff Layton 2023-06-21 15:29 ` Greg Kroah-Hartman 2023-06-21 16:35 ` Jan Kara 2023-06-21 14:45 ` [PATCH 07/79] usb: " Jeff Layton 2023-06-21 15:29 ` Greg Kroah-Hartman 2023-06-21 16:36 ` Jan Kara 2023-06-21 14:45 ` [PATCH 08/79] 9p: " Jeff Layton 2023-06-21 16:37 ` Jan Kara 2023-06-21 14:45 ` [PATCH 09/79] adfs: " Jeff Layton 2023-06-21 16:38 ` Jan Kara 2023-06-21 14:45 ` [PATCH 10/79] affs: " Jeff Layton 2023-06-21 16:39 ` Jan Kara 2023-06-22 11:37 ` David Sterba 2023-06-21 14:45 ` [PATCH 11/79] afs: " Jeff Layton 2023-06-21 16:43 ` Jan Kara 2023-06-21 14:45 ` [PATCH 12/79] fs: " Jeff Layton 2023-06-21 16:42 ` Jan Kara 2023-06-21 14:45 ` [PATCH 13/79] autofs: " Jeff Layton 2023-06-21 16:43 ` Jan Kara 2023-06-27 1:48 ` Ian Kent 2023-06-21 14:45 ` [PATCH 14/79] befs: " Jeff Layton 2023-06-21 16:44 ` Jan Kara 2023-06-21 14:45 ` [PATCH 15/79] bfs: " Jeff Layton 2023-06-21 16:48 ` Jan Kara 2023-06-21 16:57 ` Jeff Layton 2023-06-22 12:30 ` Jan Kara 2023-06-22 12:51 ` Jeff Layton 2023-06-22 14:57 ` Jan Kara 2023-06-23 12:33 ` Christian Brauner 2023-07-03 10:12 ` Christian Brauner 2023-07-03 10:46 ` Jeff Layton 2023-07-03 10:57 ` Christian Brauner 2023-06-21 14:45 ` [PATCH 16/79] btrfs: " Jeff Layton 2023-06-22 11:42 ` David Sterba 2023-06-21 14:45 ` [PATCH 17/79] ceph: " Jeff Layton 2023-06-26 0:56 ` Xiubo Li 2023-06-21 14:45 ` [PATCH 18/79] coda: " Jeff Layton 2023-06-21 14:45 ` [PATCH 19/79] configfs: " Jeff Layton 2023-06-21 14:45 ` [PATCH 20/79] cramfs: " Jeff Layton 2023-06-21 15:29 ` Nicolas Pitre 2023-06-21 14:45 ` [PATCH 21/79] debugfs: " Jeff Layton 2023-06-21 15:29 ` Greg Kroah-Hartman 2023-06-21 14:45 ` [PATCH 22/79] devpts: " Jeff Layton 2023-06-21 14:45 ` [PATCH 23/79] ecryptfs: " Jeff Layton 2023-06-21 14:45 ` [PATCH 24/79] efivarfs: " Jeff Layton 2023-06-21 14:45 ` [PATCH 25/79] efs: " Jeff Layton 2023-06-21 14:45 ` [PATCH 26/79] erofs: " Jeff Layton 2023-06-21 14:45 ` Jeff Layton 2023-06-22 4:01 ` Gao Xiang 2023-06-22 4:01 ` Gao Xiang 2023-06-21 14:45 ` [PATCH 27/79] exfat: " Jeff Layton 2023-06-21 14:45 ` [PATCH 28/79] ext2: " Jeff Layton 2023-06-21 14:45 ` [PATCH 29/79] ext4: " Jeff Layton 2023-06-21 14:45 ` [f2fs-dev] [PATCH 30/79] f2fs: " Jeff Layton 2023-06-21 14:45 ` Jeff Layton 2023-06-21 14:45 ` [PATCH 31/79] fat: " Jeff Layton 2023-06-21 14:45 ` [PATCH 32/79] freevxfs: " Jeff Layton 2023-06-21 14:45 ` [PATCH 33/79] fuse: " Jeff Layton 2023-06-21 14:45 ` [PATCH 34/79] gfs2: " Jeff Layton 2023-06-21 14:45 ` [Cluster-devel] " Jeff Layton 2023-06-21 14:45 ` [PATCH 35/79] hfs: " Jeff Layton 2023-06-21 14:45 ` [PATCH 36/79] hfsplus: " Jeff Layton 2023-06-21 14:45 ` [PATCH 37/79] hostfs: " Jeff Layton 2023-06-21 14:45 ` Jeff Layton 2023-06-21 14:45 ` [PATCH 38/79] hpfs: " Jeff Layton 2023-06-21 14:45 ` [PATCH 39/79] hugetlbfs: " Jeff Layton 2023-06-21 14:45 ` [PATCH 40/79] isofs: " Jeff Layton 2023-06-21 14:45 ` [PATCH 41/79] jffs2: " Jeff Layton 2023-06-21 14:45 ` Jeff Layton 2023-06-21 14:45 ` [PATCH 42/79] jfs: " Jeff Layton 2023-06-21 17:47 ` Dave Kleikamp 2023-06-21 14:45 ` [PATCH 43/79] kernfs: " Jeff Layton 2023-06-21 15:30 ` Greg Kroah-Hartman 2023-06-21 14:45 ` [PATCH 44/79] minix: " Jeff Layton 2023-06-21 14:45 ` [PATCH 45/79] nfs: " Jeff Layton 2023-06-21 14:45 ` [PATCH 46/79] nfsd: " Jeff Layton 2023-06-21 17:36 ` Chuck Lever 2023-06-21 14:46 ` [PATCH 47/79] nilfs2: " Jeff Layton 2023-06-21 14:46 ` Jeff Layton 2023-06-26 15:26 ` Ryusuke Konishi 2023-06-26 15:26 ` Ryusuke Konishi 2023-06-21 14:46 ` [PATCH 48/79] ntfs: " Jeff Layton 2023-06-21 14:46 ` [PATCH 49/79] ntfs3: " Jeff Layton 2023-06-21 14:46 ` [Ocfs2-devel] [PATCH 50/79] ocfs2: " Jeff Layton via Ocfs2-devel 2023-06-21 14:46 ` Jeff Layton 2023-06-21 14:46 ` [PATCH 51/79] omfs: " Jeff Layton 2023-06-23 12:12 ` Bob Copeland 2023-06-21 14:46 ` [PATCH 52/79] openpromfs: " Jeff Layton 2023-06-21 14:46 ` [PATCH 53/79] orangefs: " Jeff Layton 2023-06-21 14:46 ` [PATCH 54/79] overlayfs: " Jeff Layton 2023-06-22 6:44 ` Amir Goldstein 2023-06-21 14:46 ` [PATCH 55/79] proc: " Jeff Layton 2023-06-30 22:13 ` Luis Chamberlain 2023-06-21 14:46 ` [PATCH 56/79] pstore: " Jeff Layton 2023-06-21 17:50 ` Kees Cook 2023-06-21 14:46 ` [PATCH 57/79] qnx4: " Jeff Layton 2023-06-23 14:26 ` Anders Larsen 2023-06-21 14:46 ` [PATCH 58/79] qnx6: " Jeff Layton 2023-06-21 14:46 ` [PATCH 59/79] ramfs: " Jeff Layton 2023-06-21 14:46 ` [PATCH 60/79] reiserfs: " Jeff Layton 2023-06-21 14:46 ` [PATCH 61/79] romfs: " Jeff Layton 2023-06-21 14:46 ` [PATCH 62/79] smb: " Jeff Layton 2023-06-21 17:45 ` Tom Talpey 2023-06-23 5:03 ` Sergey Senozhatsky 2023-06-21 14:46 ` [PATCH 63/79] squashfs: " Jeff Layton 2023-06-21 14:46 ` [PATCH 64/79] sysv: " Jeff Layton 2023-06-21 14:46 ` [PATCH 65/79] tracefs: " Jeff Layton 2023-06-21 14:46 ` [PATCH 66/79] ubifs: " Jeff Layton 2023-06-21 14:46 ` Jeff Layton 2023-06-21 14:46 ` [PATCH 67/79] udf: " Jeff Layton 2023-06-21 14:46 ` [PATCH 68/79] ufs: " Jeff Layton 2023-06-21 14:46 ` [PATCH 69/79] vboxsf: " Jeff Layton 2023-06-21 14:46 ` [PATCH 70/79] xfs: " Jeff Layton 2023-06-21 14:46 ` [PATCH 71/79] zonefs: " Jeff Layton 2023-06-22 0:48 ` Damien Le Moal 2023-06-21 14:46 ` [PATCH 72/79] mqueue: " Jeff Layton 2023-06-21 14:46 ` [PATCH 73/79] bpf: " Jeff Layton 2023-06-21 14:46 ` [PATCH 74/79] shmem: " Jeff Layton 2023-06-21 14:46 ` [PATCH 75/79] rpc_pipefs: " Jeff Layton 2023-06-21 14:46 ` [PATCH 76/79] apparmor: " Jeff Layton 2023-06-22 9:04 ` John Johansen 2023-06-21 14:46 ` [PATCH 77/79] security: " Jeff Layton 2023-06-23 14:15 ` Paul Moore 2023-06-21 14:46 ` [PATCH 78/79] selinux: " Jeff Layton 2023-06-23 14:17 ` Paul Moore 2023-06-21 16:34 ` Jan Kara [this message] 2023-06-21 16:34 ` [PATCH 02/79] spufs: " Jan Kara 2023-06-22 0:19 ` Jeremy Kerr 2023-06-22 0:19 ` Jeremy Kerr 2023-06-21 14:49 ` [PATCH 79/79] fs: rename i_ctime field to __i_ctime Jeff Layton 2023-06-21 14:49 ` [Cluster-devel] " Jeff Layton 2023-06-21 14:49 ` [Ocfs2-devel] " Jeff Layton via Ocfs2-devel 2023-06-21 14:49 ` [f2fs-dev] " Jeff Layton 2023-06-21 19:21 ` [PATCH 00/79] fs: new accessors for inode->i_ctime Steven Rostedt 2023-06-21 19:21 ` Steven Rostedt 2023-06-21 19:21 ` [Cluster-devel] " Steven Rostedt 2023-06-21 19:21 ` Steven Rostedt 2023-06-21 19:21 ` Steven Rostedt 2023-06-21 19:21 ` [Ocfs2-devel] " Steven Rostedt via Ocfs2-devel 2023-06-21 19:21 ` [f2fs-dev] " Steven Rostedt 2023-06-21 19:52 ` Jeff Layton 2023-06-21 19:52 ` Jeff Layton 2023-06-21 19:52 ` [Cluster-devel] " Jeff Layton 2023-06-21 19:52 ` [Ocfs2-devel] " Jeff Layton via Ocfs2-devel 2023-06-21 19:52 ` Jeff Layton 2023-06-21 19:52 ` Jeff Layton 2023-06-21 19:52 ` [f2fs-dev] " Jeff Layton 2023-06-23 12:41 ` Christian Brauner 2023-06-23 12:41 ` Christian Brauner 2023-06-23 12:41 ` [Cluster-devel] " Christian Brauner 2023-06-23 12:41 ` Christian Brauner 2023-06-23 12:41 ` Christian Brauner 2023-06-23 12:41 ` [Ocfs2-devel] " Christian Brauner via Ocfs2-devel 2023-06-23 12:41 ` [f2fs-dev] " Christian Brauner 2023-06-30 22:11 ` Luis Chamberlain 2023-06-30 22:11 ` Luis Chamberlain 2023-06-30 22:11 ` [Cluster-devel] " Luis Chamberlain 2023-06-30 22:11 ` Luis Chamberlain 2023-06-30 22:11 ` Luis Chamberlain 2023-06-30 22:11 ` [f2fs-dev] " Luis Chamberlain
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230621163419.adjsdbqoyebvymqc@quack3 \ --to=jack@suse.cz \ --cc=arnd@arndb.de \ --cc=brauner@kernel.org \ --cc=christophe.leroy@csgroup.eu \ --cc=jk@ozlabs.org \ --cc=jlayton@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpe@ellerman.id.au \ --cc=npiggin@gmail.com \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.