From: Jan Kiszka <jan.kiszka@siemens.com>
To: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: [PATCH 06/13] Synchronize VCPU states before reset
Date: Tue, 15 Feb 2011 09:23:30 +0100 [thread overview]
Message-ID: <ad8fc94985ab2a5dea0b43d45f2159be739c9ac3.1297758211.git.jan.kiszka@siemens.com> (raw)
In-Reply-To: <cover.1297758211.git.jan.kiszka@siemens.com>
In-Reply-To: <cover.1297758211.git.jan.kiszka@siemens.com>
This is required to support keeping VCPU states across a system reset.
If we do not read the current state before the reset,
cpu_synchronize_all_post_reset may write back incorrect state
information.
The first user of this will be MCE MSR synchronization which currently
works around the missing cpu_synchronize_all_states.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
vl.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/vl.c b/vl.c
index b436952..7751843 100644
--- a/vl.c
+++ b/vl.c
@@ -1452,6 +1452,7 @@ static void main_loop(void)
}
if (qemu_reset_requested()) {
pause_all_vcpus();
+ cpu_synchronize_all_states();
qemu_system_reset();
resume_all_vcpus();
}
--
1.7.1
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] [PATCH 06/13] Synchronize VCPU states before reset
Date: Tue, 15 Feb 2011 09:23:30 +0100 [thread overview]
Message-ID: <ad8fc94985ab2a5dea0b43d45f2159be739c9ac3.1297758211.git.jan.kiszka@siemens.com> (raw)
In-Reply-To: <cover.1297758211.git.jan.kiszka@siemens.com>
In-Reply-To: <cover.1297758211.git.jan.kiszka@siemens.com>
This is required to support keeping VCPU states across a system reset.
If we do not read the current state before the reset,
cpu_synchronize_all_post_reset may write back incorrect state
information.
The first user of this will be MCE MSR synchronization which currently
works around the missing cpu_synchronize_all_states.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
vl.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/vl.c b/vl.c
index b436952..7751843 100644
--- a/vl.c
+++ b/vl.c
@@ -1452,6 +1452,7 @@ static void main_loop(void)
}
if (qemu_reset_requested()) {
pause_all_vcpus();
+ cpu_synchronize_all_states();
qemu_system_reset();
resume_all_vcpus();
}
--
1.7.1
next prev parent reply other threads:[~2011-02-15 8:23 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 8:23 [PATCH 00/13] [uq/master] Patch queue, part IV (MCE edition) Jan Kiszka
2011-02-15 8:23 ` [Qemu-devel] " Jan Kiszka
2011-02-15 8:23 ` [PATCH 01/13] x86: Account for MCE in cpu_has_work Jan Kiszka
2011-02-15 8:23 ` [Qemu-devel] " Jan Kiszka
2011-02-15 8:23 ` [PATCH 02/13] x86: Perform implicit mcg_status reset Jan Kiszka
2011-02-15 8:23 ` [Qemu-devel] " Jan Kiszka
2011-02-15 8:23 ` [PATCH 03/13] x86: Small cleanups of MCE helpers Jan Kiszka
2011-02-15 8:23 ` [Qemu-devel] " Jan Kiszka
2011-02-15 8:23 ` [PATCH 04/13] x86: Refine error reporting of MCE injection services Jan Kiszka
2011-02-15 8:23 ` [Qemu-devel] " Jan Kiszka
2011-02-15 8:23 ` [PATCH 05/13] x86: Optionally avoid injecting AO MCEs while others are pending Jan Kiszka
2011-02-15 8:23 ` [Qemu-devel] " Jan Kiszka
2011-02-15 8:23 ` Jan Kiszka [this message]
2011-02-15 8:23 ` [Qemu-devel] [PATCH 06/13] Synchronize VCPU states before reset Jan Kiszka
2011-02-15 8:23 ` [PATCH 07/13] kvm: x86: Move MCE functions together Jan Kiszka
2011-02-15 8:23 ` [Qemu-devel] " Jan Kiszka
2011-02-15 8:23 ` [PATCH 08/13] kvm: x86: Inject pending MCE events on state writeback Jan Kiszka
2011-02-15 8:23 ` [Qemu-devel] " Jan Kiszka
2011-02-17 16:35 ` Marcelo Tosatti
2011-02-17 16:35 ` [Qemu-devel] " Marcelo Tosatti
2011-02-17 17:06 ` Jan Kiszka
2011-02-17 17:06 ` [Qemu-devel] " Jan Kiszka
2011-02-17 17:55 ` Marcelo Tosatti
2011-02-17 17:55 ` [Qemu-devel] " Marcelo Tosatti
2011-02-17 18:04 ` Jan Kiszka
2011-02-17 18:04 ` [Qemu-devel] " Jan Kiszka
2011-02-17 18:17 ` Marcelo Tosatti
2011-02-17 18:17 ` [Qemu-devel] " Marcelo Tosatti
2011-02-15 8:23 ` [PATCH 09/13] kvm: x86: Consolidate TCG and KVM MCE injection code Jan Kiszka
2011-02-15 8:23 ` [Qemu-devel] " Jan Kiszka
2011-02-17 18:08 ` Marcelo Tosatti
2011-02-17 18:08 ` [Qemu-devel] " Marcelo Tosatti
2011-02-17 18:17 ` Jan Kiszka
2011-02-17 18:17 ` [Qemu-devel] " Jan Kiszka
2011-02-15 8:23 ` [PATCH 10/13] kvm: x86: Clean up kvm_setup_mce Jan Kiszka
2011-02-15 8:23 ` [Qemu-devel] " Jan Kiszka
2011-02-15 8:23 ` [PATCH 11/13] kvm: x86: Fail kvm_arch_init_vcpu if MCE initialization fails Jan Kiszka
2011-02-15 8:23 ` [Qemu-devel] " Jan Kiszka
2011-02-15 8:23 ` [PATCH 12/13] Add qemu_ram_remap Jan Kiszka
2011-02-15 8:23 ` [Qemu-devel] " Jan Kiszka
2011-02-15 8:23 ` [PATCH 13/13] KVM, MCE, unpoison memory address across reboot Jan Kiszka
2011-02-15 8:23 ` [Qemu-devel] " Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad8fc94985ab2a5dea0b43d45f2159be739c9ac3.1297758211.git.jan.kiszka@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.