From: "Sierra Guiza, Alejandro (Alex)" <alex.sierra@amd.com>
To: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>
Cc: jgg@nvidia.com, Felix.Kuehling@amd.com, linux-mm@kvack.org,
rcampbell@nvidia.com, linux-ext4@vger.kernel.org,
linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, hch@lst.de, jglisse@redhat.com,
apopple@nvidia.com, willy@infradead.org
Subject: Re: [PATCH v9 06/14] mm/gup: migrate device coherent pages when pinning instead of failing
Date: Mon, 25 Jul 2022 21:22:06 -0500 [thread overview]
Message-ID: <adb2031b-774d-e645-2aec-f9de433b0a7c@amd.com> (raw)
In-Reply-To: <20220718133235.4fdbd6ec303219e5a3ba49cf@linux-foundation.org>
On 7/18/2022 3:32 PM, Andrew Morton wrote:
> On Mon, 18 Jul 2022 12:56:29 +0200 David Hildenbrand <david@redhat.com> wrote:
>
>>> /*
>>> * Try to move out any movable page before pinning the range.
>>> */
>>> @@ -1919,7 +1948,8 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages,
>>> folio_nr_pages(folio));
>>> }
>>>
>>> - if (!list_empty(&movable_page_list) || isolation_error_count)
>>> + if (!list_empty(&movable_page_list) || isolation_error_count
>>> + || coherent_pages)
>> The common style is to
>>
>> a) add the || to the end of the previous line
>> b) indent such the we have a nice-to-read alignment
>>
>> if (!list_empty(&movable_page_list) || isolation_error_count ||
>> coherent_pages)
>>
> I missed that. This series is now in mm-stable so any fix will need to
> be a standalone followup patch, please.
Hi Andrew,
Just wanted to make sure nothing is missing from our side to merge this
patch series.
Regards,
Alex Sierra
>
>> Apart from that lgtm.
>>
>> Reviewed-by: David Hildenbrand <david@redhat.com>
> And your reviewed-by's will be lost. Stupid git.
WARNING: multiple messages have this Message-ID (diff)
From: "Sierra Guiza, Alejandro (Alex)" <alex.sierra@amd.com>
To: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>
Cc: rcampbell@nvidia.com, willy@infradead.org,
Felix.Kuehling@amd.com, apopple@nvidia.com,
amd-gfx@lists.freedesktop.org, linux-xfs@vger.kernel.org,
linux-mm@kvack.org, jglisse@redhat.com,
dri-devel@lists.freedesktop.org, jgg@nvidia.com,
linux-ext4@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH v9 06/14] mm/gup: migrate device coherent pages when pinning instead of failing
Date: Mon, 25 Jul 2022 21:22:06 -0500 [thread overview]
Message-ID: <adb2031b-774d-e645-2aec-f9de433b0a7c@amd.com> (raw)
In-Reply-To: <20220718133235.4fdbd6ec303219e5a3ba49cf@linux-foundation.org>
On 7/18/2022 3:32 PM, Andrew Morton wrote:
> On Mon, 18 Jul 2022 12:56:29 +0200 David Hildenbrand <david@redhat.com> wrote:
>
>>> /*
>>> * Try to move out any movable page before pinning the range.
>>> */
>>> @@ -1919,7 +1948,8 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages,
>>> folio_nr_pages(folio));
>>> }
>>>
>>> - if (!list_empty(&movable_page_list) || isolation_error_count)
>>> + if (!list_empty(&movable_page_list) || isolation_error_count
>>> + || coherent_pages)
>> The common style is to
>>
>> a) add the || to the end of the previous line
>> b) indent such the we have a nice-to-read alignment
>>
>> if (!list_empty(&movable_page_list) || isolation_error_count ||
>> coherent_pages)
>>
> I missed that. This series is now in mm-stable so any fix will need to
> be a standalone followup patch, please.
Hi Andrew,
Just wanted to make sure nothing is missing from our side to merge this
patch series.
Regards,
Alex Sierra
>
>> Apart from that lgtm.
>>
>> Reviewed-by: David Hildenbrand <david@redhat.com>
> And your reviewed-by's will be lost. Stupid git.
next prev parent reply other threads:[~2022-07-26 2:22 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 15:05 [PATCH v9 00/14] Add MEMORY_DEVICE_COHERENT for coherent device memory mapping Alex Sierra
2022-07-15 15:05 ` Alex Sierra
2022-07-15 15:05 ` [PATCH v9 01/14] mm: rename is_pinnable_pages to is_longterm_pinnable_pages Alex Sierra
2022-07-15 15:05 ` Alex Sierra
2022-07-15 15:05 ` [PATCH v9 02/14] mm: move page zone helpers from mm.h to mmzone.h Alex Sierra
2022-07-15 15:05 ` Alex Sierra
2022-07-18 10:50 ` David Hildenbrand
2022-07-18 10:50 ` David Hildenbrand
2022-07-18 17:52 ` Felix Kuehling
2022-07-18 17:52 ` Felix Kuehling
2022-07-18 18:46 ` David Hildenbrand
2022-07-18 18:46 ` David Hildenbrand
2023-06-15 19:33 ` Peter Xu
2023-06-15 19:33 ` Peter Xu
2023-06-15 20:15 ` Matthew Wilcox
2023-06-15 20:15 ` Matthew Wilcox
2023-06-15 20:48 ` Peter Xu
2023-06-15 20:48 ` Peter Xu
2022-07-15 15:05 ` [PATCH v9 03/14] mm: add zone device coherent type memory support Alex Sierra
2022-07-15 15:05 ` Alex Sierra
2022-07-15 15:05 ` [PATCH v9 04/14] mm: handling Non-LRU pages returned by vm_normal_pages Alex Sierra
2022-07-15 15:05 ` Alex Sierra
2022-07-18 10:51 ` David Hildenbrand
2022-07-18 10:51 ` David Hildenbrand
2022-07-15 15:05 ` [PATCH v9 05/14] mm: add device coherent vma selection for memory migration Alex Sierra
2022-07-15 15:05 ` Alex Sierra
2022-07-15 15:05 ` [PATCH v9 06/14] mm/gup: migrate device coherent pages when pinning instead of failing Alex Sierra
2022-07-15 15:05 ` Alex Sierra
2022-07-18 10:56 ` David Hildenbrand
2022-07-18 10:56 ` David Hildenbrand
2022-07-18 20:32 ` Andrew Morton
2022-07-18 20:32 ` Andrew Morton
2022-07-19 8:40 ` David Hildenbrand
2022-07-19 8:40 ` David Hildenbrand
2022-07-26 2:22 ` Sierra Guiza, Alejandro (Alex) [this message]
2022-07-26 2:22 ` Sierra Guiza, Alejandro (Alex)
2022-07-26 19:05 ` Andrew Morton
2022-07-26 19:05 ` Andrew Morton
2022-07-15 15:05 ` [PATCH v9 07/14] drm/amdkfd: add SPM support for SVM Alex Sierra
2022-07-15 15:05 ` Alex Sierra
2022-07-15 15:05 ` [PATCH v9 08/14] lib: test_hmm add ioctl to get zone device type Alex Sierra
2022-07-15 15:05 ` Alex Sierra
2022-07-15 15:05 ` [PATCH v9 09/14] lib: test_hmm add module param for " Alex Sierra
2022-07-15 15:05 ` Alex Sierra
2022-07-15 15:05 ` [PATCH v9 10/14] lib: add support for device coherent type in test_hmm Alex Sierra
2022-07-15 15:05 ` Alex Sierra
2022-07-15 15:05 ` [PATCH v9 11/14] tools: update hmm-test to support device coherent type Alex Sierra
2022-07-15 15:05 ` Alex Sierra
2022-07-15 15:05 ` [PATCH v9 12/14] tools: update test_hmm script to support SP config Alex Sierra
2022-07-15 15:05 ` Alex Sierra
2022-07-15 15:05 ` [PATCH v9 13/14] tools: add hmm gup tests for device coherent type Alex Sierra
2022-07-15 15:05 ` Alex Sierra
2022-07-15 15:05 ` [PATCH v9 14/14] tools: add selftests to hmm for COW in device memory Alex Sierra
2022-07-15 15:05 ` Alex Sierra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adb2031b-774d-e645-2aec-f9de433b0a7c@amd.com \
--to=alex.sierra@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=akpm@linux-foundation.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=apopple@nvidia.com \
--cc=david@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=jgg@nvidia.com \
--cc=jglisse@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=rcampbell@nvidia.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.