From: Helge Deller <deller@gmx.de> To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>, "Niklas Schnelle" <schnelle@linux.ibm.com> Cc: "Arnd Bergmann" <arnd@arndb.de>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, "Bjorn Helgaas" <bhelgaas@google.com>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>, "Mauro Carvalho Chehab" <mchehab@kernel.org>, "Alan Stern" <stern@rowland.harvard.edu>, "Rafael J. Wysocki" <rafael@kernel.org>, "Geert Uytterhoeven" <geert@linux-m68k.org>, "Paul Walmsley" <paul.walmsley@sifive.com>, "Palmer Dabbelt" <palmer@dabbelt.com>, "Albert Ou" <aou@eecs.berkeley.edu>, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-pci@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v4 37/41] fbdev: atyfb: Remove unused clock determination Date: Fri, 19 May 2023 16:49:22 +0200 [thread overview] Message-ID: <ade998d7-abd7-3514-a8d4-25c3ec71b171@gmx.de> (raw) In-Reply-To: <ZGN2FKSBkMREujgR@intel.com> On 5/16/23 14:24, Ville Syrjälä wrote: > On Tue, May 16, 2023 at 01:00:33PM +0200, Niklas Schnelle wrote: >> Just below the removed lines par->clk_wr_offset is hard coded to 3 so >> there is no use in determining a different clock just to then ignore it >> anyway. This also removes the only I/O port use remaining in the driver >> allowing it to be built without CONFIG_HAS_IOPORT. >> >> Link: https://lore.kernel.org/all/ZBx5aLo5h546BzBt@intel.com/ >> Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com> >> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com> > > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > >> --- >> Note: The HAS_IOPORT Kconfig option was added in v6.4-rc1 so >> per-subsystem patches may be applied independently applied this patch to fbdev git tree. Thanks! Helge >> >> drivers/video/fbdev/aty/atyfb_base.c | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c >> index b02e4e645035..cba2b113b28b 100644 >> --- a/drivers/video/fbdev/aty/atyfb_base.c >> +++ b/drivers/video/fbdev/aty/atyfb_base.c >> @@ -3498,11 +3498,6 @@ static int atyfb_setup_generic(struct pci_dev *pdev, struct fb_info *info, >> if (ret) >> goto atyfb_setup_generic_fail; >> #endif >> - if (!(aty_ld_le32(CRTC_GEN_CNTL, par) & CRTC_EXT_DISP_EN)) >> - par->clk_wr_offset = (inb(R_GENMO) & 0x0CU) >> 2; >> - else >> - par->clk_wr_offset = aty_ld_8(CLOCK_CNTL, par) & 0x03U; >> - >> /* according to ATI, we should use clock 3 for acelerated mode */ >> par->clk_wr_offset = 3; >> >> -- >> 2.39.2 >
WARNING: multiple messages have this Message-ID (diff)
From: Helge Deller <deller@gmx.de> To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>, "Niklas Schnelle" <schnelle@linux.ibm.com> Cc: linux-arch@vger.kernel.org, linux-fbdev@vger.kernel.org, "Albert Ou" <aou@eecs.berkeley.edu>, "Arnd Bergmann" <arnd@arndb.de>, "Rafael J. Wysocki" <rafael@kernel.org>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, "Paul Walmsley" <paul.walmsley@sifive.com>, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, "Alan Stern" <stern@rowland.harvard.edu>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>, "Bjorn Helgaas" <bhelgaas@google.com>, "Geert Uytterhoeven" <geert@linux-m68k.org>, "Mauro Carvalho Chehab" <mchehab@kernel.org>, "Palmer Dabbelt" <palmer@dabbelt.com> Subject: Re: [PATCH v4 37/41] fbdev: atyfb: Remove unused clock determination Date: Fri, 19 May 2023 16:49:22 +0200 [thread overview] Message-ID: <ade998d7-abd7-3514-a8d4-25c3ec71b171@gmx.de> (raw) In-Reply-To: <ZGN2FKSBkMREujgR@intel.com> On 5/16/23 14:24, Ville Syrjälä wrote: > On Tue, May 16, 2023 at 01:00:33PM +0200, Niklas Schnelle wrote: >> Just below the removed lines par->clk_wr_offset is hard coded to 3 so >> there is no use in determining a different clock just to then ignore it >> anyway. This also removes the only I/O port use remaining in the driver >> allowing it to be built without CONFIG_HAS_IOPORT. >> >> Link: https://lore.kernel.org/all/ZBx5aLo5h546BzBt@intel.com/ >> Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com> >> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com> > > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > >> --- >> Note: The HAS_IOPORT Kconfig option was added in v6.4-rc1 so >> per-subsystem patches may be applied independently applied this patch to fbdev git tree. Thanks! Helge >> >> drivers/video/fbdev/aty/atyfb_base.c | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c >> index b02e4e645035..cba2b113b28b 100644 >> --- a/drivers/video/fbdev/aty/atyfb_base.c >> +++ b/drivers/video/fbdev/aty/atyfb_base.c >> @@ -3498,11 +3498,6 @@ static int atyfb_setup_generic(struct pci_dev *pdev, struct fb_info *info, >> if (ret) >> goto atyfb_setup_generic_fail; >> #endif >> - if (!(aty_ld_le32(CRTC_GEN_CNTL, par) & CRTC_EXT_DISP_EN)) >> - par->clk_wr_offset = (inb(R_GENMO) & 0x0CU) >> 2; >> - else >> - par->clk_wr_offset = aty_ld_8(CLOCK_CNTL, par) & 0x03U; >> - >> /* according to ATI, we should use clock 3 for acelerated mode */ >> par->clk_wr_offset = 3; >> >> -- >> 2.39.2 >
next prev parent reply other threads:[~2023-05-19 14:50 UTC|newest] Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-16 10:59 [PATCH v4 00/41] treewide: Remove I/O port accessors for HAS_IOPORT=n Niklas Schnelle 2023-05-16 10:59 ` [PATCH v4 01/41] kgdb: add HAS_IOPORT dependency Niklas Schnelle 2023-05-16 10:59 ` [PATCH v4 02/41] ata: add HAS_IOPORT dependencies Niklas Schnelle 2023-05-16 13:18 ` Damien Le Moal 2023-05-16 13:23 ` Damien Le Moal 2023-05-19 12:46 ` Niklas Schnelle 2023-05-30 20:51 ` Sergey Shtylyov 2023-05-16 10:59 ` [PATCH v4 03/41] char: impi, tpm: depend on HAS_IOPORT Niklas Schnelle 2023-05-16 11:06 ` Paul Menzel 2023-05-16 11:39 ` Niklas Schnelle 2023-05-16 11:46 ` Greg Kroah-Hartman 2023-05-16 12:35 ` Niklas Schnelle 2023-05-16 11:00 ` [PATCH v4 04/41] comedi: add HAS_IOPORT dependencies Niklas Schnelle 2023-05-16 11:00 ` [PATCH v4 05/41] counter: " Niklas Schnelle 2023-05-19 1:26 ` William Breathitt Gray 2023-05-19 13:17 ` Niklas Schnelle 2023-05-19 13:38 ` Niklas Schnelle 2023-05-19 13:39 ` Niklas Schnelle 2023-05-19 14:21 ` William Breathitt Gray 2023-05-22 10:42 ` Niklas Schnelle 2023-05-22 11:15 ` William Breathitt Gray 2023-05-16 11:00 ` [PATCH v4 06/41] /dev/port: don't compile file operations without CONFIG_DEVPORT Niklas Schnelle 2023-05-16 11:00 ` [PATCH v4 07/41] drm: handle HAS_IOPORT dependencies Niklas Schnelle 2023-05-16 11:00 ` Niklas Schnelle 2023-05-16 17:13 ` Thomas Zimmermann 2023-05-16 17:13 ` Thomas Zimmermann 2023-05-16 17:13 ` Thomas Zimmermann 2023-05-16 17:47 ` Arnd Bergmann 2023-05-16 17:47 ` Arnd Bergmann 2023-05-16 17:47 ` Arnd Bergmann 2023-05-16 11:00 ` [PATCH v4 08/41] firmware: dmi-sysfs: handle HAS_IOPORT=n Niklas Schnelle 2023-05-16 11:00 ` [PATCH v4 09/41] gpio: add HAS_IOPORT dependencies Niklas Schnelle 2023-05-16 12:57 ` Linus Walleij 2023-05-17 14:15 ` Bartosz Golaszewski 2023-05-16 11:00 ` [PATCH v4 10/41] hwmon: " Niklas Schnelle 2023-05-16 11:00 ` [PATCH v4 11/41] i2c: " Niklas Schnelle 2023-06-05 10:12 ` Wolfram Sang 2023-06-05 12:01 ` Niklas Schnelle 2023-06-05 20:05 ` Wolfram Sang 2023-06-05 12:01 ` Uwe Kleine-König 2023-06-05 12:55 ` Wolfram Sang 2023-05-16 11:00 ` [PATCH v4 12/41] iio: ad7606: Kconfig: " Niklas Schnelle 2023-05-20 15:40 ` Jonathan Cameron 2023-05-16 11:00 ` [PATCH v4 13/41] Input: " Niklas Schnelle 2023-05-16 11:00 ` [PATCH v4 14/41] Input: gameport: add ISA and " Niklas Schnelle 2023-05-16 11:00 ` [PATCH v4 15/41] leds: add " Niklas Schnelle 2023-05-16 11:00 ` [PATCH v4 16/41] media: " Niklas Schnelle 2023-05-16 11:00 ` [PATCH v4 17/41] misc: " Niklas Schnelle 2023-05-16 11:00 ` [PATCH v4 18/41] mISDN: " Niklas Schnelle 2023-05-16 11:00 ` [PATCH v4 19/41] mpt fusion: " Niklas Schnelle 2023-05-16 11:00 ` [PATCH v4 20/41] net: handle " Niklas Schnelle 2023-05-16 11:00 ` [Intel-wired-lan] " Niklas Schnelle 2023-05-16 15:48 ` Maciej W. Rozycki 2023-05-16 15:48 ` Maciej W. Rozycki 2023-05-16 11:00 ` [PATCH v4 21/41] parport: PC style parport depends on HAS_IOPORT Niklas Schnelle 2023-05-16 11:00 ` [PATCH v4 22/41] PCI: Make quirk using inw() depend " Niklas Schnelle 2023-05-16 11:00 ` [PATCH v4 23/41] PCI/sysfs: Make I/O resource " Niklas Schnelle 2023-05-16 11:00 ` [PATCH v4 24/41] pcmcia: add HAS_IOPORT dependencies Niklas Schnelle 2023-05-16 11:00 ` [PATCH v4 25/41] platform: " Niklas Schnelle 2023-05-16 11:00 ` [PATCH v4 26/41] pnp: " Niklas Schnelle 2023-05-16 11:55 ` Rafael J. Wysocki 2023-05-16 11:00 ` [PATCH v4 27/41] power: " Niklas Schnelle 2023-05-16 20:03 ` Sebastian Reichel 2023-05-16 11:00 ` [PATCH v4 28/41] rtc: " Niklas Schnelle 2023-05-16 15:49 ` Maciej W. Rozycki 2023-05-17 8:15 ` Niklas Schnelle 2023-05-17 9:53 ` Maciej W. Rozycki 2023-05-16 11:00 ` [PATCH v4 29/41] scsi: " Niklas Schnelle 2023-05-16 11:00 ` [PATCH v4 30/41] sound: " Niklas Schnelle 2023-05-16 11:00 ` [PATCH v4 31/41] speakup: add HAS_IOPORT dependency for SPEAKUP_SERIALIO Niklas Schnelle 2023-05-16 11:00 ` [PATCH v4 32/41] staging: add HAS_IOPORT dependencies Niklas Schnelle 2023-05-16 11:00 ` [PATCH v4 33/41] tty: serial: handle " Niklas Schnelle 2023-05-30 10:48 ` Greg Kroah-Hartman 2023-05-30 11:53 ` Arnd Bergmann 2023-05-30 14:31 ` Greg Kroah-Hartman 2023-05-16 11:00 ` [PATCH v4 34/41] usb: add " Niklas Schnelle 2023-05-16 11:00 ` [PATCH v4 35/41] usb: uhci: handle " Niklas Schnelle 2023-05-16 16:29 ` Greg Kroah-Hartman 2023-05-16 16:44 ` Arnd Bergmann 2023-05-16 19:51 ` Alan Stern 2023-05-17 8:29 ` Niklas Schnelle 2023-05-16 20:17 ` Alan Stern 2023-05-17 12:17 ` Arnd Bergmann 2023-05-19 11:31 ` Niklas Schnelle 2023-05-16 11:00 ` [PATCH v4 36/41] usb: pci-quirks: " Niklas Schnelle 2023-05-30 11:00 ` Niklas Schnelle 2023-05-16 11:00 ` [PATCH v4 37/41] fbdev: atyfb: Remove unused clock determination Niklas Schnelle 2023-05-16 11:00 ` Niklas Schnelle 2023-05-16 12:24 ` Ville Syrjälä 2023-05-16 12:24 ` Ville Syrjälä 2023-05-19 14:49 ` Helge Deller [this message] 2023-05-19 14:49 ` Helge Deller 2023-05-16 11:00 ` [PATCH v4 38/41] video: handle HAS_IOPORT dependencies Niklas Schnelle 2023-05-16 11:00 ` Niklas Schnelle 2023-05-16 17:21 ` Thomas Zimmermann 2023-05-16 17:21 ` Thomas Zimmermann 2023-05-17 12:41 ` Niklas Schnelle 2023-05-17 12:41 ` Niklas Schnelle 2023-05-16 11:00 ` [PATCH v4 39/41] watchdog: add " Niklas Schnelle 2023-05-16 11:00 ` [PATCH v4 40/41] wireless: " Niklas Schnelle 2023-05-16 11:00 ` [PATCH v4 41/41] asm-generic/io.h: Remove I/O port accessors for HAS_IOPORT=n Niklas Schnelle
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ade998d7-abd7-3514-a8d4-25c3ec71b171@gmx.de \ --to=deller@gmx.de \ --cc=aou@eecs.berkeley.edu \ --cc=arnd@arndb.de \ --cc=bhelgaas@google.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=geert@linux-m68k.org \ --cc=gregkh@linuxfoundation.org \ --cc=linux-arch@vger.kernel.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=mchehab@kernel.org \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=rafael@kernel.org \ --cc=schnelle@linux.ibm.com \ --cc=stern@rowland.harvard.edu \ --cc=u.kleine-koenig@pengutronix.de \ --cc=ville.syrjala@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.