From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
ulf.hansson@linaro.org, hch@lst.de, m.szyprowski@samsung.com,
robin.murphy@arm.com, joro@8bytes.org, axboe@kernel.dk
Cc: wsa+renesas@sang-engineering.com, linux-mmc@vger.kernel.org,
iommu@lists.linux-foundation.org, linux-block@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v8 2/5] iommu/dma: Add a new dma_map_ops of get_merge_boundary()
Date: Tue, 23 Jul 2019 11:17:19 +0300 [thread overview]
Message-ID: <ae95cc2e-38b4-0ed9-744a-67f03f220a3f@cogentembedded.com> (raw)
In-Reply-To: <1563859608-19456-3-git-send-email-yoshihiro.shimoda.uh@renesas.com>
Hello!
On 23.07.2019 8:26, Yoshihiro Shimoda wrote:
> This patch adds a new dma_map_ops of get_merge_boundary() to
> expose the DMA merge boundary if the domain type is IOMMU_DOMAIN_DMA.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> drivers/iommu/dma-iommu.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c
> index a7f9c3e..f3e5f2b 100644
> --- a/drivers/iommu/dma-iommu.c
> +++ b/drivers/iommu/dma-iommu.c
> @@ -1085,6 +1085,16 @@ static int iommu_dma_get_sgtable(struct device *dev, struct sg_table *sgt,
> return ret;
> }
>
> +static unsigned long iommu_dma_get_merge_boundary(struct device *dev)
> +{
> + struct iommu_domain *domain = iommu_get_dma_domain(dev);
> +
> + if (domain->type != IOMMU_DOMAIN_DMA)
> + return 0; /* can't merge */
> +
> + return (1 << __ffs(domain->pgsize_bitmap)) - 1;
Not 1UL?
> +}
> +
> static const struct dma_map_ops iommu_dma_ops = {
> .alloc = iommu_dma_alloc,
> .free = iommu_dma_free,
[...]
MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
To: Yoshihiro Shimoda
<yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>,
ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
hch-jcswGhMUV9g@public.gmane.org,
m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
robin.murphy-5wv7dgnIgG8@public.gmane.org,
joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org,
axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org
Cc: linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
wsa+renesas-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v8 2/5] iommu/dma: Add a new dma_map_ops of get_merge_boundary()
Date: Tue, 23 Jul 2019 11:17:19 +0300 [thread overview]
Message-ID: <ae95cc2e-38b4-0ed9-744a-67f03f220a3f@cogentembedded.com> (raw)
In-Reply-To: <1563859608-19456-3-git-send-email-yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
Hello!
On 23.07.2019 8:26, Yoshihiro Shimoda wrote:
> This patch adds a new dma_map_ops of get_merge_boundary() to
> expose the DMA merge boundary if the domain type is IOMMU_DOMAIN_DMA.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> ---
> drivers/iommu/dma-iommu.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c
> index a7f9c3e..f3e5f2b 100644
> --- a/drivers/iommu/dma-iommu.c
> +++ b/drivers/iommu/dma-iommu.c
> @@ -1085,6 +1085,16 @@ static int iommu_dma_get_sgtable(struct device *dev, struct sg_table *sgt,
> return ret;
> }
>
> +static unsigned long iommu_dma_get_merge_boundary(struct device *dev)
> +{
> + struct iommu_domain *domain = iommu_get_dma_domain(dev);
> +
> + if (domain->type != IOMMU_DOMAIN_DMA)
> + return 0; /* can't merge */
> +
> + return (1 << __ffs(domain->pgsize_bitmap)) - 1;
Not 1UL?
> +}
> +
> static const struct dma_map_ops iommu_dma_ops = {
> .alloc = iommu_dma_alloc,
> .free = iommu_dma_free,
[...]
MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
ulf.hansson@linaro.org, hch@lst.de, m.szyprowski@samsung.com,
robin.murphy@arm.com, joro@8bytes.org, axboe@kernel.dk
Cc: linux-block@vger.kernel.org, wsa+renesas@sang-engineering.com,
iommu@lists.linux-foundation.org, linux-mmc@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v8 2/5] iommu/dma: Add a new dma_map_ops of get_merge_boundary()
Date: Tue, 23 Jul 2019 11:17:19 +0300 [thread overview]
Message-ID: <ae95cc2e-38b4-0ed9-744a-67f03f220a3f@cogentembedded.com> (raw)
In-Reply-To: <1563859608-19456-3-git-send-email-yoshihiro.shimoda.uh@renesas.com>
Hello!
On 23.07.2019 8:26, Yoshihiro Shimoda wrote:
> This patch adds a new dma_map_ops of get_merge_boundary() to
> expose the DMA merge boundary if the domain type is IOMMU_DOMAIN_DMA.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> drivers/iommu/dma-iommu.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c
> index a7f9c3e..f3e5f2b 100644
> --- a/drivers/iommu/dma-iommu.c
> +++ b/drivers/iommu/dma-iommu.c
> @@ -1085,6 +1085,16 @@ static int iommu_dma_get_sgtable(struct device *dev, struct sg_table *sgt,
> return ret;
> }
>
> +static unsigned long iommu_dma_get_merge_boundary(struct device *dev)
> +{
> + struct iommu_domain *domain = iommu_get_dma_domain(dev);
> +
> + if (domain->type != IOMMU_DOMAIN_DMA)
> + return 0; /* can't merge */
> +
> + return (1 << __ffs(domain->pgsize_bitmap)) - 1;
Not 1UL?
> +}
> +
> static const struct dma_map_ops iommu_dma_ops = {
> .alloc = iommu_dma_alloc,
> .free = iommu_dma_free,
[...]
MBR, Sergei
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-07-23 8:17 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 5:26 [PATCH v8 0/5] treewide: improve R-Car SDHI performance Yoshihiro Shimoda
2019-07-23 5:26 ` Yoshihiro Shimoda
2019-07-23 5:26 ` Yoshihiro Shimoda
2019-07-23 5:26 ` [PATCH v8 1/5] dma: Introduce dma_get_merge_boundary() Yoshihiro Shimoda
2019-07-23 5:26 ` Yoshihiro Shimoda
2019-07-23 5:26 ` Yoshihiro Shimoda
2019-07-25 6:32 ` Simon Horman
2019-07-25 6:32 ` Simon Horman
2019-07-25 6:32 ` Simon Horman
2019-07-23 5:26 ` [PATCH v8 2/5] iommu/dma: Add a new dma_map_ops of get_merge_boundary() Yoshihiro Shimoda
2019-07-23 5:26 ` Yoshihiro Shimoda
2019-07-23 5:26 ` Yoshihiro Shimoda
2019-07-23 8:17 ` Sergei Shtylyov [this message]
2019-07-23 8:17 ` Sergei Shtylyov
2019-07-23 8:17 ` Sergei Shtylyov
2019-07-25 6:33 ` Simon Horman
2019-07-25 6:33 ` Simon Horman
2019-07-26 7:50 ` Yoshihiro Shimoda
2019-07-26 7:50 ` Yoshihiro Shimoda
2019-07-26 7:50 ` Yoshihiro Shimoda
2019-07-23 5:26 ` [PATCH v8 3/5] block: sort headers on blk-setting.c Yoshihiro Shimoda
2019-07-23 5:26 ` Yoshihiro Shimoda
2019-07-23 5:26 ` Yoshihiro Shimoda
2019-07-25 6:33 ` Simon Horman
2019-07-25 6:33 ` Simon Horman
2019-07-25 6:33 ` Simon Horman
2019-07-23 5:26 ` [PATCH v8 4/5] block: add a helper function to merge the segments Yoshihiro Shimoda
2019-07-23 5:26 ` Yoshihiro Shimoda
2019-07-23 5:26 ` Yoshihiro Shimoda
2019-07-25 6:33 ` Simon Horman
2019-07-25 6:33 ` Simon Horman
2019-07-25 6:33 ` Simon Horman
2019-07-23 5:26 ` [PATCH v8 5/5] mmc: queue: Use bigger segments if DMA MAP layer can " Yoshihiro Shimoda
2019-07-23 5:26 ` Yoshihiro Shimoda
2019-07-23 5:26 ` Yoshihiro Shimoda
2019-07-25 6:34 ` Simon Horman
2019-07-25 6:34 ` Simon Horman
2019-07-25 6:34 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae95cc2e-38b4-0ed9-744a-67f03f220a3f@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.