Re: [PATCH v7 6/6] ASoC: cs42l43: Add support for the cs42l43

From: Mark Brown <broonie@kernel.org>
To: andy.shevchenko@gmail.com
Cc: Charles Keepax <ckeepax@opensource.cirrus.com>,
	lee@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	linus.walleij@linaro.org, vkoul@kernel.org, lgirdwood@gmail.com,
	yung-chuan.liao@linux.intel.com, sanyog.r.kale@intel.com,
	pierre-louis.bossart@linux.intel.com,
	alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
	devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 6/6] ASoC: cs42l43: Add support for the cs42l43
Date: Thu, 18 Jan 2024 18:11:09 +0000	[thread overview]
Message-ID: <aec96f5a-b759-48c7-a5ec-bafe3bfa5357@sirena.org.uk> (raw)
In-Reply-To: <Zali4qxdegY7H6eY@surfacebook.localdomain>

[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]

On Thu, Jan 18, 2024 at 07:41:54PM +0200, andy.shevchenko@gmail.com wrote:
> Fri, Aug 04, 2023 at 11:46:02AM +0100, Charles Keepax kirjoitti:

> > +	unsigned int hs2 = 0x2 << CS42L43_HSDET_MODE_SHIFT;

> BIT(1) ?

Given that this is writing a value into a register field called "MODE"
it seems very likely that it's an enumeration value rather than a
bitmask (and similarly for all the other places where you're making
similar comments).  Please think a bit more about the code being
commented on when making these minor stylistic comments.

> > +static const char * const cs42l43_jack_text[] = {
> > +	"None", "CTIA", "OMTP", "Headphone", "Line-Out",
> > +	"Line-In", "Microphone", "Optical",

> Better to have this by power of 2 blocks (seems it's related to the possible
> values ranges in the HW).
> If it's just a coincidence that there are 8 of them, perhaps other (logical)
> grouping is better?

This is probably well within the realm of driver author taste...

> > +	// Don't use devm as we need to get against the MFD device

> This is weird...

This is normal, the splitting into subdevices is often a purely Linux
internal thing and not represented in the firmware description so
external resources are linked to the top level.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]