Re: [PATCH v7 6/6] ASoC: cs42l43: Add support for the cs42l43

From: Mark Brown <broonie@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Charles Keepax <ckeepax@opensource.cirrus.com>,
	lee@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	linus.walleij@linaro.org, vkoul@kernel.org, lgirdwood@gmail.com,
	yung-chuan.liao@linux.intel.com, sanyog.r.kale@intel.com,
	pierre-louis.bossart@linux.intel.com,
	alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
	devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 6/6] ASoC: cs42l43: Add support for the cs42l43
Date: Thu, 18 Jan 2024 22:07:00 +0000	[thread overview]
Message-ID: <b1889bb0-2b9f-477c-80d3-a636b9017ea4@sirena.org.uk> (raw)
In-Reply-To: <CAHp75Vd6JtW4ddbSPXUp6WgEdBJizjwnS-XZzwLcXWWLxFWp-w@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1359 bytes --]

On Thu, Jan 18, 2024 at 10:46:28PM +0200, Andy Shevchenko wrote:
> On Thu, Jan 18, 2024 at 8:11 PM Mark Brown <broonie@kernel.org> wrote:
> > On Thu, Jan 18, 2024 at 07:41:54PM +0200, andy.shevchenko@gmail.com wrote:
> > > Fri, Aug 04, 2023 at 11:46:02AM +0100, Charles Keepax kirjoitti:

> > > > +   unsigned int hs2 = 0x2 << CS42L43_HSDET_MODE_SHIFT;

> > > BIT(1) ?

> > Given that this is writing a value into a register field called "MODE"
> > it seems very likely that it's an enumeration value rather than a
> > bitmask (and similarly for all the other places where you're making
> > similar comments).  Please think a bit more about the code being
> > commented on when making these minor stylistic comments.

> I read a bit further and have given a comment about this as you put it
> above that they are plain values.
> Please, read my comments in full.

I did eventually find that while going through the other comments but
given that the earlier ones hadn't been revised and it was all a bunch
of different fields it still seemed useful to highlight, if nothing else
it was a little unclear that your later comment applied to all the
fields you were asking for updates to.

In general in a case like this where the code is already in tree it does
seem like it'd be better to just write patche for the stylistic issues.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]