From: Mimi Zohar <zohar@linux.ibm.com>
To: Petr Vorel <pvorel@suse.cz>, ltp@lists.linux.it
Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>,
Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
Tushar Sugandhi <tusharsu@linux.microsoft.com>,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH v5 1/4] IMA: Move get_algorithm_digest(), set_digest_index() to ima_setup.sh
Date: Thu, 17 Dec 2020 11:56:51 -0500 [thread overview]
Message-ID: <aed2e8ee7b05772a8cc2988ae275282bec7ef504.camel@linux.ibm.com> (raw)
In-Reply-To: <20201214221946.6340-2-pvorel@suse.cz>
Hi Petr,
Thank you!
On Mon, 2020-12-14 at 23:19 +0100, Petr Vorel wrote:
> To be reusable by more tests (preparation for next commit).
>
> Call set_digest_index() inside get_algorithm_digest() if needed
> instead of expecting get_algorithm_digest() caller to call
> set_digest_index() before.
For the existing builtin templates, the algorithm/digest field is
consistent. With support for per policy rule template formats, there
isn't necessarily a single template format for the entire list.
In the future "set_digest_index" might need to be renamed to
"get_digest_index" and the lookup done for each line.
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
WARNING: multiple messages have this Message-ID (diff)
From: Mimi Zohar <zohar@linux.ibm.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v5 1/4] IMA: Move get_algorithm_digest(), set_digest_index() to ima_setup.sh
Date: Thu, 17 Dec 2020 11:56:51 -0500 [thread overview]
Message-ID: <aed2e8ee7b05772a8cc2988ae275282bec7ef504.camel@linux.ibm.com> (raw)
In-Reply-To: <20201214221946.6340-2-pvorel@suse.cz>
Hi Petr,
Thank you!
On Mon, 2020-12-14 at 23:19 +0100, Petr Vorel wrote:
> To be reusable by more tests (preparation for next commit).
>
> Call set_digest_index() inside get_algorithm_digest() if needed
> instead of expecting get_algorithm_digest() caller to call
> set_digest_index() before.
For the existing builtin templates, the algorithm/digest field is
consistent. With support for per policy rule template formats, there
isn't necessarily a single template format for the entire list.
In the future "set_digest_index" might need to be renamed to
"get_digest_index" and the lookup done for each line.
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
next prev parent reply other threads:[~2020-12-17 16:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 22:19 [PATCH v5 0/4] TPM 2.0 fixes in IMA tests Petr Vorel
2020-12-14 22:19 ` [LTP] " Petr Vorel
2020-12-14 22:19 ` [PATCH v5 1/4] IMA: Move get_algorithm_digest(), set_digest_index() to ima_setup.sh Petr Vorel
2020-12-14 22:19 ` [LTP] " Petr Vorel
2020-12-17 16:56 ` Mimi Zohar [this message]
2020-12-17 16:56 ` Mimi Zohar
2020-12-18 11:27 ` Petr Vorel
2020-12-18 11:27 ` [LTP] " Petr Vorel
2020-12-18 12:10 ` Mimi Zohar
2020-12-18 12:10 ` [LTP] " Mimi Zohar
2020-12-14 22:19 ` [PATCH v5 2/4] IMA: Rewrite ima_boot_aggregate.c to new API Petr Vorel
2020-12-14 22:19 ` [LTP] " Petr Vorel
2020-12-14 22:19 ` [PATCH v5 3/4] ima_tpm.sh: Fix calculating boot aggregate Petr Vorel
2020-12-14 22:19 ` [LTP] " Petr Vorel
2020-12-17 18:12 ` Mimi Zohar
2020-12-17 18:12 ` [LTP] " Mimi Zohar
2020-12-17 19:36 ` Petr Vorel
2020-12-17 19:36 ` [LTP] " Petr Vorel
2020-12-14 22:19 ` [PATCH v5 4/4] ima_tpm.sh: Fix calculating PCR aggregate Petr Vorel
2020-12-14 22:19 ` [LTP] " Petr Vorel
2020-12-17 19:16 ` Mimi Zohar
2020-12-17 19:16 ` [LTP] " Mimi Zohar
2020-12-17 5:20 ` [PATCH v5 0/4] TPM 2.0 fixes in IMA tests Mimi Zohar
2020-12-17 5:20 ` [LTP] " Mimi Zohar
2020-12-17 8:33 ` Petr Vorel
2020-12-17 8:33 ` [LTP] " Petr Vorel
2020-12-17 19:23 ` Mimi Zohar
2020-12-17 19:23 ` [LTP] " Mimi Zohar
2020-12-18 11:45 ` Petr Vorel
2020-12-18 11:45 ` [LTP] " Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aed2e8ee7b05772a8cc2988ae275282bec7ef504.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=linux-integrity@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=nramas@linux.microsoft.com \
--cc=pvorel@suse.cz \
--cc=tusharsu@linux.microsoft.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.