[syzbot] [ext4?] WARNING: locking bug in __ext4_ioctl

[syzbot] [ext4?] WARNING: locking bug in __ext4_ioctl

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit:    6f64a5ebe1dc Merge tag 'irq_urgent_for_v6.4_rc5' of git://..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=108c54b3280000
kernel config:  https://syzkaller.appspot.com/x/.config?x=3da6c5d3e0a6c932
dashboard link: https://syzkaller.appspot.com/bug?extid=a537ff48a9cb940d314c
compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/9c3283ed69ea/disk-6f64a5eb.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/1aeeba51b60c/vmlinux-6f64a5eb.xz
kernel image: https://storage.googleapis.com/syzbot-assets/1962adc07598/bzImage-6f64a5eb.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+a537ff48a9cb940d314c@syzkaller.appspotmail.com

------------[ cut here ]------------
Looking for class "&ei->i_data_sem" with key __key.0, but found a different class "&ei->i_data_sem" with the same key
WARNING: CPU: 0 PID: 19058 at kernel/locking/lockdep.c:938 look_up_lock_class+0xac/0x130 kernel/locking/lockdep.c:938
Modules linked in:
CPU: 0 PID: 19058 Comm: syz-executor.1 Not tainted 6.4.0-rc4-syzkaller-00371-g6f64a5ebe1dc #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/25/2023
RIP: 0010:look_up_lock_class+0xac/0x130 kernel/locking/lockdep.c:938
Code: 39 48 8b 55 00 48 81 fa 20 18 16 90 74 2c 80 3d 99 eb 54 04 00 75 23 48 c7 c7 c0 6c 4c 8a c6 05 89 eb 54 04 01 e8 34 28 3c f7 <0f> 0b eb 0c e8 1b 25 00 fa 85 c0 75 48 45 31 e4 48 83 c4 08 4c 89
RSP: 0018:ffffc9000dfc7810 EFLAGS: 00010086
RAX: 0000000000000000 RBX: ffffffff91f0c721 RCX: ffffc9000b9e4000
RDX: 0000000000040000 RSI: ffffffff814c03a7 RDI: 0000000000000001
RBP: ffff888056cc3488 R08: 0000000000000001 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000001 R12: ffffffff915b7720
R13: 0000000000000001 R14: ffff888056cc3488 R15: 0000000000000001
FS:  00007fd430ba3700(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000001b2c928000 CR3: 000000004fd89000 CR4: 0000000000350ef0
Call Trace:
 <TASK>
 register_lock_class+0xbe/0x1120 kernel/locking/lockdep.c:1290
 __lock_acquire+0x10d/0x5f30 kernel/locking/lockdep.c:4965
 lock_acquire kernel/locking/lockdep.c:5705 [inline]
 lock_acquire+0x1b1/0x520 kernel/locking/lockdep.c:5670
 down_write_nested+0x96/0x200 kernel/locking/rwsem.c:1689
 ext4_double_down_write_data_sem+0x67/0x80 fs/ext4/move_extent.c:58
 swap_inode_boot_loader fs/ext4/ioctl.c:423 [inline]
 __ext4_ioctl+0x2aa1/0x4b00 fs/ext4/ioctl.c:1418
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:870 [inline]
 __se_sys_ioctl fs/ioctl.c:856 [inline]
 __x64_sys_ioctl+0x197/0x210 fs/ioctl.c:856
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fd42fe8c169
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fd430ba3168 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007fd42ffabf80 RCX: 00007fd42fe8c169
RDX: 0000000000000000 RSI: 0000000000006611 RDI: 0000000000000004
RBP: 00007fd42fee7ca1 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffd8894480f R14: 00007fd430ba3300 R15: 0000000000022000
 </TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the bug is already fixed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to change bug's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the bug is a duplicate of another bug, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

Re: [syzbot] [ext4?] WARNING: locking bug in __ext4_ioctl

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit:    a901a3568fd2 Merge tag 'iomap-6.5-merge-1' of git://git.ke..
git tree:       upstream
console+strace: https://syzkaller.appspot.com/x/log.txt?x=131dbb80a80000
kernel config:  https://syzkaller.appspot.com/x/.config?x=12d3428a307a1111
dashboard link: https://syzkaller.appspot.com/bug?extid=a537ff48a9cb940d314c
compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1489ffb8a80000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=145c302ca80000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/d5b4ad8feb6a/disk-a901a356.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/b59c91556f58/vmlinux-a901a356.xz
kernel image: https://storage.googleapis.com/syzbot-assets/dcd583b21e5c/bzImage-a901a356.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/45e4aa281996/mount_2.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+a537ff48a9cb940d314c@syzkaller.appspotmail.com

------------[ cut here ]------------
Looking for class "&ei->i_data_sem" with key __key.0, but found a different class "&ei->i_data_sem" with the same key
WARNING: CPU: 1 PID: 5185 at kernel/locking/lockdep.c:940 look_up_lock_class+0xac/0x130 kernel/locking/lockdep.c:940
Modules linked in:
CPU: 1 PID: 5185 Comm: syz-executor404 Not tainted 6.4.0-syzkaller-10173-ga901a3568fd2 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/27/2023
RIP: 0010:look_up_lock_class+0xac/0x130 kernel/locking/lockdep.c:940
Code: 39 48 8b 55 00 48 81 fa a0 b9 48 90 74 2c 80 3d d3 f3 75 04 00 75 23 48 c7 c7 40 6e 6c 8a c6 05 c3 f3 75 04 01 e8 a4 2f 2e f7 <0f> 0b eb 0c e8 ab 5b f5 f9 85 c0 75 48 45 31 e4 48 83 c4 08 4c 89
RSP: 0018:ffffc90003e5f808 EFLAGS: 00010082
RAX: 0000000000000000 RBX: ffffffff92256381 RCX: 0000000000000000
RDX: ffff888021afd940 RSI: ffffffff814c24f7 RDI: 0000000000000001
RBP: ffff8880745ce688 R08: 0000000000000001 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000001 R12: ffffffff918a84f0
R13: 0000000000000001 R14: ffff8880745ce688 R15: 0000000000000000
FS:  0000555557100300(0000) GS:ffff8880b9900000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f9070243138 CR3: 0000000015297000 CR4: 0000000000350ee0
Call Trace:
 <TASK>
 register_lock_class+0xbe/0x1120 kernel/locking/lockdep.c:1292
 __lock_acquire+0x109/0x5e20 kernel/locking/lockdep.c:5021
 lock_acquire kernel/locking/lockdep.c:5761 [inline]
 lock_acquire+0x1b1/0x520 kernel/locking/lockdep.c:5726
 down_write_nested+0x96/0x200 kernel/locking/rwsem.c:1689
 ext4_double_down_write_data_sem+0x67/0x80 fs/ext4/move_extent.c:58
 swap_inode_boot_loader fs/ext4/ioctl.c:423 [inline]
 __ext4_ioctl+0x2942/0x4650 fs/ext4/ioctl.c:1427
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:870 [inline]
 __se_sys_ioctl fs/ioctl.c:856 [inline]
 __x64_sys_ioctl+0x19d/0x210 fs/ioctl.c:856
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f90701d1249
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 51 15 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffdf78879a8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 69662f7375622f2e RCX: 00007f90701d1249
RDX: 0000000000000000 RSI: 0000000000006611 RDI: 0000000000000003
RBP: 0000000000000000 R08: 00007ffdf78879d0 R09: 00007ffdf78879d0
R10: 00007ffdf7887420 R11: 0000000000000246 R12: 00007ffdf78879cc
R13: 00007ffdf7887a20 R14: 00007ffdf78879e0 R15: 000000000000003d
 </TASK>


---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

Re: [syzbot] [ext4?] WARNING: locking bug in __ext4_ioctl

[syzbot]

syzbot has bisected this issue to:

commit aff3bea95388299eec63440389b4545c8041b357
Author: Theodore Ts'o <tytso@mit.edu>
Date:   Wed May 24 03:49:51 2023 +0000

    ext4: add lockdep annotations for i_data_sem for ea_inode's

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=121e2492a80000
start commit:   a901a3568fd2 Merge tag 'iomap-6.5-merge-1' of git://git.ke..
git tree:       upstream
final oops:     https://syzkaller.appspot.com/x/report.txt?x=111e2492a80000
console output: https://syzkaller.appspot.com/x/log.txt?x=161e2492a80000
kernel config:  https://syzkaller.appspot.com/x/.config?x=12d3428a307a1111
dashboard link: https://syzkaller.appspot.com/bug?extid=a537ff48a9cb940d314c
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1489ffb8a80000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=145c302ca80000

Reported-by: syzbot+a537ff48a9cb940d314c@syzkaller.appspotmail.com
Fixes: aff3bea95388 ("ext4: add lockdep annotations for i_data_sem for ea_inode's")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection