WARNING in j1939_sk_queue_activate_next

WARNING in j1939_sk_queue_activate_next

[syzbot]

Hello,

syzbot found the following crash on:

HEAD commit:    1f12177b Merge branch 'cpsw-switchdev'
git tree:       net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=16cd57f6e00000
kernel config:  https://syzkaller.appspot.com/x/.config?x=ce691bc139ec9632
dashboard link: https://syzkaller.appspot.com/bug?extid=49595536c57ef38095ed
compiler:       gcc (GCC) 9.0.0 20181231 (experimental)
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=14685836e00000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=12f8b2f2e00000

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+49595536c57ef38095ed@syzkaller.appspotmail.com

vcan0: j1939_tp_rxtimer: 0x00000000bc4b6db0: rx timeout, send abort
vcan0: j1939_xtp_rx_abort_one: 0x00000000bc4b6db0: 0x00000: (3) A timeout  
occurred and this is the connection abort to close the session.
------------[ cut here ]------------
WARNING: CPU: 0 PID: 9 at net/can/j1939/socket.c:180  
j1939_sk_queue_activate_next_locked net/can/j1939/socket.c:180 [inline]
WARNING: CPU: 0 PID: 9 at net/can/j1939/socket.c:180  
j1939_sk_queue_activate_next+0x359/0x460 net/can/j1939/socket.c:204
Kernel panic - not syncing: panic_on_warn set ...
CPU: 0 PID: 9 Comm: ksoftirqd/0 Not tainted 5.4.0-rc7-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS  
Google 01/01/2011
Call Trace:
  __dump_stack lib/dump_stack.c:77 [inline]
  dump_stack+0x197/0x210 lib/dump_stack.c:118
  panic+0x2e3/0x75c kernel/panic.c:221
  __warn.cold+0x2f/0x35 kernel/panic.c:582
  report_bug+0x289/0x300 lib/bug.c:195
  fixup_bug arch/x86/kernel/traps.c:179 [inline]
  fixup_bug arch/x86/kernel/traps.c:174 [inline]
  do_error_trap+0x11b/0x200 arch/x86/kernel/traps.c:272
  do_invalid_op+0x37/0x50 arch/x86/kernel/traps.c:291
  invalid_op+0x23/0x30 arch/x86/entry/entry_64.S:1028
RIP: 0010:j1939_sk_queue_activate_next_locked net/can/j1939/socket.c:180  
[inline]
RIP: 0010:j1939_sk_queue_activate_next+0x359/0x460  
net/can/j1939/socket.c:204
Code: e8 1c 83 c0 0a 89 45 cc eb 9f 48 c7 c7 b4 1a c7 89 e8 cb b1 2d fb e9  
6a fd ff ff e8 c1 b1 2d fb e9 19 fe ff ff e8 17 f9 f1 fa <0f> 0b 48 8b 45  
c0 48 8d b8 b0 00 00 00 48 89 f8 48 c1 e8 03 42 0f
RSP: 0018:ffff8880a98af918 EFLAGS: 00010206
RAX: ffff8880a98a2240 RBX: ffff888099561000 RCX: ffffffff86816668
RDX: 0000000000000100 RSI: ffffffff86816709 RDI: 0000000000000005
RBP: ffff8880a98af970 R08: ffff8880a98a2240 R09: fffffbfff14f0f4c
R10: fffffbfff14f0f4b R11: ffffffff8a787a5f R12: ffff888099561510
R13: ffff88809175cc00 R14: ffff888099561548 R15: dffffc0000000000
  j1939_session_deactivate_activate_next+0x3d/0x50  
net/can/j1939/transport.c:1046
  j1939_xtp_rx_abort_one.cold+0x21a/0x35e net/can/j1939/transport.c:1275
  j1939_xtp_rx_abort net/can/j1939/transport.c:1286 [inline]
  j1939_tp_cmd_recv net/can/j1939/transport.c:1972 [inline]
  j1939_tp_recv+0x783/0x9b0 net/can/j1939/transport.c:2005
  j1939_can_recv+0x502/0x610 net/can/j1939/main.c:101
  deliver net/can/af_can.c:569 [inline]
  can_rcv_filter+0x292/0x8e0 net/can/af_can.c:603
  can_receive+0x2e7/0x530 net/can/af_can.c:660
  can_rcv+0x133/0x1b0 net/can/af_can.c:686
  __netif_receive_skb_one_core+0x113/0x1a0 net/core/dev.c:5150
  __netif_receive_skb+0x2c/0x1d0 net/core/dev.c:5264
  process_backlog+0x206/0x750 net/core/dev.c:6095
  napi_poll net/core/dev.c:6532 [inline]
  net_rx_action+0x508/0x1120 net/core/dev.c:6600
  __do_softirq+0x262/0x98c kernel/softirq.c:292
  run_ksoftirqd kernel/softirq.c:603 [inline]
  run_ksoftirqd+0x8e/0x110 kernel/softirq.c:595
  smpboot_thread_fn+0x6a3/0xa40 kernel/smpboot.c:165
  kthread+0x361/0x430 kernel/kthread.c:255
  ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352
Kernel Offset: disabled
Rebooting in 86400 seconds..


---
This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this bug, for details see:
https://goo.gl/tpsmEJ#testing-patches

Re: WARNING in j1939_sk_queue_activate_next

[syzbot]

syzbot has bisected this bug to:

commit 9d71dd0c70099914fcd063135da3c580865e924c
Author: The j1939 authors <linux-can@vger.kernel.org>
Date:   Mon Oct 8 09:48:36 2018 +0000

     can: add support of SAE J1939 protocol

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=152c6bace00000
start commit:   c74386d5 afs: Fix missing timeout reset
git tree:       upstream
final crash:    https://syzkaller.appspot.com/x/report.txt?x=172c6bace00000
console output: https://syzkaller.appspot.com/x/log.txt?x=132c6bace00000
kernel config:  https://syzkaller.appspot.com/x/.config?x=4737c15fc47048f2
dashboard link: https://syzkaller.appspot.com/bug?extid=49595536c57ef38095ed
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=13b8ba86e00000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=16ce855ae00000

Reported-by: syzbot+49595536c57ef38095ed@syzkaller.appspotmail.com
Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection