[syzbot] memory leak in zr364xx_start_readpipe

[syzbot] memory leak in zr364xx_start_readpipe

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit:    d72cd4ad Merge tag 'scsi-misc' of git://git.kernel.org/pub..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=107c2b85d00000
kernel config:  https://syzkaller.appspot.com/x/.config?x=337dc545ba10a406
dashboard link: https://syzkaller.appspot.com/bug?extid=af4fa391ef18efdd5f69
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1245a733d00000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=17f13de1d00000

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+af4fa391ef18efdd5f69@syzkaller.appspotmail.com

BUG: memory leak
unreferenced object 0xffff8881112c1600 (size 192):
  comm "kworker/1:5", pid 8088, jiffies 4294943845 (age 8.070s)
  hex dump (first 32 bytes):
    01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 18 16 2c 11 81 88 ff ff  ..........,.....
  backtrace:
    [<ffffffff82baedf6>] kmalloc include/linux/slab.h:561 [inline]
    [<ffffffff82baedf6>] usb_alloc_urb+0x66/0xe0 drivers/usb/core/urb.c:74
    [<ffffffff82f7cce8>] zr364xx_start_readpipe+0x78/0x130 drivers/media/usb/zr364xx/zr364xx.c:1022
    [<ffffffff84251dfc>] zr364xx_board_init drivers/media/usb/zr364xx/zr364xx.c:1383 [inline]
    [<ffffffff84251dfc>] zr364xx_probe+0x6a3/0x851 drivers/media/usb/zr364xx/zr364xx.c:1516
    [<ffffffff82bb6507>] usb_probe_interface+0x177/0x370 drivers/usb/core/driver.c:396
    [<ffffffff826018a9>] really_probe+0x159/0x500 drivers/base/dd.c:576
    [<ffffffff82601cdb>] driver_probe_device+0x8b/0x100 drivers/base/dd.c:763
    [<ffffffff82602406>] __device_attach_driver+0xf6/0x120 drivers/base/dd.c:870
    [<ffffffff825fe797>] bus_for_each_drv+0xb7/0x100 drivers/base/bus.c:431
    [<ffffffff82601f82>] __device_attach+0x122/0x260 drivers/base/dd.c:938
    [<ffffffff82600436>] bus_probe_device+0xc6/0xe0 drivers/base/bus.c:491
    [<ffffffff825fc855>] device_add+0x5d5/0xd70 drivers/base/core.c:3319
    [<ffffffff82bb3aa9>] usb_set_configuration+0x9d9/0xb90 drivers/usb/core/message.c:2164
    [<ffffffff82bc3e3c>] usb_generic_driver_probe+0x8c/0xc0 drivers/usb/core/generic.c:238
    [<ffffffff82bb5c6c>] usb_probe_device+0x5c/0x140 drivers/usb/core/driver.c:293
    [<ffffffff826018a9>] really_probe+0x159/0x500 drivers/base/dd.c:576
    [<ffffffff82601cdb>] driver_probe_device+0x8b/0x100 drivers/base/dd.c:763



---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this issue, for details see:
https://goo.gl/tpsmEJ#testing-patches

Re: [syzbot] memory leak in zr364xx_start_readpipe

[Pavel Skripkin]

On Mon, 17 May 2021 04:37:22 -0700
syzbot <syzbot+af4fa391ef18efdd5f69@syzkaller.appspotmail.com> wrote:

> Hello,
> 
> syzbot found the following issue on:
> 
> HEAD commit:    d72cd4ad Merge tag 'scsi-misc' of
> git://git.kernel.org/pub.. git tree:       upstream
> console output:
> https://syzkaller.appspot.com/x/log.txt?x=107c2b85d00000 kernel
> config:  https://syzkaller.appspot.com/x/.config?x=337dc545ba10a406
> dashboard link:
> https://syzkaller.appspot.com/bug?extid=af4fa391ef18efdd5f69 syz
> repro:
> https://syzkaller.appspot.com/x/repro.syz?x=1245a733d00000 C
> reproducer:   https://syzkaller.appspot.com/x/repro.c?x=17f13de1d00000
> 
> IMPORTANT: if you fix the issue, please add the following tag to the
> commit: Reported-by:
> syzbot+af4fa391ef18efdd5f69@syzkaller.appspotmail.com
> 
> BUG: memory leak
> unreferenced object 0xffff8881112c1600 (size 192):
>   comm "kworker/1:5", pid 8088, jiffies 4294943845 (age 8.070s)
>   hex dump (first 32 bytes):
>     01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
>     00 00 00 00 00 00 00 00 18 16 2c 11 81 88 ff ff  ..........,.....
>   backtrace:
>     [<ffffffff82baedf6>] kmalloc include/linux/slab.h:561 [inline]
>     [<ffffffff82baedf6>] usb_alloc_urb+0x66/0xe0
> drivers/usb/core/urb.c:74 [<ffffffff82f7cce8>]
> zr364xx_start_readpipe+0x78/0x130
> drivers/media/usb/zr364xx/zr364xx.c:1022 [<ffffffff84251dfc>]
> zr364xx_board_init drivers/media/usb/zr364xx/zr364xx.c:1383 [inline]
> [<ffffffff84251dfc>] zr364xx_probe+0x6a3/0x851
> drivers/media/usb/zr364xx/zr364xx.c:1516 [<ffffffff82bb6507>]
> usb_probe_interface+0x177/0x370 drivers/usb/core/driver.c:396
> [<ffffffff826018a9>] really_probe+0x159/0x500 drivers/base/dd.c:576
> [<ffffffff82601cdb>] driver_probe_device+0x8b/0x100
> drivers/base/dd.c:763 [<ffffffff82602406>]
> __device_attach_driver+0xf6/0x120 drivers/base/dd.c:870
> [<ffffffff825fe797>] bus_for_each_drv+0xb7/0x100
> drivers/base/bus.c:431 [<ffffffff82601f82>]
> __device_attach+0x122/0x260 drivers/base/dd.c:938
> [<ffffffff82600436>] bus_probe_device+0xc6/0xe0
> drivers/base/bus.c:491 [<ffffffff825fc855>] device_add+0x5d5/0xd70
> drivers/base/core.c:3319 [<ffffffff82bb3aa9>]
> usb_set_configuration+0x9d9/0xb90 drivers/usb/core/message.c:2164
> [<ffffffff82bc3e3c>] usb_generic_driver_probe+0x8c/0xc0
> drivers/usb/core/generic.c:238 [<ffffffff82bb5c6c>]
> usb_probe_device+0x5c/0x140 drivers/usb/core/driver.c:293
> [<ffffffff826018a9>] really_probe+0x159/0x500 drivers/base/dd.c:576
> [<ffffffff82601cdb>] driver_probe_device+0x8b/0x100
> drivers/base/dd.c:763
> 

#syz test https://linux.googlesource.com/linux/kernel/git/torvalds/linux refs/changes/96/11196/1

> 
> 
> ---
> This report is generated by a bot. It may contain errors.
> See https://goo.gl/tpsmEJ for more information about syzbot.
> syzbot engineers can be reached at syzkaller@googlegroups.com.
> 
> syzbot will keep track of this issue. See:
> https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
> syzbot can test patches for this issue, for details see:
> https://goo.gl/tpsmEJ#testing-patches
> 




With regards,
Pavel Skripkin

Re: [syzbot] memory leak in zr364xx_start_readpipe

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-and-tested-by: syzbot+af4fa391ef18efdd5f69@syzkaller.appspotmail.com

Tested on:

commit:         0723f73e media: zr364xx: fix memory leak in zr364xx_start_..
git tree:       https://linux.googlesource.com/linux/kernel/git/torvalds/linux refs/changes/96/11196/1
kernel config:  https://syzkaller.appspot.com/x/.config?x=cb9a486f2f311b2e
dashboard link: https://syzkaller.appspot.com/bug?extid=af4fa391ef18efdd5f69
compiler:       

Note: testing is done by a robot and is best-effort only.