All of lore.kernel.org
 help / color / mirror / Atom feed
* [syzbot] possible deadlock in bpf_trace_printk
@ 2022-06-09 17:07 syzbot
  2023-03-22  9:29 ` [syzbot] [bpf?] [trace?] " syzbot
  0 siblings, 1 reply; 4+ messages in thread
From: syzbot @ 2022-06-09 17:07 UTC (permalink / raw)
  To: andrii, ast, boqun.feng, bpf, daniel, davem, hawk,
	john.fastabend, kafai, kpsingh, kuba, linux-kernel, longman,
	mingo, netdev, peterz, rostedt, songliubraving, syzkaller-bugs,
	will, yhs

Hello,

syzbot found the following issue on:

HEAD commit:    d678cbd2f867 xsk: Fix handling of invalid descriptors in X..
git tree:       bpf
console+strace: https://syzkaller.appspot.com/x/log.txt?x=15ea1120080000
kernel config:  https://syzkaller.appspot.com/x/.config?x=fc5a30a131480a80
dashboard link: https://syzkaller.appspot.com/bug?extid=c49e17557ddb5725583d
compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1342b1f7f00000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=15ca7880080000

The issue was bisected to:

commit dc1f7893a70fe403983bd8492f177bf993940e2c
Author: Peter Zijlstra <peterz@infradead.org>
Date:   Wed Mar 30 11:06:54 2022 +0000

    locking/mutex: Make contention tracepoints more consistent wrt adaptive spinning

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=14c55dcff00000
final oops:     https://syzkaller.appspot.com/x/report.txt?x=16c55dcff00000
console output: https://syzkaller.appspot.com/x/log.txt?x=12c55dcff00000

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+c49e17557ddb5725583d@syzkaller.appspotmail.com
Fixes: dc1f7893a70f ("locking/mutex: Make contention tracepoints more consistent wrt adaptive spinning")

============================================
WARNING: possible recursive locking detected
5.18.0-syzkaller-12122-gd678cbd2f867 #0 Not tainted
--------------------------------------------
syz-executor354/3616 is trying to acquire lock:
ffffffff8be0d6d8 (trace_printk_lock){..-.}-{2:2}, at: ____bpf_trace_printk kernel/trace/bpf_trace.c:388 [inline]
ffffffff8be0d6d8 (trace_printk_lock){..-.}-{2:2}, at: bpf_trace_printk+0xcf/0x170 kernel/trace/bpf_trace.c:374

but task is already holding lock:
ffffffff8be0d6d8 (trace_printk_lock){..-.}-{2:2}, at: ____bpf_trace_printk kernel/trace/bpf_trace.c:388 [inline]
ffffffff8be0d6d8 (trace_printk_lock){..-.}-{2:2}, at: bpf_trace_printk+0xcf/0x170 kernel/trace/bpf_trace.c:374

other info that might help us debug this:
 Possible unsafe locking scenario:

       CPU0
       ----
  lock(trace_printk_lock);
  lock(trace_printk_lock);

 *** DEADLOCK ***

 May be due to missing lock nesting notation

4 locks held by syz-executor354/3616:
 #0: ffffffff8be67668 (delayed_uprobe_lock){+.+.}-{3:3}, at: uprobe_clear_state+0x47/0x420 kernel/events/uprobes.c:1544
 #1: ffffffff8bd86be0 (rcu_read_lock){....}-{1:2}, at: bpf_trace_run2+0x0/0x340 kernel/trace/./bpf_trace.h:11
 #2: ffffffff8be0d6d8 (trace_printk_lock){..-.}-{2:2}, at: ____bpf_trace_printk kernel/trace/bpf_trace.c:388 [inline]
 #2: ffffffff8be0d6d8 (trace_printk_lock){..-.}-{2:2}, at: bpf_trace_printk+0xcf/0x170 kernel/trace/bpf_trace.c:374
 #3: ffffffff8bd86be0 (rcu_read_lock){....}-{1:2}, at: bpf_trace_run2+0x0/0x340 kernel/trace/./bpf_trace.h:11

stack backtrace:
CPU: 1 PID: 3616 Comm: syz-executor354 Not tainted 5.18.0-syzkaller-12122-gd678cbd2f867 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106
 print_deadlock_bug kernel/locking/lockdep.c:2988 [inline]
 check_deadlock kernel/locking/lockdep.c:3031 [inline]
 validate_chain kernel/locking/lockdep.c:3816 [inline]
 __lock_acquire.cold+0x1f5/0x3b4 kernel/locking/lockdep.c:5053
 lock_acquire kernel/locking/lockdep.c:5665 [inline]
 lock_acquire+0x1ab/0x570 kernel/locking/lockdep.c:5630
 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
 _raw_spin_lock_irqsave+0x39/0x50 kernel/locking/spinlock.c:162
 ____bpf_trace_printk kernel/trace/bpf_trace.c:388 [inline]
 bpf_trace_printk+0xcf/0x170 kernel/trace/bpf_trace.c:374
 bpf_prog_0605f9f479290f07+0x2f/0x33
 bpf_dispatcher_nop_func include/linux/bpf.h:869 [inline]
 __bpf_prog_run include/linux/filter.h:628 [inline]
 bpf_prog_run include/linux/filter.h:635 [inline]
 __bpf_trace_run kernel/trace/bpf_trace.c:2046 [inline]
 bpf_trace_run2+0x110/0x340 kernel/trace/bpf_trace.c:2083
 __bpf_trace_contention_begin+0xb5/0xf0 include/trace/events/lock.h:95
 trace_contention_begin.constprop.0+0xda/0x1b0 include/trace/events/lock.h:95
 __pv_queued_spin_lock_slowpath+0x103/0xb50 kernel/locking/qspinlock.c:405
 pv_queued_spin_lock_slowpath arch/x86/include/asm/paravirt.h:591 [inline]
 queued_spin_lock_slowpath arch/x86/include/asm/qspinlock.h:51 [inline]
 queued_spin_lock include/asm-generic/qspinlock.h:114 [inline]
 do_raw_spin_lock+0x200/0x2a0 kernel/locking/spinlock_debug.c:115
 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:111 [inline]
 _raw_spin_lock_irqsave+0x41/0x50 kernel/locking/spinlock.c:162
 ____bpf_trace_printk kernel/trace/bpf_trace.c:388 [inline]
 bpf_trace_printk+0xcf/0x170 kernel/trace/bpf_trace.c:374
 bpf_prog_0605f9f479290f07+0x2f/0x33
 bpf_dispatcher_nop_func include/linux/bpf.h:869 [inline]
 __bpf_prog_run include/linux/filter.h:628 [inline]
 bpf_prog_run include/linux/filter.h:635 [inline]
 __bpf_trace_run kernel/trace/bpf_trace.c:2046 [inline]
 bpf_trace_run2+0x110/0x340 kernel/trace/bpf_trace.c:2083
 __bpf_trace_contention_begin+0xb5/0xf0 include/trace/events/lock.h:95
 trace_contention_begin+0xc0/0x150 include/trace/events/lock.h:95
 __mutex_lock_common kernel/locking/mutex.c:605 [inline]
 __mutex_lock+0x13c/0x1350 kernel/locking/mutex.c:747
 uprobe_clear_state+0x47/0x420 kernel/events/uprobes.c:1544
 __mmput+0x73/0x4b0 kernel/fork.c:1183
 mmput+0x56/0x60 kernel/fork.c:1208
 exit_mm kernel/exit.c:510 [inline]
 do_exit+0xa12/0x2a00 kernel/exit.c:782
 do_group_exit+0xd2/0x2f0 kernel/exit.c:925
 __do_sys_exit_group kernel/exit.c:936 [inline]
 __se_sys_exit_group kernel/exit.c:934 [inline]
 __x64_sys_exit_group+0x3a/0x50 kernel/exit.c:934
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x46/0xb0
RIP: 0033:0x7f15c46e1139
Code: Unable to access opcode bytes at RIP 0x7f15c46e110f.
RSP: 002b:00007ffd3b43d738 EFLAGS: 00000246 ORIG_RAX: 00000000000000e7
RAX: ffffffffffffffda RBX: 00007f15c475c330 RCX: 00007f15c46e1139
RDX: 000000000000003c RSI: 00000000000000e7 RDI: 0000000000000000
RBP: 0000000000000000 R08: ffffffffffffffc0 R09: 00007f15c4756ec0
R10: 00007ffd3b43d200 R11: 0000000000000246 R12: 00007f15c475c330
R13: 0000000000000001 R14: 0000000000000000 R15: 0000000000000001
 </TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
For information about bisection process see: https://goo.gl/tpsmEJ#bisection
syzbot can test patches for this issue, for details see:
https://goo.gl/tpsmEJ#testing-patches

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [syzbot] [bpf?] [trace?] possible deadlock in bpf_trace_printk
  2022-06-09 17:07 [syzbot] possible deadlock in bpf_trace_printk syzbot
@ 2023-03-22  9:29 ` syzbot
  2023-03-23  7:50   ` Dmitry Vyukov
  0 siblings, 1 reply; 4+ messages in thread
From: syzbot @ 2023-03-22  9:29 UTC (permalink / raw)
  To: andrii, ast, boqun.feng, bpf, daniel, davem, fgheet255t, haoluo,
	hawk, hdanton, john.fastabend, jolsa, kafai, kpsingh, kuba,
	linux-kernel, linux-trace-kernel, longman, martin.lau, mingo,
	netdev, peterz, rostedt, sdf, song, songliubraving,
	syzkaller-bugs, will, yhs

syzbot suspects this issue was fixed by commit:

commit 05b24ff9b2cfabfcfd951daaa915a036ab53c9e1
Author: Jiri Olsa <jolsa@kernel.org>
Date:   Fri Sep 16 07:19:14 2022 +0000

    bpf: Prevent bpf program recursion for raw tracepoint probes

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=10a653d6c80000
start commit:   a335366bad13 Merge tag 'gpio-fixes-for-v6.0-rc6' of git://..
git tree:       upstream
kernel config:  https://syzkaller.appspot.com/x/.config?x=9e66520f224211a2
dashboard link: https://syzkaller.appspot.com/bug?extid=c49e17557ddb5725583d
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=16e27480880000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=12737fbf080000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: bpf: Prevent bpf program recursion for raw tracepoint probes

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [syzbot] [bpf?] [trace?] possible deadlock in bpf_trace_printk
  2023-03-22  9:29 ` [syzbot] [bpf?] [trace?] " syzbot
@ 2023-03-23  7:50   ` Dmitry Vyukov
  2023-03-23 11:30     ` Jiri Olsa
  0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Vyukov @ 2023-03-23  7:50 UTC (permalink / raw)
  To: syzbot
  Cc: andrii, ast, boqun.feng, bpf, daniel, davem, fgheet255t, haoluo,
	hawk, hdanton, john.fastabend, jolsa, kafai, kpsingh, kuba,
	linux-kernel, linux-trace-kernel, longman, martin.lau, mingo,
	netdev, peterz, rostedt, sdf, song, songliubraving,
	syzkaller-bugs, will, yhs

On Wed, 22 Mar 2023 at 10:29, syzbot
<syzbot+c49e17557ddb5725583d@syzkaller.appspotmail.com> wrote:
>
> syzbot suspects this issue was fixed by commit:
>
> commit 05b24ff9b2cfabfcfd951daaa915a036ab53c9e1
> Author: Jiri Olsa <jolsa@kernel.org>
> Date:   Fri Sep 16 07:19:14 2022 +0000
>
>     bpf: Prevent bpf program recursion for raw tracepoint probes
>
> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=10a653d6c80000
> start commit:   a335366bad13 Merge tag 'gpio-fixes-for-v6.0-rc6' of git://..
> git tree:       upstream
> kernel config:  https://syzkaller.appspot.com/x/.config?x=9e66520f224211a2
> dashboard link: https://syzkaller.appspot.com/bug?extid=c49e17557ddb5725583d
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=16e27480880000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=12737fbf080000
>
> If the result looks correct, please mark the issue as fixed by replying with:
>
> #syz fix: bpf: Prevent bpf program recursion for raw tracepoint probes
>
> For information about bisection process see: https://goo.gl/tpsmEJ#bisection

Looks reasonable:

#syz fix: bpf: Prevent bpf program recursion for raw tracepoint probes

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [syzbot] [bpf?] [trace?] possible deadlock in bpf_trace_printk
  2023-03-23  7:50   ` Dmitry Vyukov
@ 2023-03-23 11:30     ` Jiri Olsa
  0 siblings, 0 replies; 4+ messages in thread
From: Jiri Olsa @ 2023-03-23 11:30 UTC (permalink / raw)
  To: Dmitry Vyukov
  Cc: syzbot, andrii, ast, boqun.feng, bpf, daniel, davem, fgheet255t,
	haoluo, hawk, hdanton, john.fastabend, kafai, kpsingh, kuba,
	linux-kernel, linux-trace-kernel, longman, martin.lau, mingo,
	netdev, peterz, rostedt, sdf, song, songliubraving,
	syzkaller-bugs, will, yhs

On Thu, Mar 23, 2023 at 08:50:10AM +0100, Dmitry Vyukov wrote:
> On Wed, 22 Mar 2023 at 10:29, syzbot
> <syzbot+c49e17557ddb5725583d@syzkaller.appspotmail.com> wrote:
> >
> > syzbot suspects this issue was fixed by commit:
> >
> > commit 05b24ff9b2cfabfcfd951daaa915a036ab53c9e1
> > Author: Jiri Olsa <jolsa@kernel.org>
> > Date:   Fri Sep 16 07:19:14 2022 +0000
> >
> >     bpf: Prevent bpf program recursion for raw tracepoint probes
> >
> > bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=10a653d6c80000
> > start commit:   a335366bad13 Merge tag 'gpio-fixes-for-v6.0-rc6' of git://..
> > git tree:       upstream
> > kernel config:  https://syzkaller.appspot.com/x/.config?x=9e66520f224211a2
> > dashboard link: https://syzkaller.appspot.com/bug?extid=c49e17557ddb5725583d
> > syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=16e27480880000
> > C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=12737fbf080000
> >
> > If the result looks correct, please mark the issue as fixed by replying with:
> >
> > #syz fix: bpf: Prevent bpf program recursion for raw tracepoint probes
> >
> > For information about bisection process see: https://goo.gl/tpsmEJ#bisection
> 
> Looks reasonable:
> 
> #syz fix: bpf: Prevent bpf program recursion for raw tracepoint probes

agreed, thanks

jirka

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-23 11:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-09 17:07 [syzbot] possible deadlock in bpf_trace_printk syzbot
2023-03-22  9:29 ` [syzbot] [bpf?] [trace?] " syzbot
2023-03-23  7:50   ` Dmitry Vyukov
2023-03-23 11:30     ` Jiri Olsa

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.