WARNING: suspicious RCU usage in ctrl_cmd_new_lookup

WARNING: suspicious RCU usage in ctrl_cmd_new_lookup

[syzbot]

Hello,

syzbot found the following crash on:

HEAD commit:    7ae77150 Merge tag 'powerpc-5.8-1' of git://git.kernel.org..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=14a3bcf9100000
kernel config:  https://syzkaller.appspot.com/x/.config?x=d195fe572fb15312
dashboard link: https://syzkaller.appspot.com/bug?extid=3025b9294f8cb0ede850
compiler:       gcc (GCC) 9.0.0 20181231 (experimental)
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=11802cf9100000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=144acc03100000

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+3025b9294f8cb0ede850@syzkaller.appspotmail.com

=============================
WARNING: suspicious RCU usage
5.7.0-syzkaller #0 Not tainted
-----------------------------
include/linux/radix-tree.h:176 suspicious rcu_dereference_check() usage!

other info that might help us debug this:


rcu_scheduler_active = 2, debug_locks = 1
2 locks held by kworker/u4:0/7:
 #0: ffff88821b0bd138 ((wq_completion)qrtr_ns_handler){+.+.}-{0:0}, at: __write_once_size include/linux/compiler.h:279 [inline]
 #0: ffff88821b0bd138 ((wq_completion)qrtr_ns_handler){+.+.}-{0:0}, at: arch_atomic64_set arch/x86/include/asm/atomic64_64.h:34 [inline]
 #0: ffff88821b0bd138 ((wq_completion)qrtr_ns_handler){+.+.}-{0:0}, at: atomic64_set include/asm-generic/atomic-instrumented.h:855 [inline]
 #0: ffff88821b0bd138 ((wq_completion)qrtr_ns_handler){+.+.}-{0:0}, at: atomic_long_set include/asm-generic/atomic-long.h:40 [inline]
 #0: ffff88821b0bd138 ((wq_completion)qrtr_ns_handler){+.+.}-{0:0}, at: set_work_data kernel/workqueue.c:615 [inline]
 #0: ffff88821b0bd138 ((wq_completion)qrtr_ns_handler){+.+.}-{0:0}, at: set_work_pool_and_clear_pending kernel/workqueue.c:642 [inline]
 #0: ffff88821b0bd138 ((wq_completion)qrtr_ns_handler){+.+.}-{0:0}, at: process_one_work+0x844/0x16a0 kernel/workqueue.c:2239
 #1: ffffc90000cdfdc0 ((work_completion)(&qrtr_ns.work)){+.+.}-{0:0}, at: process_one_work+0x878/0x16a0 kernel/workqueue.c:2243

stack backtrace:
CPU: 1 PID: 7 Comm: kworker/u4:0 Not tainted 5.7.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: qrtr_ns_handler qrtr_ns_worker
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x188/0x20d lib/dump_stack.c:118
 radix_tree_deref_slot include/linux/radix-tree.h:176 [inline]
 radix_tree_deref_slot include/linux/radix-tree.h:174 [inline]
 ctrl_cmd_new_lookup+0x6eb/0x7e0 net/qrtr/ns.c:558
 qrtr_ns_worker+0x5a1/0x153a net/qrtr/ns.c:674
 process_one_work+0x965/0x16a0 kernel/workqueue.c:2268


---
This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this bug, for details see:
https://goo.gl/tpsmEJ#testing-patches

Re: WARNING: suspicious RCU usage in ctrl_cmd_new_lookup

[syzbot]

syzbot has bisected this bug to:

commit e42671084361302141a09284fde9bbc14fdd16bf
Author: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Date:   Thu May 7 12:53:06 2020 +0000

    net: qrtr: Do not depend on ARCH_QCOM

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=131c54a7100000
start commit:   7ae77150 Merge tag 'powerpc-5.8-1' of git://git.kernel.org..
git tree:       upstream
final crash:    https://syzkaller.appspot.com/x/report.txt?x=109c54a7100000
console output: https://syzkaller.appspot.com/x/log.txt?x=171c54a7100000
kernel config:  https://syzkaller.appspot.com/x/.config?x=d195fe572fb15312
dashboard link: https://syzkaller.appspot.com/bug?extid=3025b9294f8cb0ede850
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=11802cf9100000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=144acc03100000

Reported-by: syzbot+3025b9294f8cb0ede850@syzkaller.appspotmail.com
Fixes: e42671084361 ("net: qrtr: Do not depend on ARCH_QCOM")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

Re: WARNING: suspicious RCU usage in ctrl_cmd_new_lookup

[syzbot]

syzbot suspects this issue was fixed by commit:

commit a7809ff90ce6c48598d3c4ab54eb599bec1e9c42
Author: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Date:   Sat Sep 26 16:56:25 2020 +0000

    net: qrtr: ns: Protect radix_tree_deref_slot() using rcu read locks

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=143867c8500000
start commit:   7ae77150 Merge tag 'powerpc-5.8-1' of git://git.kernel.org..
git tree:       upstream
kernel config:  https://syzkaller.appspot.com/x/.config?x=d195fe572fb15312
dashboard link: https://syzkaller.appspot.com/bug?extid=3025b9294f8cb0ede850
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=11802cf9100000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=144acc03100000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: net: qrtr: ns: Protect radix_tree_deref_slot() using rcu read locks

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

Re: WARNING: suspicious RCU usage in ctrl_cmd_new_lookup

[Dmitry Vyukov]

On Thu, Oct 22, 2020 at 2:40 PM syzbot
<syzbot+3025b9294f8cb0ede850@syzkaller.appspotmail.com> wrote:
>
> syzbot suspects this issue was fixed by commit:
>
> commit a7809ff90ce6c48598d3c4ab54eb599bec1e9c42
> Author: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Date:   Sat Sep 26 16:56:25 2020 +0000
>
>     net: qrtr: ns: Protect radix_tree_deref_slot() using rcu read locks
>
> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=143867c8500000
> start commit:   7ae77150 Merge tag 'powerpc-5.8-1' of git://git.kernel.org..
> git tree:       upstream
> kernel config:  https://syzkaller.appspot.com/x/.config?x=d195fe572fb15312
> dashboard link: https://syzkaller.appspot.com/bug?extid=3025b9294f8cb0ede850
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=11802cf9100000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=144acc03100000
>
> If the result looks correct, please mark the issue as fixed by replying with:
>
> #syz fix: net: qrtr: ns: Protect radix_tree_deref_slot() using rcu read locks
>
> For information about bisection process see: https://goo.gl/tpsmEJ#bisection

#syz fix: net: qrtr: ns: Protect radix_tree_deref_slot() using rcu read locks