* WARNING: suspicious RCU usage in in_dev_dump_addr
@ 2019-06-03 18:51 ` syzbot
0 siblings, 0 replies; 5+ messages in thread
From: syzbot @ 2019-06-03 18:51 UTC (permalink / raw)
To: amitkarwar, anshuman.khandual, axboe, benedictwong, benve,
coreteam, davej, davem, dbanerje, devel, dledford, doshir,
edumazet, faisal.latif, fw, gbhat, gregkh, gustavo, huxinming820,
idosch, jakub.kicinski, jgg, johannes, kadlec, keescook, kuznet,
kvalo, linux-kernel, linux-rdma, linux-wireless, liuhangbin,
lucien.xin, matwey, mpe, neescoba, netdev, netfilter-devel,
nishants, pablo, paulmck, petrm, pkaustub, pv-drivers, romieu,
shannon.nelson, shiraz.saleem, steffen.klassert, syzkaller-bugs,
yoshfuji
Hello,
syzbot found the following crash on:
HEAD commit: b33bc2b8 nexthop: Add entry to MAINTAINERS
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=13f46f52a00000
kernel config: https://syzkaller.appspot.com/x/.config?x=1004db091673bbaf
dashboard link: https://syzkaller.appspot.com/bug?extid=bad6e32808a3a97b1515
compiler: gcc (GCC) 9.0.0 20181231 (experimental)
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11dc685aa00000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=16229e36a00000
The bug was bisected to:
commit 2638eb8b50cfc16240e0bb080b9afbf541a9b39d
Author: Florian Westphal <fw@strlen.de>
Date: Fri May 31 16:27:09 2019 +0000
net: ipv4: provide __rcu annotation for ifa_list
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=170e1a0ea00000
final crash: https://syzkaller.appspot.com/x/report.txt?x=148e1a0ea00000
console output: https://syzkaller.appspot.com/x/log.txt?x=108e1a0ea00000
IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+bad6e32808a3a97b1515@syzkaller.appspotmail.com
Fixes: 2638eb8b50cf ("net: ipv4: provide __rcu annotation for ifa_list")
=============================
WARNING: suspicious RCU usage
5.2.0-rc2+ #13 Not tainted
-----------------------------
net/ipv4/devinet.c:1766 suspicious rcu_dereference_check() usage!
other info that might help us debug this:
rcu_scheduler_active = 2, debug_locks = 1
1 lock held by syz-executor924/9000:
#0: 0000000087fe3874 (rtnl_mutex){+.+.}, at: netlink_dump+0xe7/0xfb0
net/netlink/af_netlink.c:2208
stack backtrace:
CPU: 0 PID: 9000 Comm: syz-executor924 Not tainted 5.2.0-rc2+ #13
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x172/0x1f0 lib/dump_stack.c:113
lockdep_rcu_suspicious+0x153/0x15d kernel/locking/lockdep.c:5250
in_dev_dump_addr+0x36f/0x3d0 net/ipv4/devinet.c:1766
inet_dump_ifaddr+0xa8f/0xca0 net/ipv4/devinet.c:1826
rtnl_dump_all+0x295/0x490 net/core/rtnetlink.c:3444
netlink_dump+0x558/0xfb0 net/netlink/af_netlink.c:2253
__netlink_dump_start+0x5b1/0x7d0 net/netlink/af_netlink.c:2361
netlink_dump_start include/linux/netlink.h:226 [inline]
rtnetlink_rcv_msg+0x73d/0xb00 net/core/rtnetlink.c:5181
netlink_rcv_skb+0x177/0x450 net/netlink/af_netlink.c:2486
rtnetlink_rcv+0x1d/0x30 net/core/rtnetlink.c:5236
netlink_unicast_kernel net/netlink/af_netlink.c:1311 [inline]
netlink_unicast+0x531/0x710 net/netlink/af_netlink.c:1337
netlink_sendmsg+0x8ae/0xd70 net/netlink/af_netlink.c:1926
sock_sendmsg_nosec net/socket.c:652 [inline]
sock_sendmsg+0xd7/0x130 net/socket.c:671
___sys_sendmsg+0x803/0x920 net/socket.c:2292
__sys_sendmsg+0x105/0x1d0 net/socket.c:2330
__do_sys_sendmsg net/socket.c:2339 [inline]
__se_sys_sendmsg net/socket.c:2337 [inline]
__x64_sys_sendmsg+0x78/0xb0 net/socket.c:2337
do_syscall_64+0xfd/0x680 arch/x86/entry/common.c:301
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x4402a9
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7
48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff
ff 0f 83 fb 13 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007fffe5f26f18 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00000000004002c8 RCX: 00000000004402a9
RDX: 0000000000000000 RSI: 0000000020000240 RDI: 0000000000000003
RBP: 00000000006ca018 R08: 00000000004002c8 R09: 00000000004002c8
R10:
---
This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.
syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
For information about bisection process see: https://goo.gl/tpsmEJ#bisection
syzbot can test patches for this bug, for details see:
https://goo.gl/tpsmEJ#testing-patches
^ permalink raw reply [flat|nested] 5+ messages in thread
* WARNING: suspicious RCU usage in in_dev_dump_addr
@ 2019-06-03 18:51 ` syzbot
0 siblings, 0 replies; 5+ messages in thread
From: syzbot @ 2019-06-03 18:51 UTC (permalink / raw)
To: amitkarwar-Re5JQEeQqe8AvxtiuMwx3w, anshuman.khandual-5wv7dgnIgG8,
axboe-tSWWG44O7X1aa/9Udqfwiw,
benedictwong-hpIqsD4AKlfQT0dZR+AlfA,
benve-FYB4Gu1CFyUAvxtiuMwx3w, coreteam-Cap9r6Oaw4JrovVCs/uTlw,
davej-rdkfGonbjUTCLXcRTR1eJlpr/1R2p/CL,
davem-fT/PcQaiUtIeIZ0/mPfg9Q, dbanerje-JqFfY2XvxFXQT0dZR+AlfA,
devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b,
dledford-H+wXaHxf7aLQT0dZR+AlfA, doshir-pghWNbHTmq7QT0dZR+AlfA,
edumazet-hpIqsD4AKlfQT0dZR+AlfA,
faisal.latif-ral2JQCrhuEAvxtiuMwx3w, fw-HFFVJYpyMKqzQB+pC5nmwQ,
gbhat-eYqpPyKDWXRBDgjK7y7TUQ,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r,
gustavo-L1vi/lXTdts+Va1GwOuvDg,
huxinming820-Re5JQEeQqe8AvxtiuMwx3w,
idosch-VPRAkNaXOzVWk0Htik3J/w,
jakub.kicinski-wFxRvT7yatFl57MIdRCFDg, jgg-uk2M96/98Pc,
johannes-cdvu00un1VgdHxzADdlk8Q,
kadlec-K40Dz/62t/MgiyqX0sVFJYdd74u8MsAO,
keescook-F7+t8E8rja9g9hUCZPvPmw, kuznet-v/Mj1YrvjDBInbfyfbPRSQ,
kvalo-sgV2jX0FEOL9JmXXK+q4OQ,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
liuhangbin-Re5JQEeQqe8AvxtiuMwx3w,
lucien.xin-Re5JQEeQqe8AvxtiuMwx3w, matwey-TTlVxmypnbovJsYlp49lxw,
mpe-Gsx/Oe8HsFggBc27wqDAHg, neescoba
Hello,
syzbot found the following crash on:
HEAD commit: b33bc2b8 nexthop: Add entry to MAINTAINERS
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=13f46f52a00000
kernel config: https://syzkaller.appspot.com/x/.config?x=1004db091673bbaf
dashboard link: https://syzkaller.appspot.com/bug?extid=bad6e32808a3a97b1515
compiler: gcc (GCC) 9.0.0 20181231 (experimental)
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11dc685aa00000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=16229e36a00000
The bug was bisected to:
commit 2638eb8b50cfc16240e0bb080b9afbf541a9b39d
Author: Florian Westphal <fw-HFFVJYpyMKqzQB+pC5nmwQ@public.gmane.org>
Date: Fri May 31 16:27:09 2019 +0000
net: ipv4: provide __rcu annotation for ifa_list
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=170e1a0ea00000
final crash: https://syzkaller.appspot.com/x/report.txt?x=148e1a0ea00000
console output: https://syzkaller.appspot.com/x/log.txt?x=108e1a0ea00000
IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+bad6e32808a3a97b1515-Pl5Pbv+GP7P466ipTTIvnc23WoclnBCfAL8bYrjMMd8@public.gmane.org
Fixes: 2638eb8b50cf ("net: ipv4: provide __rcu annotation for ifa_list")
=============================
WARNING: suspicious RCU usage
5.2.0-rc2+ #13 Not tainted
-----------------------------
net/ipv4/devinet.c:1766 suspicious rcu_dereference_check() usage!
other info that might help us debug this:
rcu_scheduler_active = 2, debug_locks = 1
1 lock held by syz-executor924/9000:
#0: 0000000087fe3874 (rtnl_mutex){+.+.}, at: netlink_dump+0xe7/0xfb0
net/netlink/af_netlink.c:2208
stack backtrace:
CPU: 0 PID: 9000 Comm: syz-executor924 Not tainted 5.2.0-rc2+ #13
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x172/0x1f0 lib/dump_stack.c:113
lockdep_rcu_suspicious+0x153/0x15d kernel/locking/lockdep.c:5250
in_dev_dump_addr+0x36f/0x3d0 net/ipv4/devinet.c:1766
inet_dump_ifaddr+0xa8f/0xca0 net/ipv4/devinet.c:1826
rtnl_dump_all+0x295/0x490 net/core/rtnetlink.c:3444
netlink_dump+0x558/0xfb0 net/netlink/af_netlink.c:2253
__netlink_dump_start+0x5b1/0x7d0 net/netlink/af_netlink.c:2361
netlink_dump_start include/linux/netlink.h:226 [inline]
rtnetlink_rcv_msg+0x73d/0xb00 net/core/rtnetlink.c:5181
netlink_rcv_skb+0x177/0x450 net/netlink/af_netlink.c:2486
rtnetlink_rcv+0x1d/0x30 net/core/rtnetlink.c:5236
netlink_unicast_kernel net/netlink/af_netlink.c:1311 [inline]
netlink_unicast+0x531/0x710 net/netlink/af_netlink.c:1337
netlink_sendmsg+0x8ae/0xd70 net/netlink/af_netlink.c:1926
sock_sendmsg_nosec net/socket.c:652 [inline]
sock_sendmsg+0xd7/0x130 net/socket.c:671
___sys_sendmsg+0x803/0x920 net/socket.c:2292
__sys_sendmsg+0x105/0x1d0 net/socket.c:2330
__do_sys_sendmsg net/socket.c:2339 [inline]
__se_sys_sendmsg net/socket.c:2337 [inline]
__x64_sys_sendmsg+0x78/0xb0 net/socket.c:2337
do_syscall_64+0xfd/0x680 arch/x86/entry/common.c:301
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x4402a9
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7
48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff
ff 0f 83 fb 13 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007fffe5f26f18 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00000000004002c8 RCX: 00000000004402a9
RDX: 0000000000000000 RSI: 0000000020000240 RDI: 0000000000000003
RBP: 00000000006ca018 R08: 00000000004002c8 R09: 00000000004002c8
R10:
---
This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
For information about bisection process see: https://goo.gl/tpsmEJ#bisection
syzbot can test patches for this bug, for details see:
https://goo.gl/tpsmEJ#testing-patches
^ permalink raw reply [flat|nested] 5+ messages in thread
* WARNING: suspicious RCU usage in in_dev_dump_addr
@ 2019-06-03 18:51 ` syzbot
0 siblings, 0 replies; 5+ messages in thread
From: syzbot @ 2019-06-03 18:51 UTC (permalink / raw)
To: amitkarwar, anshuman.khandual, axboe, benedictwong, benve,
coreteam, davej, davem, dbanerje, devel, dledford, doshir,
edumazet, faisal.latif, fw, gbhat, gregkh, gustavo, huxinming820,
idosch, jakub.kicinski, jgg, johannes, kadlec, keescook, kuznet,
kvalo, linux-kernel, linux-rdma, linux-wireless, liuhangbin,
lucien.xin, matwey, mpe, neescoba, netdev, netfilter-devel,
nishants, pablo, paulmck, petrm, pkaustub, pv-drivers, romieu,
shannon.nelson, shiraz.saleem, steffen.klassert, syzkaller-bugs,
yoshfuji
Hello,
syzbot found the following crash on:
HEAD commit: b33bc2b8 nexthop: Add entry to MAINTAINERS
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=13f46f52a00000
kernel config: https://syzkaller.appspot.com/x/.config?x=1004db091673bbaf
dashboard link: https://syzkaller.appspot.com/bug?extid=bad6e32808a3a97b1515
compiler: gcc (GCC) 9.0.0 20181231 (experimental)
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11dc685aa00000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=16229e36a00000
The bug was bisected to:
commit 2638eb8b50cfc16240e0bb080b9afbf541a9b39d
Author: Florian Westphal <fw@strlen.de>
Date: Fri May 31 16:27:09 2019 +0000
net: ipv4: provide __rcu annotation for ifa_list
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=170e1a0ea00000
final crash: https://syzkaller.appspot.com/x/report.txt?x=148e1a0ea00000
console output: https://syzkaller.appspot.com/x/log.txt?x=108e1a0ea00000
IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+bad6e32808a3a97b1515@syzkaller.appspotmail.com
Fixes: 2638eb8b50cf ("net: ipv4: provide __rcu annotation for ifa_list")
=============================
WARNING: suspicious RCU usage
5.2.0-rc2+ #13 Not tainted
-----------------------------
net/ipv4/devinet.c:1766 suspicious rcu_dereference_check() usage!
other info that might help us debug this:
rcu_scheduler_active = 2, debug_locks = 1
1 lock held by syz-executor924/9000:
#0: 0000000087fe3874 (rtnl_mutex){+.+.}, at: netlink_dump+0xe7/0xfb0
net/netlink/af_netlink.c:2208
stack backtrace:
CPU: 0 PID: 9000 Comm: syz-executor924 Not tainted 5.2.0-rc2+ #13
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x172/0x1f0 lib/dump_stack.c:113
lockdep_rcu_suspicious+0x153/0x15d kernel/locking/lockdep.c:5250
in_dev_dump_addr+0x36f/0x3d0 net/ipv4/devinet.c:1766
inet_dump_ifaddr+0xa8f/0xca0 net/ipv4/devinet.c:1826
rtnl_dump_all+0x295/0x490 net/core/rtnetlink.c:3444
netlink_dump+0x558/0xfb0 net/netlink/af_netlink.c:2253
__netlink_dump_start+0x5b1/0x7d0 net/netlink/af_netlink.c:2361
netlink_dump_start include/linux/netlink.h:226 [inline]
rtnetlink_rcv_msg+0x73d/0xb00 net/core/rtnetlink.c:5181
netlink_rcv_skb+0x177/0x450 net/netlink/af_netlink.c:2486
rtnetlink_rcv+0x1d/0x30 net/core/rtnetlink.c:5236
netlink_unicast_kernel net/netlink/af_netlink.c:1311 [inline]
netlink_unicast+0x531/0x710 net/netlink/af_netlink.c:1337
netlink_sendmsg+0x8ae/0xd70 net/netlink/af_netlink.c:1926
sock_sendmsg_nosec net/socket.c:652 [inline]
sock_sendmsg+0xd7/0x130 net/socket.c:671
___sys_sendmsg+0x803/0x920 net/socket.c:2292
__sys_sendmsg+0x105/0x1d0 net/socket.c:2330
__do_sys_sendmsg net/socket.c:2339 [inline]
__se_sys_sendmsg net/socket.c:2337 [inline]
__x64_sys_sendmsg+0x78/0xb0 net/socket.c:2337
do_syscall_64+0xfd/0x680 arch/x86/entry/common.c:301
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x4402a9
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7
48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff
ff 0f 83 fb 13 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007fffe5f26f18 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00000000004002c8 RCX: 00000000004402a9
RDX: 0000000000000000 RSI: 0000000020000240 RDI: 0000000000000003
RBP: 00000000006ca018 R08: 00000000004002c8 R09: 00000000004002c8
R10:
---
This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.
syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
For information about bisection process see: https://goo.gl/tpsmEJ#bisection
syzbot can test patches for this bug, for details see:
https://goo.gl/tpsmEJ#testing-patches
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH net-next] net: ipv4: fix rcu lockdep splat due to wrong annotation
2019-06-03 18:51 ` syzbot
(?)
(?)
@ 2019-06-03 20:41 ` Florian Westphal
2019-06-04 21:24 ` David Miller
-1 siblings, 1 reply; 5+ messages in thread
From: Florian Westphal @ 2019-06-03 20:41 UTC (permalink / raw)
To: netdev; +Cc: syzbot+bad6e32808a3a97b1515, Florian Westphal
syzbot triggered following splat when strict netlink
validation is enabled:
net/ipv4/devinet.c:1766 suspicious rcu_dereference_check() usage!
This occurs because we hold RTNL mutex, but no rcu read lock.
The second call site holds both, so just switch to the _rtnl variant.
Reported-by: syzbot+bad6e32808a3a97b1515@syzkaller.appspotmail.com
Fixes: 2638eb8b50cf ("net: ipv4: provide __rcu annotation for ifa_list")
Signed-off-by: Florian Westphal <fw@strlen.de>
---
net/ipv4/devinet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
index ebaea05b4033..ed2e2dc745cd 100644
--- a/net/ipv4/devinet.c
+++ b/net/ipv4/devinet.c
@@ -1763,7 +1763,7 @@ static int in_dev_dump_addr(struct in_device *in_dev, struct sk_buff *skb,
int ip_idx = 0;
int err;
- in_dev_for_each_ifa_rcu(ifa, in_dev) {
+ in_dev_for_each_ifa_rtnl(ifa, in_dev) {
if (ip_idx < s_ip_idx) {
ip_idx++;
continue;
--
2.21.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] net: ipv4: fix rcu lockdep splat due to wrong annotation
2019-06-03 20:41 ` [PATCH net-next] net: ipv4: fix rcu lockdep splat due to wrong annotation Florian Westphal
@ 2019-06-04 21:24 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2019-06-04 21:24 UTC (permalink / raw)
To: fw; +Cc: netdev, syzbot+bad6e32808a3a97b1515
From: Florian Westphal <fw@strlen.de>
Date: Mon, 3 Jun 2019 22:41:44 +0200
> syzbot triggered following splat when strict netlink
> validation is enabled:
>
> net/ipv4/devinet.c:1766 suspicious rcu_dereference_check() usage!
>
> This occurs because we hold RTNL mutex, but no rcu read lock.
> The second call site holds both, so just switch to the _rtnl variant.
>
> Reported-by: syzbot+bad6e32808a3a97b1515@syzkaller.appspotmail.com
> Fixes: 2638eb8b50cf ("net: ipv4: provide __rcu annotation for ifa_list")
> Signed-off-by: Florian Westphal <fw@strlen.de>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-04 21:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-03 18:51 WARNING: suspicious RCU usage in in_dev_dump_addr syzbot
2019-06-03 18:51 ` syzbot
2019-06-03 18:51 ` syzbot
2019-06-03 20:41 ` [PATCH net-next] net: ipv4: fix rcu lockdep splat due to wrong annotation Florian Westphal
2019-06-04 21:24 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.