[syzbot] [btrfs?] WARNING in btrfs_release_global_block_rsv

[syzbot] [btrfs?] WARNING in btrfs_release_global_block_rsv

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit:    8a511e7efc5a Merge tag 'for-linus' of git://git.kernel.org..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=133af832680000
kernel config:  https://syzkaller.appspot.com/x/.config?x=d594086f139d167
dashboard link: https://syzkaller.appspot.com/bug?extid=10e8dae9863cb83db623
compiler:       gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/943dcd094ce2/disk-8a511e7e.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/8647d59633ee/vmlinux-8a511e7e.xz
kernel image: https://storage.googleapis.com/syzbot-assets/9c6b0fed6523/bzImage-8a511e7e.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+10e8dae9863cb83db623@syzkaller.appspotmail.com

------------[ cut here ]------------
WARNING: CPU: 0 PID: 5077 at fs/btrfs/block-rsv.c:451 btrfs_release_global_block_rsv+0x279/0x2e0 fs/btrfs/block-rsv.c:451
Modules linked in:
CPU: 0 PID: 5077 Comm: syz-executor.0 Not tainted 6.6.0-rc2-syzkaller-00414-g8a511e7efc5a #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/04/2023
RIP: 0010:btrfs_release_global_block_rsv+0x279/0x2e0 fs/btrfs/block-rsv.c:451
Code: ff e8 bb ff ef fd 0f 0b e9 c9 fe ff ff e8 af ff ef fd 0f 0b e9 fe fe ff ff e8 a3 ff ef fd 0f 0b e9 33 ff ff ff e8 97 ff ef fd <0f> 0b e9 68 ff ff ff e8 8b ff ef fd 0f 0b 5b 5d e9 82 ff ef fd e8
RSP: 0018:ffffc90003c7fb78 EFLAGS: 00010293
RAX: 0000000000000000 RBX: ffff88807a310000 RCX: 0000000000000000
RDX: ffff888026559dc0 RSI: ffffffff8397c729 RDI: 0000000000000007
RBP: 000000000000e000 R08: 0000000000000007 R09: 0000000000000000
R10: 000000000000e000 R11: 0000000000000001 R12: dffffc0000000000
R13: 0000000000000001 R14: ffff888067b4a160 R15: ffff888067b4a000
FS:  000055555730c480(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00005557ad94b4e8 CR3: 000000003865f000 CR4: 0000000000350ef0
Call Trace:
 <TASK>
 btrfs_free_block_groups+0xbb6/0x13d0 fs/btrfs/block-group.c:4380
 close_ctree+0x8c4/0xdd0 fs/btrfs/disk-io.c:4413
 generic_shutdown_super+0x161/0x3c0 fs/super.c:693
 kill_anon_super+0x3a/0x60 fs/super.c:1292
 btrfs_kill_super+0x3b/0x50 fs/btrfs/super.c:2144
 deactivate_locked_super+0x9a/0x170 fs/super.c:481
 deactivate_super+0xde/0x100 fs/super.c:514
 cleanup_mnt+0x222/0x3d0 fs/namespace.c:1254
 task_work_run+0x14d/0x240 kernel/task_work.c:180
 resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
 exit_to_user_mode_loop kernel/entry/common.c:171 [inline]
 exit_to_user_mode_prepare+0x215/0x240 kernel/entry/common.c:204
 __syscall_exit_to_user_mode_work kernel/entry/common.c:285 [inline]
 syscall_exit_to_user_mode+0x1d/0x60 kernel/entry/common.c:296
 do_syscall_64+0x44/0xb0 arch/x86/entry/common.c:86
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7faf3687de17
Code: b0 ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 0f 1f 44 00 00 31 f6 e9 09 00 00 00 66 0f 1f 84 00 00 00 00 00 b8 a6 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 01 c3 48 c7 c2 b0 ff ff ff f7 d8 64 89 02 b8
RSP: 002b:00007ffe2bf9fec8 EFLAGS: 00000246 ORIG_RAX: 00000000000000a6
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 00007faf3687de17
RDX: 0000000000000000 RSI: 000000000000000a RDI: 00007ffe2bf9ff80
RBP: 00007ffe2bf9ff80 R08: 0000000000000000 R09: 0000000000000000
R10: 00000000ffffffff R11: 0000000000000246 R12: 00007ffe2bfa1040
R13: 00007faf368c73b9 R14: 00000000001a2e26 R15: 0000000000000018
 </TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the bug is already fixed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite bug's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the bug is a duplicate of another bug, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

Re: [syzbot] [btrfs?] WARNING in btrfs_release_global_block_rsv

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit:    23dfa043f6d5 Merge tag 'i2c-for-6.7-rc2' of git://git.kern..
git tree:       upstream
console+strace: https://syzkaller.appspot.com/x/log.txt?x=123446f4e80000
kernel config:  https://syzkaller.appspot.com/x/.config?x=d05dd66e2eb2c872
dashboard link: https://syzkaller.appspot.com/bug?extid=10e8dae9863cb83db623
compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=17722e24e80000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=11201350e80000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/9653b0ce60b2/disk-23dfa043.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/edbde0f08008/vmlinux-23dfa043.xz
kernel image: https://storage.googleapis.com/syzbot-assets/5490b400b0f9/bzImage-23dfa043.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/5b312257ba2d/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+10e8dae9863cb83db623@syzkaller.appspotmail.com

------------[ cut here ]------------
WARNING: CPU: 0 PID: 5065 at fs/btrfs/block-rsv.c:459 btrfs_release_global_block_rsv+0x24f/0x270 fs/btrfs/block-rsv.c:459
Modules linked in:
CPU: 0 PID: 5065 Comm: syz-executor138 Not tainted 6.7.0-rc1-syzkaller-00304-g23dfa043f6d5 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/10/2023
RIP: 0010:btrfs_release_global_block_rsv+0x24f/0x270 fs/btrfs/block-rsv.c:459
Code: 0f 0b 90 e9 e6 fe ff ff e8 4e d0 d6 fd 90 0f 0b 90 e9 10 ff ff ff e8 40 d0 d6 fd 90 0f 0b 90 e9 3a ff ff ff e8 32 d0 d6 fd 90 <0f> 0b 90 e9 6b ff ff ff e8 24 d0 d6 fd 90 0f 0b 90 eb 8d 66 2e 0f
RSP: 0018:ffffc90003c779f8 EFLAGS: 00010293
RAX: ffffffff83b7ae7e RBX: 000000000005e000 RCX: ffff888075723b80
RDX: 0000000000000000 RSI: 000000000005e000 RDI: 0000000000000000
RBP: 0000000000000001 R08: ffffffff83b7ade4 R09: 1ffff110280edd00
R10: dffffc0000000000 R11: ffffed10280edd01 R12: ffff88814076e000
R13: ffff88814076e058 R14: ffff88801ed3c418 R15: dffffc0000000000
FS:  0000555556ab23c0(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000055f2b88cc448 CR3: 000000001ab8c000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 btrfs_free_block_groups+0xc39/0x1070 fs/btrfs/block-group.c:4366
 close_ctree+0x75a/0xd40 fs/btrfs/disk-io.c:4389
 generic_shutdown_super+0x13a/0x2c0 fs/super.c:696
 kill_anon_super+0x3b/0x70 fs/super.c:1295
 btrfs_kill_super+0x41/0x50 fs/btrfs/super.c:2097
 deactivate_locked_super+0xc1/0x130 fs/super.c:484
 cleanup_mnt+0x426/0x4c0 fs/namespace.c:1256
 task_work_run+0x24a/0x300 kernel/task_work.c:180
 ptrace_notify+0x2cd/0x380 kernel/signal.c:2399
 ptrace_report_syscall include/linux/ptrace.h:411 [inline]
 ptrace_report_syscall_exit include/linux/ptrace.h:473 [inline]
 syscall_exit_work kernel/entry/common.c:251 [inline]
 syscall_exit_to_user_mode_prepare kernel/entry/common.c:278 [inline]
 __syscall_exit_to_user_mode_work kernel/entry/common.c:283 [inline]
 syscall_exit_to_user_mode+0x168/0x2a0 kernel/entry/common.c:296
 do_syscall_64+0x52/0x110 arch/x86/entry/common.c:88
 entry_SYSCALL_64_after_hwframe+0x63/0x6b
RIP: 0033:0x7f7262b90fa7
Code: 08 00 48 83 c4 08 5b 5d c3 66 2e 0f 1f 84 00 00 00 00 00 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 a6 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 01 c3 48 c7 c2 b0 ff ff ff f7 d8 64 89 02 b8
RSP: 002b:00007ffd1c915058 EFLAGS: 00000202 ORIG_RAX: 00000000000000a6
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 00007f7262b90fa7
RDX: 0000000000000000 RSI: 000000000000000a RDI: 00007ffd1c915110
RBP: 00007ffd1c915110 R08: 0000000000000000 R09: 0000000000000000
R10: 00000000ffffffff R11: 0000000000000202 R12: 00007ffd1c9161c0
R13: 0000555556ab3700 R14: 431bde82d7b634db R15: 00007ffd1c916164
 </TASK>


---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

Re: [syzbot] [btrfs?] WARNING in btrfs_release_global_block_rsv

[syzbot]

syzbot has bisected this issue to:

commit c18e3235646a8ba74d013067a6475c8d262d3776
Author: Josef Bacik <josef@toxicpanda.com>
Date:   Thu Dec 2 20:34:32 2021 +0000

    btrfs: reserve extra space for the free space tree

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=10528fb7680000
start commit:   23dfa043f6d5 Merge tag 'i2c-for-6.7-rc2' of git://git.kern..
git tree:       upstream
final oops:     https://syzkaller.appspot.com/x/report.txt?x=12528fb7680000
console output: https://syzkaller.appspot.com/x/log.txt?x=14528fb7680000
kernel config:  https://syzkaller.appspot.com/x/.config?x=d05dd66e2eb2c872
dashboard link: https://syzkaller.appspot.com/bug?extid=10e8dae9863cb83db623
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=17722e24e80000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=11201350e80000

Reported-by: syzbot+10e8dae9863cb83db623@syzkaller.appspotmail.com
Fixes: c18e3235646a ("btrfs: reserve extra space for the free space tree")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

Re: [syzbot] [btrfs?] WARNING in btrfs_release_global_block_rsv

[syzbot]

syzbot suspects this issue was fixed by commit:

commit a6a8f22a4af6c572d9e01ca9f7b515bf0cbb63b1
Author: Josef Bacik <josef@toxicpanda.com>
Date:   Wed Nov 22 17:17:40 2023 +0000

    btrfs: move space cache settings into open_ctree

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=100fec54180000
start commit:   23dfa043f6d5 Merge tag 'i2c-for-6.7-rc2' of git://git.kern..
git tree:       upstream
kernel config:  https://syzkaller.appspot.com/x/.config?x=d05dd66e2eb2c872
dashboard link: https://syzkaller.appspot.com/bug?extid=10e8dae9863cb83db623
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=17722e24e80000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=11201350e80000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: btrfs: move space cache settings into open_ctree

For information about bisection process see: https://goo.gl/tpsmEJ#bisection