From: Christoph Lameter <cl@linux.com> To: Glauber Costa <glommer@parallels.com> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Mel Gorman <mgorman@suse.de>, Tejun Heo <tj@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, Michal Hocko <mhocko@suse.cz>, Johannes Weiner <hannes@cmpxchg.org>, kamezawa.hiroyu@jp.fujitsu.com, David Rientjes <rientjes@google.com>, Pekka Enberg <penberg@kernel.org>, devel@openvz.org, Pekka Enberg <penberg@cs.helsinki.fi>, Suleiman Souhlal <suleiman@google.com> Subject: Re: [PATCH v5 16/18] slab: propagate tunables values Date: Tue, 23 Oct 2012 20:44:10 +0000 [thread overview] Message-ID: <0000013a8f5e3876-25f4d815-cf0a-4574-a321-60ad7a337aa7-000000@email.amazonses.com> (raw) In-Reply-To: <5084FA31.4060709@parallels.com> On Mon, 22 Oct 2012, Glauber Costa wrote: > On 10/19/2012 11:51 PM, Christoph Lameter wrote: > > On Fri, 19 Oct 2012, Glauber Costa wrote: > > > >> SLAB allows us to tune a particular cache behavior with tunables. > >> When creating a new memcg cache copy, we'd like to preserve any tunables > >> the parent cache already had. > > > > SLAB and SLUB allow tuning. Could you come up with some way to put these > > things into slab common and make it flexible so that the tuning could be > > used for future allocators (like SLAM etc)? > > > They do, but they also do it very differently. Like slub uses sysfs, > while slab don't. Well yes that is something that I also want to make more general so that all allocators support sysfs style display of status and tuning. > I of course fully support the integration, I just don't think this > should be a blocker for all kinds of work in the allocators. Converting > slab to sysfs seems to be a major work, that you are already tackling. > Were it simple, I believe it would be done already. Without it, this is > pretty much a fake integration... Well there is quite a bit of infrastructure that needs to be common in order to get this done properly. I hope we will get around to that someday.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Lameter <cl@linux.com> To: Glauber Costa <glommer@parallels.com> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Mel Gorman <mgorman@suse.de>, Tejun Heo <tj@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, Michal Hocko <mhocko@suse.cz>, Johannes Weiner <hannes@cmpxchg.org>, kamezawa.hiroyu@jp.fujitsu.com, David Rientjes <rientjes@google.com>, Pekka Enberg <penberg@kernel.org>, devel@openvz.org, Pekka Enberg <penberg@cs.helsinki.fi>, Suleiman Souhlal <suleiman@google.com> Subject: Re: [PATCH v5 16/18] slab: propagate tunables values Date: Tue, 23 Oct 2012 20:44:10 +0000 [thread overview] Message-ID: <0000013a8f5e3876-25f4d815-cf0a-4574-a321-60ad7a337aa7-000000@email.amazonses.com> (raw) In-Reply-To: <5084FA31.4060709@parallels.com> On Mon, 22 Oct 2012, Glauber Costa wrote: > On 10/19/2012 11:51 PM, Christoph Lameter wrote: > > On Fri, 19 Oct 2012, Glauber Costa wrote: > > > >> SLAB allows us to tune a particular cache behavior with tunables. > >> When creating a new memcg cache copy, we'd like to preserve any tunables > >> the parent cache already had. > > > > SLAB and SLUB allow tuning. Could you come up with some way to put these > > things into slab common and make it flexible so that the tuning could be > > used for future allocators (like SLAM etc)? > > > They do, but they also do it very differently. Like slub uses sysfs, > while slab don't. Well yes that is something that I also want to make more general so that all allocators support sysfs style display of status and tuning. > I of course fully support the integration, I just don't think this > should be a blocker for all kinds of work in the allocators. Converting > slab to sysfs seems to be a major work, that you are already tackling. > Were it simple, I believe it would be done already. Without it, this is > pretty much a fake integration... Well there is quite a bit of infrastructure that needs to be common in order to get this done properly. I hope we will get around to that someday. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-10-23 20:44 UTC|newest] Thread overview: 132+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-10-19 14:20 [PATCH v5 00/18] slab accounting for memcg Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 14:20 ` [PATCH v5 01/18] move slabinfo processing to slab_common.c Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-24 6:43 ` Pekka Enberg 2012-10-24 6:43 ` Pekka Enberg 2012-10-24 6:43 ` Pekka Enberg 2012-10-19 14:20 ` [PATCH v5 02/18] move print_slabinfo_header " Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 14:20 ` [PATCH v5 03/18] sl[au]b: process slabinfo_show in common code Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 14:20 ` [PATCH v5 04/18] slab: don't preemptively remove element from list in cache destroy Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 19:34 ` Christoph Lameter 2012-10-19 19:34 ` Christoph Lameter 2012-10-19 19:34 ` Christoph Lameter 2012-10-22 8:40 ` Glauber Costa 2012-10-22 8:40 ` Glauber Costa 2012-10-22 8:40 ` Glauber Costa 2012-10-24 6:54 ` Pekka Enberg 2012-10-24 6:54 ` Pekka Enberg 2012-10-24 6:54 ` Pekka Enberg 2012-10-24 16:19 ` Glauber Costa 2012-10-24 16:19 ` Glauber Costa 2012-10-19 14:20 ` [PATCH v5 05/18] slab/slub: struct memcg_params Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-23 17:25 ` JoonSoo Kim 2012-10-23 17:25 ` JoonSoo Kim 2012-10-23 17:25 ` JoonSoo Kim 2012-10-24 8:42 ` Glauber Costa 2012-10-24 8:42 ` Glauber Costa 2012-10-19 14:20 ` [PATCH v5 06/18] consider a memcg parameter in kmem_create_cache Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-23 17:50 ` JoonSoo Kim 2012-10-23 17:50 ` JoonSoo Kim 2012-10-23 17:50 ` JoonSoo Kim 2012-10-24 8:42 ` Glauber Costa 2012-10-24 8:42 ` Glauber Costa 2012-10-24 8:42 ` Glauber Costa 2012-10-25 13:42 ` Glauber Costa 2012-10-25 13:42 ` Glauber Costa 2012-10-25 13:42 ` Glauber Costa 2012-10-19 14:20 ` [PATCH v5 07/18] Allocate memory for memcg caches whenever a new memcg appears Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 14:20 ` [PATCH v5 08/18] memcg: infrastructure to match an allocation to the right cache Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-24 18:10 ` JoonSoo Kim 2012-10-24 18:10 ` JoonSoo Kim 2012-10-25 11:05 ` Glauber Costa 2012-10-25 11:05 ` Glauber Costa 2012-10-25 11:05 ` Glauber Costa 2012-10-25 18:06 ` Tejun Heo 2012-10-25 18:06 ` Tejun Heo 2012-10-25 18:06 ` Tejun Heo 2012-10-25 18:08 ` Tejun Heo 2012-10-25 18:08 ` Tejun Heo 2012-10-19 14:20 ` [PATCH v5 09/18] memcg: skip memcg kmem allocations in specified code regions Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 14:20 ` [PATCH v5 10/18] sl[au]b: always get the cache from its page in kfree Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 19:44 ` Christoph Lameter 2012-10-19 19:44 ` Christoph Lameter 2012-10-19 19:44 ` Christoph Lameter 2012-10-22 10:13 ` Glauber Costa 2012-10-22 10:13 ` Glauber Costa 2012-10-22 10:13 ` Glauber Costa 2012-10-19 14:20 ` [PATCH v5 11/18] sl[au]b: Allocate objects from memcg cache Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 19:46 ` Christoph Lameter 2012-10-19 19:46 ` Christoph Lameter 2012-10-19 19:46 ` Christoph Lameter 2012-10-29 15:14 ` JoonSoo Kim 2012-10-29 15:14 ` JoonSoo Kim 2012-10-29 15:14 ` JoonSoo Kim 2012-10-29 15:19 ` Glauber Costa 2012-10-29 15:19 ` Glauber Costa 2012-10-29 15:19 ` Glauber Costa 2012-10-19 14:20 ` [PATCH v5 12/18] memcg: destroy memcg caches Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 14:20 ` [PATCH v5 13/18] memcg/sl[au]b Track all the memcg children of a kmem_cache Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-29 15:26 ` JoonSoo Kim 2012-10-29 15:26 ` JoonSoo Kim 2012-10-29 15:26 ` JoonSoo Kim 2012-10-30 11:31 ` Glauber Costa 2012-10-30 11:31 ` Glauber Costa 2012-10-30 11:31 ` Glauber Costa 2012-10-19 14:20 ` [PATCH v5 14/18] memcg/sl[au]b: shrink dead caches Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 19:47 ` Christoph Lameter 2012-10-19 19:47 ` Christoph Lameter 2012-10-19 19:47 ` Christoph Lameter 2012-10-22 7:37 ` Glauber Costa 2012-10-22 7:37 ` Glauber Costa 2012-10-22 7:37 ` Glauber Costa 2012-10-19 14:20 ` [PATCH v5 15/18] Aggregate memcg cache values in slabinfo Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 19:50 ` Christoph Lameter 2012-10-19 19:50 ` Christoph Lameter 2012-10-22 15:11 ` Glauber Costa 2012-10-22 15:11 ` Glauber Costa 2012-10-19 14:20 ` [PATCH v5 16/18] slab: propagate tunables values Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 19:51 ` Christoph Lameter 2012-10-19 19:51 ` Christoph Lameter 2012-10-22 7:48 ` Glauber Costa 2012-10-22 7:48 ` Glauber Costa 2012-10-23 20:44 ` Christoph Lameter [this message] 2012-10-23 20:44 ` Christoph Lameter 2012-10-19 14:20 ` [PATCH v5 17/18] slub: slub-specific propagation changes Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 14:20 ` [PATCH v5 18/18] Add slab-specific documentation about the kmem controller Glauber Costa 2012-10-19 14:20 ` Glauber Costa 2012-10-19 14:20 ` Glauber Costa
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0000013a8f5e3876-25f4d815-cf0a-4574-a321-60ad7a337aa7-000000@email.amazonses.com \ --to=cl@linux.com \ --cc=akpm@linux-foundation.org \ --cc=cgroups@vger.kernel.org \ --cc=devel@openvz.org \ --cc=glommer@parallels.com \ --cc=hannes@cmpxchg.org \ --cc=kamezawa.hiroyu@jp.fujitsu.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=mhocko@suse.cz \ --cc=penberg@cs.helsinki.fi \ --cc=penberg@kernel.org \ --cc=rientjes@google.com \ --cc=suleiman@google.com \ --cc=tj@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.