From: Christoph Lameter <cl@linux.com>
To: Joonsoo Kim <js1304@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>, azurIt <azurit@pobox.sk>,
Linux Memory Management List <linux-mm@kvack.org>,
cgroups@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Christian Casteyde <casteyde.christian@free.fr>,
Pekka Enberg <penberg@kernel.org>
Subject: Re: [patch 2/2] fs: buffer: move allocation failure loop into the allocator
Date: Wed, 4 Dec 2013 16:33:43 +0000 [thread overview]
Message-ID: <00000142be753b07-aa0e2354-6704-41f8-8e11-3c856a186af5-000000@email.amazonses.com> (raw)
In-Reply-To: <CAAmzW4PwLhMd61ksOktdg=rkj0xHsSGt2Wm_za2Adjh4+tss-g@mail.gmail.com>
On Thu, 5 Dec 2013, Joonsoo Kim wrote:
> Now we have cpu partial slabs facility, so I think that slowpath isn't really
> slow. And it doesn't much increase the management overhead in the node
> partial lists, because of cpu partial slabs.
Well yes that may address some of the issues here.
> And larger frame may cause more slab_lock contention or cmpxchg contention
> if there are parallel freeings.
>
> But, I don't know which one is better. Is larger frame still better? :)
Could you run some tests to figure this one out? There are also
some situations in which we disable the per cpu partial pages though.
F.e. for low latency/realtime. I posted in kernel synthetic
benchmarks for slab a while back. That maybe something to start with.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Lameter <cl@linux.com>
To: Joonsoo Kim <js1304@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>, azurIt <azurit@pobox.sk>,
Linux Memory Management List <linux-mm@kvack.org>,
cgroups@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Christian Casteyde <casteyde.christian@free.fr>,
Pekka Enberg <penberg@kernel.org>
Subject: Re: [patch 2/2] fs: buffer: move allocation failure loop into the allocator
Date: Wed, 4 Dec 2013 16:33:43 +0000 [thread overview]
Message-ID: <00000142be753b07-aa0e2354-6704-41f8-8e11-3c856a186af5-000000@email.amazonses.com> (raw)
In-Reply-To: <CAAmzW4PwLhMd61ksOktdg=rkj0xHsSGt2Wm_za2Adjh4+tss-g@mail.gmail.com>
On Thu, 5 Dec 2013, Joonsoo Kim wrote:
> Now we have cpu partial slabs facility, so I think that slowpath isn't really
> slow. And it doesn't much increase the management overhead in the node
> partial lists, because of cpu partial slabs.
Well yes that may address some of the issues here.
> And larger frame may cause more slab_lock contention or cmpxchg contention
> if there are parallel freeings.
>
> But, I don't know which one is better. Is larger frame still better? :)
Could you run some tests to figure this one out? There are also
some situations in which we disable the per cpu partial pages though.
F.e. for low latency/realtime. I posted in kernel synthetic
benchmarks for slab a while back. That maybe something to start with.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-12-04 16:46 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 20:58 [patch 1/2] mm: memcg: handle non-error OOM situations more gracefully Johannes Weiner
2013-10-08 20:58 ` Johannes Weiner
2013-10-08 20:58 ` Johannes Weiner
2013-10-08 20:58 ` [patch 2/2] fs: buffer: move allocation failure loop into the allocator Johannes Weiner
2013-10-08 20:58 ` Johannes Weiner
2013-10-08 20:58 ` Johannes Weiner
2013-10-11 20:51 ` Andrew Morton
2013-10-11 20:51 ` Andrew Morton
2013-12-04 0:59 ` Andrew Morton
2013-12-04 0:59 ` Andrew Morton
2013-12-04 1:52 ` Joonsoo Kim
2013-12-04 1:52 ` Joonsoo Kim
2013-12-04 1:52 ` Joonsoo Kim
2013-12-04 2:07 ` Andrew Morton
2013-12-04 2:07 ` Andrew Morton
2013-12-04 2:07 ` Andrew Morton
2013-12-04 2:42 ` Joonsoo Kim
2013-12-04 2:42 ` Joonsoo Kim
2013-12-04 15:17 ` Christoph Lameter
2013-12-04 15:17 ` Christoph Lameter
2013-12-04 15:17 ` Christoph Lameter
2013-12-04 16:02 ` Joonsoo Kim
2013-12-04 16:02 ` Joonsoo Kim
2013-12-04 16:33 ` Christoph Lameter [this message]
2013-12-04 16:33 ` Christoph Lameter
2013-12-05 8:44 ` Joonsoo Kim
2013-12-05 8:44 ` Joonsoo Kim
2013-12-05 18:50 ` Christoph Lameter
2013-12-05 18:50 ` Christoph Lameter
2013-12-06 8:57 ` Joonsoo Kim
2013-12-06 8:57 ` Joonsoo Kim
2013-12-13 6:58 ` Joonsoo Kim
2013-12-13 6:58 ` Joonsoo Kim
2013-12-13 6:58 ` Joonsoo Kim
2013-12-13 16:40 ` Christoph Lameter
2013-12-13 16:40 ` Christoph Lameter
2013-12-16 8:22 ` Joonsoo Kim
2013-12-16 8:22 ` Joonsoo Kim
2013-12-16 8:22 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00000142be753b07-aa0e2354-6704-41f8-8e11-3c856a186af5-000000@email.amazonses.com \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=azurit@pobox.sk \
--cc=casteyde.christian@free.fr \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.